From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B028C433F5 for ; Tue, 19 Apr 2022 14:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iK6ZAksZ4a9Vcv723mpQg/I2b3nb1KwWU+bzE9ic/WM=; b=luWjdVggSmqDxs /qKNbLyCB1DGx2Yai5UBJcNhoCDMtnQvApKJhHSpagnZbAR82JohWcPFkXHGJQIoUN4lUktyqzRoy 6HzrXLNv1YDtRGjZ6D3BaoX4a9IcHAPXZXop34I9OXtFuy92d/WwA5eqKYA+MfjUkX1BWTL2eiUNQ 4oEQVAbhxaAg/mXKExSpiAl+iApzavlNCuhsInS/6ir6d8HCrOxVj71t06HV27ZHI9MTmc8JJbQwX bDVQywSLGjrf0+CHPpVTo6cmKuthEeaC6M2f1oDTyqbNkpYeE2YAc1v344qhIvL29fkuE6usoBWa8 Fkkgr6C3QPN4Kw1Dk9QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngoMj-0044Bf-W6; Tue, 19 Apr 2022 13:58:02 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngnlv-003n0P-6J for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 13:20:02 +0000 Received: by mail-ej1-x635.google.com with SMTP id k23so32866217ejd.3 for ; Tue, 19 Apr 2022 06:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cWoWgEcXIMYRuEsZLERLpvc6D4fQ6dZb3dEHGDCcqIs=; b=fY6TQpn2KPv+1NlQy1Jow9T1OohAsjrB3oV9ppqNtHvd0r+4OW08v/avNwv1G8Odjm D/2GsdfYMSvjtxG1P4B7SzmR2XTR5xS2bZ0XXxMVMHNciSyV6R5MO6AkQwLdeFk1lHfh Cgt7v30oEPEsJbmsWTr9+ULhOcR1ribWin+0SWBgoc1mhBYRwOlMDx37E219LP/c8iur e8Jl67Cq3yYNgZHQHPlunLvMK0ujRMh0wPaA5jNKhTst45qBNw6ujFZl8BZe81KmcSAw S+BsJt8ItH1FzOurK6u7x4BM44CcrZpOkFaSvq0vaqehD0L+SUhwh2c75xAXXhRm0fg5 rMMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cWoWgEcXIMYRuEsZLERLpvc6D4fQ6dZb3dEHGDCcqIs=; b=jiaA5aRVF626UjA+9rVIDzmu5zNZI9YSs7X9TrxtsaYFNBygYwdJ3Wbw+KwCwvSLPY E7TUfwzJEKIIiTKxRNvRdb0ptMlZI7YMUHAuRat9Khoaoa4pXQvuZZ9WtdfzfqjiYpwv Dj6sttn/1CTAfUvntjNpq6chnqIFUJHjoldnNKa9IRxQG3Nh7nEaaShkW8rWwwwBkSaT 1D2Vs+Mssqx+kM2gE+/26Fa71mDrLxNj2zmQTBG1kfv6Ith+JJYbvRtoSdMasSIllPRu +VZqTKhnJTr7R7Gy4vuzxLgH2O1pSy9eHca57yvI4Awsfm7cYliisYf1y31F6AtcqHBF X0/g== X-Gm-Message-State: AOAM530QY8R4UgfZe7W+sGMqjQ2sNK/Tkz5yU9CNi7sHNw/2VhvGVPUM DwgE6kRkFCs+L63n3rLqqblsbb8uqcoDITiYAhwawg== X-Google-Smtp-Source: ABdhPJwnqnEl1PogZpbrEzxXO0aXN+psYbjJRFm+NSGmxo/x2WJ/ZC6/8hzNHXDDrwtWHaCSyZ4gF5RFiYFl5n9G5cc= X-Received: by 2002:a17:907:1c8a:b0:6e9:2a0d:d7b7 with SMTP id nb10-20020a1709071c8a00b006e92a0dd7b7mr13404246ejc.572.1650374394669; Tue, 19 Apr 2022 06:19:54 -0700 (PDT) MIME-Version: 1.0 References: <20220418034444.520928-1-tongtiangen@huawei.com> <20220418034444.520928-4-tongtiangen@huawei.com> <073cb6a6-3dbc-75d4-dbfe-a5299a6b0510@arm.com> In-Reply-To: <073cb6a6-3dbc-75d4-dbfe-a5299a6b0510@arm.com> From: Pasha Tatashin Date: Tue, 19 Apr 2022 09:19:16 -0400 Message-ID: Subject: Re: [PATCH -next v4 3/4] arm64: mm: add support for page table check To: Anshuman Khandual Cc: Tong Tiangen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andrew Morton , Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , LKML , linux-mm , Linux ARM , linux-riscv@lists.infradead.org, Kefeng Wang , Guohanjun X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_061959_277468_7D2A7077 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 6:22 AM Anshuman Khandual wrote: > > > On 4/18/22 09:14, Tong Tiangen wrote: > > +#ifdef CONFIG_PAGE_TABLE_CHECK > > +static inline bool pte_user_accessible_page(pte_t pte) > > +{ > > + return pte_present(pte) && (pte_user(pte) || pte_user_exec(pte)); > > +} > > + > > +static inline bool pmd_user_accessible_page(pmd_t pmd) > > +{ > > + return pmd_present(pmd) && (pmd_user(pmd) || pmd_user_exec(pmd)); > > +} > > + > > +static inline bool pud_user_accessible_page(pud_t pud) > > +{ > > + return pud_present(pud) && pud_user(pud); > > +} > > +#endif > Wondering why check for these page table entry states when init_mm > has already being excluded ? Should not user page tables be checked > for in entirety for all updates ? what is the rationale for filtering > out only pxx_user_access_page entries ? The point is to prevent false sharing and memory corruption issues. The idea of PTC to be simple and relatively independent from the MM state machine that catches invalid page sharing. I.e. if an R/W anon page is accessible by user land, that page can never be mapped into another process (internally shared anons are treated as named mappings). Therefore, we try not to rely on MM states, and ensure that when a page-table entry is accessible by user it meets the required assumptions: no false sharing, etc. For example, one bug that was caught with PTC was where a driver on an unload would put memory on a freelist but memory is still mapped in user page table. Pasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel