From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 588B0C11D20 for ; Thu, 20 Feb 2020 21:38:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A1AE206F4 for ; Thu, 20 Feb 2020 21:38:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IF5UczU5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r2fzHkSm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A1AE206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VSdcCfqgfI7CwIg3rX6ADr9Cv1NKCgpISsjoPK9obl0=; b=IF5UczU5jVfCOG WutoFNAVoc0+CyCha5rxK2GuDSsX+OQthIDXS3vrwISUCajgdKm/ySl4l07tmlV58wtG0orJxvyyi byGru5zfRorK8P5OK15ESMDrWOESpppeG7j34pltzmFToN2qMgCJA41DBEoEY8mFQKTe6j9gC3rJo LZOGRvUwk/3CB0hfAnIKlPKrZMEKxwfxCMNH53eMjBjNv+O7qlIyezdqtS7zNHB96i31jE1QSZdTx zXSZ7++ejXBbaoEPYwq8HSB42/2VCn/nGuK4pSuEP0wLj2ppzVpD2f9sxDAgTVxF6ariUx4SBBsqd 7jB6I5SYRMxRwKCH3qUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4tWI-0007eD-V6; Thu, 20 Feb 2020 21:38:06 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4tW7-0007Uk-25 for linux-arm-kernel@lists.infradead.org; Thu, 20 Feb 2020 21:37:57 +0000 Received: by mail-qk1-x741.google.com with SMTP id j8so5026827qka.11 for ; Thu, 20 Feb 2020 13:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mtH2MLidwl9++wyo68VivOeVZ1eKeqRlT2z3fduTibk=; b=r2fzHkSmmhSOpPfv60LemDTCouA+wqlfydNS58a7/9b6oAvY7dvlVy0m1X9qfp6GFO f8E4BulhWJ1JfqyMWvEnqCzi+E+mm+IjnNRN8kwLQaQiT9H+EvvnG/RhhzXYfJm7/1vG xXgnpVsIPdwy1iPX/czKlk6DJtKpuMkcby6F3bYuSSj67Xe3d2tJM+maIgbKPxiF8Rxe 0qmU0XioEhfpkCjkSMaWNsAzW7rbkRERdPsFzUYmcbsAnXMnJZiF75GLubTl1qR6RRn0 Rc5Bky5Lyws72PzUbnl8udHa/xLeqLCTmPnIJbo3yEXex3g6FU/60garybwdad8FNYGg f5ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mtH2MLidwl9++wyo68VivOeVZ1eKeqRlT2z3fduTibk=; b=Sce2tBVxlPvufEMTshYNDICUUIxjdXlhl0Zyrcb+EuTL+UmzDual7LV/4Yvd8gU4ot ZotfCFH/JpD4fVrwOQwPD/LkjJsRutqlffh45XtDYDvySA9aP0u3uOMZXk/j8HXvSa3R A42c5iPriCsGNHxyY7KYXAv8axZFIsC0yZYOcq+5yzf+7Qz0qIrCNlExJzC/P1mXRAVO k9lgIIix7eL6GEbMkspJLTUB6DeYLrRLBjuJ5+XYGg4P6/cV1fbYnLLAANAU+NZ53byn Q2sQFZs4DQfMPBka2QPtoo9k1v5D6/ADmm2atvDFCmNgsX8JCpthi3WwhJZ/r7vIi1A+ Mzwg== X-Gm-Message-State: APjAAAUhcZUBjCUNjkz1U64mcUf/QF5e3QFk90dDfTl5HayAayoq7jN2 iyZyn713lsxI6gtw4w599s+eU0kJ96pJmalHLKI= X-Google-Smtp-Source: APXvYqzC17jJf8WSEQarDVhinql9TAMsf5KB/vSzhkgDO/I0O9wFO00fmXTLO3jktl0H/mpFHoh4KIlD6179zJYx+90= X-Received: by 2002:a37:b285:: with SMTP id b127mr3343845qkf.413.1582234673672; Thu, 20 Feb 2020 13:37:53 -0800 (PST) MIME-Version: 1.0 References: <20200220083508.792071-1-anarsoul@gmail.com> <20200220083508.792071-6-anarsoul@gmail.com> <20200220135929.GF4998@pendragon.ideasonboard.com> In-Reply-To: <20200220135929.GF4998@pendragon.ideasonboard.com> From: Vasily Khoruzhick Date: Thu, 20 Feb 2020 13:37:40 -0800 Message-ID: Subject: Re: [PATCH 5/6] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support To: Laurent Pinchart X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200220_133755_161854_40610D3C X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , David Airlie , Linus Walleij , dri-devel , Andrzej Hajda , Thierry Reding , Sam Ravnborg , Stephen Rothwell , Samuel Holland , Heiko Stuebner , Chen-Yu Tsai , Icenowy Zheng , Stephan Gerhold , Jonas Karlman , Torsten Duwe , Rob Herring , Maxime Ripard , arm-linux , Jernej Skrabec , linux-kernel , Mark Brown , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 20, 2020 at 5:59 AM Laurent Pinchart wrote: > > Hi Vasily, Hi Laurent, > > Thank you for the patch. > > On Thu, Feb 20, 2020 at 12:35:07AM -0800, Vasily Khoruzhick wrote: > > This commit adds support for the NewEast Optoelectronics CO., LTD > > WJFH116008A 11.6" 1920x1080 TFT LCD panel. > > > > Signed-off-by: Vasily Khoruzhick > > --- > > drivers/gpu/drm/panel/panel-simple.c | 47 ++++++++++++++++++++++++++++ > > 1 file changed, 47 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index e14c14ac62b5..aa04afaf3d26 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -2224,6 +2224,50 @@ static const struct panel_desc netron_dy_e231732 = { > > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > }; > > > > +static const struct drm_display_mode neweast_wjfh116008a_modes[] = { > > +{ > > + .clock = 138500, > > + .hdisplay = 1920, > > + .hsync_start = 1920 + 48, > > + .hsync_end = 1920 + 48 + 32, > > + .htotal = 1920 + 48 + 32 + 80, > > + .vdisplay = 1080, > > + .vsync_start = 1080 + 3, > > + .vsync_end = 1080 + 3 + 5, > > + .vtotal = 1080 + 3 + 5 + 23, > > + .vrefresh = 60, > > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, > > +}, { > > + .clock = 110920, > > + .hdisplay = 1920, > > + .hsync_start = 1920 + 48, > > + .hsync_end = 1920 + 48 + 32, > > + .htotal = 1920 + 48 + 32 + 80, > > + .vdisplay = 1080, > > + .vsync_start = 1080 + 3, > > + .vsync_end = 1080 + 3 + 5, > > + .vtotal = 1080 + 3 + 5 + 23, > > + .vrefresh = 48, > > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, > > +} }; > > This should be indented one step to the right, see boe_nv101wxmn51_modes > for instance. Will do. > The only different between the two modes is the clock, leading to > different refresh rates. Are only those two clock frequencies supported, > or does the panel support anything in-between as well ? In the latter > case, would it make sense to use display_timing instead of > drm_display_mode ? See dlc_dlc0700yzg_1_timing for an example. These are coming from EDID. The datasheet [1] says typical frequency is 138.5MHz and min/max are not specified, so I'm not sure whether it supports anything in between. I did check that both modes work though. [1] http://files.pine64.org/doc/datasheet/pinebook/11.6inches-1080P-IPS-LCD-Panel-spec-WJFH116008A.pdf > > + > > +static const struct panel_desc neweast_wjfh116008a = { > > + .modes = neweast_wjfh116008a_modes, > > + .num_modes = 2, > > + .bpc = 6, > > + .size = { > > + .width = 260, > > + .height = 150, > > + }, > > + .delay = { > > + .prepare = 110, > > + .enable = 20, > > + .unprepare = 500, > > + }, > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > + .connector_type = DRM_MODE_CONNECTOR_eDP, > > +}; > > + > > static const struct drm_display_mode newhaven_nhd_43_480272ef_atxl_mode = { > > .clock = 9000, > > .hdisplay = 480, > > @@ -3399,6 +3443,9 @@ static const struct of_device_id platform_of_match[] = { > > }, { > > .compatible = "netron-dy,e231732", > > .data = &netron_dy_e231732, > > + }, { > > + .compatible = "neweast,wjfh116008a", > > + .data = &neweast_wjfh116008a, > > }, { > > .compatible = "newhaven,nhd-4.3-480272ef-atxl", > > .data = &newhaven_nhd_43_480272ef_atxl, > > -- > Regards, > > Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel