From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D9FC43331 for ; Tue, 12 Nov 2019 19:45:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5620C214E0 for ; Tue, 12 Nov 2019 19:45:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P8LYrviz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o+YyU3q/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5620C214E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CKCV/Fbgh68ZeoucgW6uREzSOmywFb5roL+/kFkEVf0=; b=P8LYrvizsbvI6t LO7Nzru/S4yWnhYkmPdjL1bNqwOinIIh5HqIzbM1ffIl0mIi0w5HUP4rl1V+3H6ir6Pb1NB3REmxX gQegj+1EfHDRb7klYShEVocwo6bqqKw6hlLOg6pvX13fAfQBqdacJCPkwuWKR2JwxvxlAACrC4igj LIuuKBDW6gTpU4OLX7gQ8rX7BohYq+6Fa9fQuJFQy14UwhmYnIHNfu99jVDywtbU1l62F968JZaZz 2EX8T1WX+x9qQjY03kHsrDQt72w+bywYLwNIGJtZ56K1wxpIIuZq6CZnGdcL6hQi2hj8+g3nY6TCq TuqXEhnyHzLcCduvSM7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUc6l-0006dY-Sn; Tue, 12 Nov 2019 19:45:47 +0000 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUc6h-0006cQ-Tf; Tue, 12 Nov 2019 19:45:46 +0000 Received: by mail-oi1-x244.google.com with SMTP id n14so15918771oie.13; Tue, 12 Nov 2019 11:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aT8mlE5QKLBKzwtpRTeEBBrUs4C8xdANZDGBqdRq3Ec=; b=o+YyU3q/7tS3hSUL3qhMWK8gHir34a4yLqHbcFe0Gj2ESVOO8nukuBj2haOH/7Qj6y 3kWdjZYOHpEqUSMGFC5x3ZsfJ+SXfSgJdc3F4Qa7fPA66bBJvGoxri6/eEL8wpz8oosp uScKBkCRbEYbVWRf35NaROo2aBThK3DmWxWnsEUnJxim9T10KsO60RrOCpKMEjNuUTmk ZuhE4t9cEOFQQ2COssjYllC3+HQAAJARQtV3Ta+VVI6CMTOjWm3qnTB+6QB0bwWZ+6e6 DZYbUVts9hMFDOuw/s7X8REfl+EeABbTsQvlGmtbxgXAgL1pQxlPftYHyrgEDGTVEMA/ 82Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aT8mlE5QKLBKzwtpRTeEBBrUs4C8xdANZDGBqdRq3Ec=; b=BatVKM+Cwrz8tiLGk/nOaJMB7n9DnYxGfOFu0frtl5YqHTrJtCvsvEIvW08vmvlKhI WUb59t0Dq4agawtoc2AvSt2GfZLIsHIQOBgopxJ/lVoNg0XPRRbw0jBV+fGW5lIASAVx CLbx+L2wPoqIuRLXqtghC+wW9gw4veL9RSGPiehyKWjmWgIORvFmtC1ljj2c7+LqrJUX h11I6keCHz/hLT976hZ5yy8JoG4w1Az/HgnwDgfK02Q3j79AJDT1yrIaGu2E6ZtWndbX gn8oHIZLZGGDbJNG3NVl8Iv9UNdmDGuWK7L9px/bho0SX1jXZ7UJ7GfFqZelWZVOFXdu z8HQ== X-Gm-Message-State: APjAAAU5WMYNTMy7uNZgShT/ffoG7RUreu4nptVJHbtfOzb7l5VTVnHp BTfA9pT6lCWiq09NRY0mOIsDCwf0lD+7zSTY4o03Ug== X-Google-Smtp-Source: APXvYqyRPDBQNhx456qORWcHwmKAtqvKzYgiTN6/NkEw8HgUh8m9K6PNHJvchs1ngl1qmIajDdIjjqNuiOCDWrTUSD8= X-Received: by 2002:aca:4945:: with SMTP id w66mr625898oia.98.1573587942600; Tue, 12 Nov 2019 11:45:42 -0800 (PST) MIME-Version: 1.0 References: <20190907174833.19957-1-katsuhiro@katsuster.net> <81666aeb-f3d0-e653-6597-0711a05f9b8d@katsuster.net> <1ecd115a-1d33-020d-4a09-6fc451588920@katsuster.net> In-Reply-To: <1ecd115a-1d33-020d-4a09-6fc451588920@katsuster.net> From: Vasily Khoruzhick Date: Tue, 12 Nov 2019 11:46:07 -0800 Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64 To: Katsuhiro Suzuki X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_114543_959808_9D1A29AE X-CRM114-Status: GOOD ( 34.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, Heiko Stuebner , arm-linux , linux-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 12, 2019 at 10:34 AM Katsuhiro Suzuki wrote: > > On 2019/11/12 14:49, Vasily Khoruzhick wrote: > > On Mon, Nov 11, 2019 at 9:43 PM Vasily Khoruzhick wrote: > >> > >> On Mon, Nov 11, 2019 at 9:34 PM Katsuhiro Suzuki > >> wrote: > >>> > >>> Hello Vasily, > >>> > >>> Thank you for valuable information. > >>> > >>> On 2019/11/12 4:25, Vasily Khoruzhick wrote: > >>>> On Sun, Nov 10, 2019 at 9:40 PM Vasily Khoruzhick wrote: > >>>>> > >>>>> On Sun, Nov 10, 2019 at 7:30 PM Katsuhiro Suzuki > >>>>> wrote: > >>>>>> > >>>>>> Hello Vasily, > >>>>> > >>>>> Hi Katsuhiro, > >>>>> > >>>>> Thanks for response! > >>>> > >>>> Looks like on my board codec sits at address 0x10, and according to > >>>> schematics that's what its address is supposed to be. > >>>> > >>>> See http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf > >>>> > >>>> Codec address is selected by pin CE of ES8316, and on rockpro64 it > >>>> goes to GND through R226. So address should be 0x10. > >>>> > >>> > >>> Yes, I agree. The schematics both v2.0 and v2.1 say that ES8316 > >>> address is 0x10. Thank you for pointing. > >>> > >>> But I wonder that my RockPro64 behavior is strange, he is in address > >>> 0x11. (R226 on my board is broken...??) > >>> > >>> root@rockpro64:~# i2cdetect 1 > >>> WARNING! This program can confuse your I2C bus, cause data loss and worse! > >>> I will probe file /dev/i2c-1. > >>> I will probe address range 0x03-0x77. > >>> Continue? [Y/n] y > >>> 0 1 2 3 4 5 6 7 8 9 a b c d e f > >>> 00: -- -- -- -- -- -- -- -- -- -- -- -- -- > >>> 10: -- UU -- -- -- -- -- -- -- -- -- -- -- -- -- -- > >>> 20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- > >>> 30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- > >>> 40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- > >>> 50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- > >>> 60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- > >>> 70: -- -- -- -- -- -- -- -- > >>> > >>> I plan to check R226 resistance value to judge R226 is broken or not > >>> after return to home. And share the result with you. > >>> Please give me a time. > >> > >> Thanks for confirming that on your board it's on address 0x11. I > >> checked with some other rockpro64 owners and they have it on 0x10, but > >> looks like we have boards with codec on different address in the wild. > > > > Another datapoint is that my board is 2.0. If yours is 2.1 it can be a > > difference between 2.0 and 2.1. > > > > I'm using v2.1 board. > > > I'll share the checking result. It's a little strange. > > 1) Voltage of CE pin of ES8316 > > It is 1.8V when booting linux-next kernel. > > > 2) My board > > I can't find no crack nor broken parts on my board. > > > 2) R225, R226 > > As you know, RockPro64 board has no silk print so we cannot know > perfectly which resistance is R226. So this is my assumption. > > PCIe, SD card slot > (top) > LAN (left)ES8316(right) USB, reset button > > On the left space of ES8316 there is no resistance, only a pattern. > This is maybe R225. And 10K resistance on the right side of a > pattern. I assume this is R226. > > If my assumption is correctly, board implementation and schematics > are different. > > schematics of v2.1 gets something wrong...?? Guess we need few more RockPro64 v2.1 owners to confirm that it's indeed the case. > > >>> Best Regards, > >>> Katsuhiro Suzuki > >>> > >>> > >>>>>> Thank you for reporting. > >>>>>> > >>>>>> On 2019/11/11 9:17, Vasily Khoruzhick wrote: > >>>>>>> On Sat, Sep 7, 2019 at 10:48 AM Katsuhiro Suzuki > >>>>>>> wrote: > >>>>>>>> > >>>>>>>> This patch adds audio codec (Everest ES8316) and I2S audio nodes for > >>>>>>>> RK3399 RockPro64. > >>>>>>> > >>>>>>> Hi Katsuhiro, > >>>>>>> > >>>>>>> I tested your patch with my rockpro64 on 5.4-rc6 which has your other > >>>>>>> patches to es8316 driver, but apparently it doesn't work. > >>>>>>> > >>>>>>> 'alsamixer' complains 'cannot load mixer controls: No such device or > >>>>>>> address' and if I try to play audio with mpg123 it pretends that it > >>>>>>> plays something but there's no sound. > >>>>>>> > >>>>>>> Any idea what can be wrong? > >>>>>>> > >>>>>> > >>>>>> Do you use defconfig? If so I guess we need turn on more configs: > >>>>>> > >>>>>> - simple-graph-card driver (CONFIG_SND_AUDIO_GRAPH_CARD) > >>>>>> - ES8316 (SND_SOC_ES8316) > >>>>> > >>>>> I have these enabled, card is present in /proc/asound/cards, but > >>>>> alsamixer doesn't work with it. > >>>>> > >>>>>> FYI) ASoC related status or logs in my environment as follows: > >>>>>> > >>>>>> root@rockpro64:~# uname -a > >>>>>> Linux rockpro64 5.4.0-rc6-next-20191108 #169 SMP PREEMPT Mon Nov 11 12:21:44 JST 2019 aarch64 GNU/Linux > >>>>> > >>>>> I'm running 5.4.0-rc6 (commit > >>>>> 00aff6836241ae5654895dcea10e6d4fc5878ca6) with your patch "arm64: dts: > >>>>> rockchip: add analog audio nodes on rk3399-rockpro64" on top of it. > >>>>> > >>>>>> root@rockpro64:~# dmesg | grep -i asoc > >>>>>> [ 21.509903] asoc-simple-card hdmi-sound: i2s-hifi <-> ff8a0000.i2s mapping ok > >>>>>> [ 21.510550] asoc-simple-card hdmi-sound: ASoC: no DMI vendor name! > >>>>>> [ 21.567906] asoc-audio-graph-card sound: ES8316 HiFi <-> ff890000.i2s mapping ok > >>>>>> [ 21.568565] asoc-audio-graph-card sound: ASoC: no DMI vendor name! > >>>>> > >>>>> Similar here: > >>>>> > >>>>> [vasilykh@rockpro64 ~]$ dmesg | grep -i asoc > >>>>> [ 15.627685] asoc-audio-graph-card sound: ES8316 HiFi <-> > >>>>> ff890000.i2s mapping ok > >>>>> [ 16.250196] asoc-simple-card hdmi-sound: i2s-hifi <-> ff8a0000.i2s mapping ok > >>>>> > >>>>>> root@rockpro64:~# cat /proc/asound/pcm > >>>>>> 00-00: ff8a0000.i2s-i2s-hifi i2s-hifi-0 : ff8a0000.i2s-i2s-hifi i2s-hifi-0 : playback 1 > >>>>>> 01-00: ff890000.i2s-ES8316 HiFi ES8316 HiFi-0 : ff890000.i2s-ES8316 HiFi ES8316 HiFi-0 : playback 1 : capture 1 > >>>>> > >>>>> Same here: > >>>>> > >>>>> [vasilykh@rockpro64 ~]$ cat /proc/asound/pcm > >>>>> 00-00: ff890000.i2s-ES8316 HiFi ES8316 HiFi-0 : ff890000.i2s-ES8316 > >>>>> HiFi ES8316 HiFi-0 : playback 1 : capture 1 > >>>>> 01-00: ff8a0000.i2s-i2s-hifi i2s-hifi-0 : ff8a0000.i2s-i2s-hifi > >>>>> i2s-hifi-0 : playback > >>>>> > >>>>>> root@rockpro64:~# cat /sys/kernel/debug/asoc/components > >>>>>> hdmi-audio-codec.3.auto > >>>>>> ff8a0000.i2s > >>>>>> ff8a0000.i2s > >>>>>> ff890000.i2s > >>>>>> ff890000.i2s > >>>>>> ff880000.i2s > >>>>>> ff880000.i2s > >>>>>> es8316.1-0011 > >>>>>> snd-soc-dummy > >>>>>> snd-soc-dummy > >>>>> > >>>>> Same here. > >>>>> > >>>>>> root@rockpro64:~# cat /sys/kernel/debug/asoc/dais > >>>>>> i2s-hifi > >>>>>> ff8a0000.i2s > >>>>>> ff890000.i2s > >>>>>> ff880000.i2s > >>>>>> ES8316 HiFi > >>>>>> snd-soc-dummy-dai > >>>>> > >>>>> Same here. > >>>>> > >>>>> Yet alsamixer doesn't work for me. It terminates with 'cannot load > >>>>> mixer controls: No such device or address'. Strace shows that fails > >>>>> here: > >>>>> > >>>>> openat(AT_FDCWD, "/dev/snd/controlC0", O_RDWR|O_CLOEXEC) = 3 > >>>>> fcntl(3, F_SETFD, FD_CLOEXEC) = 0 > >>>>> ioctl(3, SNDRV_CTL_IOCTL_PVERSION, 0xfffffd3ad04c) = 0 > >>>>> fcntl(3, F_GETFL) = 0x20002 (flags O_RDWR|O_LARGEFILE) > >>>>> fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK|O_LARGEFILE) = 0 > >>>>> ioctl(3, SNDRV_CTL_IOCTL_ELEM_LIST, 0xfffffd3ad228) = 0 > >>>>> ioctl(3, SNDRV_CTL_IOCTL_ELEM_LIST, 0xfffffd3ad228) = 0 > >>>>> ioctl(3, SNDRV_CTL_IOCTL_ELEM_INFO, 0xfffffd3ace38) = 0 > >>>>> ioctl(3, SNDRV_CTL_IOCTL_ELEM_READ, 0xfffffd3ac160) = -1 ENXIO (No > >>>>> such device or address) > >>>>> > >>>>> Looks like it fails to talk to the codec? > >>>>> > >>>>> mpg123 thinks that it's playing audio, but my headphones connected to > >>>>> 3.5mm output are silent. > >>>>> > >>>>> Regards, > >>>>> Vasily > >>>>> > >>>>> > >>>>>> Best Regards, > >>>>>> Katsuhiro Suzuki > >>>>>> > >>>>>> > >>>>>>> Regards, > >>>>>>> Vasily > >>>>>>> > >>>>>>>> Signed-off-by: Katsuhiro Suzuki > >>>>>>>> --- > >>>>>>>> .../boot/dts/rockchip/rk3399-rockpro64.dts | 28 +++++++++++++++++++ > >>>>>>>> 1 file changed, 28 insertions(+) > >>>>>>>> > >>>>>>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >>>>>>>> index 0401d4ec1f45..8b1e6382b140 100644 > >>>>>>>> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >>>>>>>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >>>>>>>> @@ -81,6 +81,12 @@ > >>>>>>>> reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; > >>>>>>>> }; > >>>>>>>> > >>>>>>>> + sound { > >>>>>>>> + compatible = "audio-graph-card"; > >>>>>>>> + label = "rockchip,rk3399"; > >>>>>>>> + dais = <&i2s1_p0>; > >>>>>>>> + }; > >>>>>>>> + > >>>>>>>> vcc12v_dcin: vcc12v-dcin { > >>>>>>>> compatible = "regulator-fixed"; > >>>>>>>> regulator-name = "vcc12v_dcin"; > >>>>>>>> @@ -470,6 +476,20 @@ > >>>>>>>> i2c-scl-rising-time-ns = <300>; > >>>>>>>> i2c-scl-falling-time-ns = <15>; > >>>>>>>> status = "okay"; > >>>>>>>> + > >>>>>>>> + es8316: codec@11 { > >>>>>>>> + compatible = "everest,es8316"; > >>>>>>>> + reg = <0x11>; > >>>>>>>> + clocks = <&cru SCLK_I2S_8CH_OUT>; > >>>>>>>> + clock-names = "mclk"; > >>>>>>>> + #sound-dai-cells = <0>; > >>>>>>>> + > >>>>>>>> + port { > >>>>>>>> + es8316_p0_0: endpoint { > >>>>>>>> + remote-endpoint = <&i2s1_p0_0>; > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> }; > >>>>>>>> > >>>>>>>> &i2c3 { > >>>>>>>> @@ -505,6 +525,14 @@ > >>>>>>>> rockchip,playback-channels = <2>; > >>>>>>>> rockchip,capture-channels = <2>; > >>>>>>>> status = "okay"; > >>>>>>>> + > >>>>>>>> + i2s1_p0: port { > >>>>>>>> + i2s1_p0_0: endpoint { > >>>>>>>> + dai-format = "i2s"; > >>>>>>>> + mclk-fs = <256>; > >>>>>>>> + remote-endpoint = <&es8316_p0_0>; > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> }; > >>>>>>>> > >>>>>>>> &i2s2 { > >>>>>>>> -- > >>>>>>>> 2.23.0.rc1 > >>>>>>>> > >>>>>>>> > >>>>>>>> _______________________________________________ > >>>>>>>> linux-arm-kernel mailing list > >>>>>>>> linux-arm-kernel@lists.infradead.org > >>>>>>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >>>>>>> > >>>>>> > >>>> > >>> > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel