From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9186AC433E0 for ; Mon, 13 Jul 2020 05:16:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60B3F20724 for ; Mon, 13 Jul 2020 05:16:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jxr8K6yX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="t1YTVsAO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60B3F20724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5rvNHyy/Mcql5LTYRB3NPPe30ygewO+qNJpIz81uxa4=; b=Jxr8K6yXP7WDvkAqBVhqUBIGE PbQaJ5CHKleCufMV6c0pTaFZUOYBbVw0+PKfZ6aib56B+zCjs4BrY3LmTfkkjOdNfpowryxgAFWeL RxuF1OblscySGXZqSQZ6r/Xly0WfFHnnawviuzPmevgLpeLtZmVCY0NhQ6BCwNhOEKqkMm3jH1eLn 5K2W7JzmS2L0Tzv5/J9BrKOk9ftgRDlkG/4b2lFXXtYr/j3wwx5rWtjnh+ntSfAUiCNZej2VwNqNG 1IMnMN0G84QGEmMjsHOoyVGJS9Rzhyop7g+S9hkRcrqdLPb0Xf3AuKXuq9cWMTevy/irk9eZVbql9 TcSyiUcrg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juqnu-0003UF-R4; Mon, 13 Jul 2020 05:15:02 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juqnr-0003TE-EJ for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 05:15:00 +0000 Received: by mail-qk1-x742.google.com with SMTP id 145so11088145qke.9 for ; Sun, 12 Jul 2020 22:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HJfMKkuixe8TcFmSgPVFQeX2ebVBk2NIfALDJvpOegk=; b=t1YTVsAOG7g2piVPzr9XqfcOnf1nl6fNsrPCzOhU25jJur4I0iJE19KVWcxP9TixlH hA57KrAkQoI5IRkXUIwJDb5X00QSGkNpOaOxcD3Nan/XQTZVduQjrEg9Z14YNRooh0xq YkYJUAB1lMa26uVrPQtmfvx05NKveu8jVXhT7ISzvFaojV/IuhzB9juQsNLM3nZX6QQD /qypLMf6oZvwdlxwTxzwIwzH7E9u7lNMkYjJAceAoVyAthjE9BnK7zA8TE7Rk6oyIh60 ynOFniFe80hCUQ6h5+qkWRhJ8BTalGQHjoywwL3/780fkljffvktE9z46d8S7NnRo8NP Pcrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HJfMKkuixe8TcFmSgPVFQeX2ebVBk2NIfALDJvpOegk=; b=pdAsYkuM4AUlet3agri7ILLNyj4KLBTNUNGFX538lDn0sfKNj8Z/tTlyhuuncLCZMU 7tePf784v38TqRTnsFV8/SZQ0TYBI/+r5TAKB4KgQRqLkhfOqoq1zYrUTGRciYFPNAz1 SQ2OWtNMuXfE0sw/M/eeGhpmsyCFL77FXFp6ql7huVHej5EPo5c6UGDG9PWBHpUGGdrt MoZWBMDzmy/kbKRgrgYZB8amrH1cHwBmchlO36c0ORtqmzoH3EZrFt5PlobWetpq+fqP ay30+BY5Q1aSeASPL9BovM6zgQVhdpe7Cjv7HpAQ1OxalZ0UbIg+av+G4AGXrlnWsukt QKng== X-Gm-Message-State: AOAM531mkndzr++09pfeu8qKgjC4JILB+txLItXoG8agnQTJjydniJPR xkT7rj+4GsSTXyzhd5fnEXT8cCR0pW6RHqi8xPQz5oDZkxc= X-Google-Smtp-Source: ABdhPJzZeRI4Vo+yZmNHHCrZWhnaKiX6BuWRvS5dt2QggK3l73mOoFiEQTzrVHTr+lD9cXIK0pQuLgSHhO8q2rUM2KU= X-Received: by 2002:a37:ec7:: with SMTP id 190mr75015576qko.421.1594617297477; Sun, 12 Jul 2020 22:14:57 -0700 (PDT) MIME-Version: 1.0 References: <20200705195110.405139-1-anarsoul@gmail.com> <20200705195110.405139-4-anarsoul@gmail.com> <20200706114709.l6poszepqsmg5p5r@gilmour.lan> In-Reply-To: <20200706114709.l6poszepqsmg5p5r@gilmour.lan> From: Vasily Khoruzhick Date: Sun, 12 Jul 2020 22:14:31 -0700 Message-ID: Subject: Re: [PATCH 3/3] arm64: allwinner: a64: enable Bluetooth On Pinebook To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_011459_528783_D8E86E1A X-CRM114-Status: GOOD ( 18.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , devicetree , Johan Hedberg , netdev , Marcel Holtmann , linux-kernel , "open list:BLUETOOTH DRIVERS" , Chen-Yu Tsai , Rob Herring , Jakub Kicinski , "David S. Miller" , arm-linux Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 6, 2020 at 4:47 AM Maxime Ripard wrote: > > Hi, > > On Sun, Jul 05, 2020 at 12:51:10PM -0700, Vasily Khoruzhick wrote: > > Pinebook has an RTL8723CS WiFi + BT chip, BT is connected to UART1 > > and uses PL5 as device wake GPIO, PL6 as host wake GPIO the I2C > > controlling signals are connected to R_I2C bus. > > > > Enable it in the device tree. > > > > Signed-off-by: Vasily Khoruzhick > > --- > > .../arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts > > index 64b1c54f87c0..e63ff271be4e 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts > > @@ -408,6 +408,18 @@ &uart0 { > > status = "okay"; > > }; > > > > +&uart1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; > > + status = "okay"; > > You probably need uart-has-rtscts here Will add in v2 > > + > > + bluetooth { > > + compatible = "realtek,rtl8723cs-bt"; > > + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */ > > + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > > + }; > > And max-speed I guess? There's no max-speed in the schema for this bluetooth controller. Moreover it reads uart settings from firmware config. See btrtl_get_uart_settings() in drivers/bluetooth/btrtl.c > Maxime > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel