From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92454C04E53 for ; Wed, 15 May 2019 15:09:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E5B02084E for ; Wed, 15 May 2019 15:09:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TYzxWmtY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MjJ+LF+8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E5B02084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OgJrhYZRGUp+Ol/0HfW1/lU0npdCYlRDbUT4xsAHf1w=; b=TYzxWmtY13KFf7 Z8C+MhwCzztYG/PfswGUKdojZ0/GtLoRtglP032/sklO3Qa9+WKNzXQDuwooX4Vjj0i9yvpJaH+Zz sbxYZcMOPAaSdH7XDVbBBBgFSaHfNHVCFtd7W7Ci/WGn5Y8WNRd1oiCbstGGWFb27Un4Ut+ZJmcfS j9LIMRCoIFLx88eXXuhECiax8Cb1+q3R0sBCCgM5O5+FxryAHCofVK9F7kCJpLJ+BDPZ/IApI9wfw UnOGim59hjuO1i3FF0C03UfdNtYw3WfZo866NZmJQ9BbijXuC5t8Ypaw4oPr4WQOP4M3d5Le0Qqpn CLDy6jkxM6zs/Q87gndg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQvX7-0006Hn-3F; Wed, 15 May 2019 15:09:29 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQvX4-0006Gx-9X for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2019 15:09:27 +0000 Received: by mail-oi1-x242.google.com with SMTP id m204so48509oib.0 for ; Wed, 15 May 2019 08:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FzdAY9eNLFH6q18HeEB4S9VM37pJLDSHQjylPsT3TbY=; b=MjJ+LF+8pBMZJmrf/PUQGYzx6jkAIvZXVOaDkwDUy9j8LjnckyRKVimNt3qRpZ7QXs odt09gcUESirFG4LKGWD8wrs44NwvpmYA2lxf+ihQ7feGSSECN829NXz97xTZk1YqWok 35/lGba1azoqDEabJk9bWsU7/bkhsjO9nkRYDhC0oT9sbfj+MNtAHSqEKLAJhOF3S6Rs R+rUWZGYA0dVjK3uQ9i1dVZfPXcCRFzlBj3LZ2YdHmMedSaa4kOtX9v0QZ8SKRLyhu7Z yvA1skM2zKLs6y+yPy3x/+CSXqODR2VRcyLDYU2/3JhylYVvTFrpq49h0oyAJEL7ENkN jPtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FzdAY9eNLFH6q18HeEB4S9VM37pJLDSHQjylPsT3TbY=; b=exJW5jK9JdTQWufhw1C7NsjiySggmO4SWGEiFpnNWIJMA6C6ti4cvCoQEWFG2JTjSO fZL3mUUOzOk4LlKFlZlQq4vjrwdBkgZtdQTNcRmvGpQYpdgDS0qASggNt9Zbsv3Dvgri 0iuQbJhg6ioPgGyvg74YFJn2xGmRtbuKccUFNTLhMJFxRLwjRKmLax+095QeMUN61ZSN qZVEkXYqOsGppMNwRpg1etVA+vkZsODOs957NwH2yCA+C3Qf1vOKQxXrwPhCs+2G0Ywl VSYqr5fxDOQbzvjR9ZqBFMxAnK5PMjCmcV0YAcct/bVLfU8v/8LwIb2nRU78DZmYC+l9 j+0w== X-Gm-Message-State: APjAAAVVAv/LvqeNVVeG5+N/fqJxq2caNvJmZeGhqu+WVIpOYuWQ/NyS qxkdMeCBio9kP5caFoksFH7fByylrJTwfCTz2Ac= X-Google-Smtp-Source: APXvYqx2op3tX9A4P1hZwzw0eFhbk5CfYg0Tbl3ieHQEQJwA11MZzaowFPPO1ZfSsj+7d5NaD8TUBJpiL4dsKvwOW9o= X-Received: by 2002:aca:240d:: with SMTP id n13mr6735433oic.145.1557932964018; Wed, 15 May 2019 08:09:24 -0700 (PDT) MIME-Version: 1.0 References: <20190514155911.6C0AC68B05@newverein.lst.de> <20190514160241.9EAC768C7B@newverein.lst.de> <20190515093141.41016b11@blackhole.lan> In-Reply-To: <20190515093141.41016b11@blackhole.lan> From: Vasily Khoruzhick Date: Wed, 15 May 2019 08:08:57 -0700 Message-ID: Subject: Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I To: Torsten Duwe X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190515_080926_362224_0C449E2B X-CRM114-Status: GOOD ( 20.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Andrzej Hajda , David Airlie , linux-kernel , dri-devel , Maxime Ripard , Chen-Yu Tsai , Rob Herring , Thierry Reding , Laurent Pinchart , Daniel Vetter , Harald Geyer , Sean Paul , arm-linux , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 15, 2019 at 12:32 AM Torsten Duwe wrote: > > On Tue, 14 May 2019 10:48:40 -0700 > Vasily Khoruzhick wrote: > > > > + anx6345: anx6345@38 { > > > + compatible = "analogix,anx6345"; > > > + reg = <0x38>; > > > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 > > > */ > > > + dvdd25-supply = <®_dldo2>; > > > + dvdd12-supply = <®_dldo3>; > > > + > > > + port { > > > + anx6345_in: endpoint { > > > + remote-endpoint = > > > <&tcon0_out_anx6345>; > > > + }; > > > + }; > > > > It doesn't comply with bindings document. You need to add out endpoint > > It does comply with the bindings. The ports are all optional. > As far as DT is concerned, the signal path ends here. This is also the > final component _required_ to get the Linux kernel DRI up and running. Ugh, then bindings should be fixed. It's not optional. It may work if bootloader enables power for you, but it won't if you disable display driver in u-boot. > > as well, and to do so you need to add bindings for eDP connector first > > and then implement panel driver. > > See Rob's suggestions here: http://patchwork.ozlabs.org/patch/1042593/ > > Well, one *could* extend the hardware description down to the actual > panel if necessary, but on the Teres-I it is not. I assume the panel > they ship provides proper EDID to the anx6345, because the display > works fine here with this DT. I guess you're testing it with older version of anx6345. Newer version that supports power management [1] needs startup delay for panel. Another issue that you're seeing is that backlight is not disabled on DPMS events. All in all, you need to describe panel in dts. [1] https://github.com/anarsoul/linux-2.6/commit/2fbf9c242419c8bda698e8331a02d4312143ae2c > Do I understand this correctly that the (3 different?) pinebook panels > are not that easy to handle? I try to include the pinebook wherever > possible, just because it's so similar, but here I'm a bit lost, so I > had to omit these parts. > > Should I also have added a Tested-by: ? ;-) I don't have Teres, so I haven't tested these. > > Torsten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel