From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50F6EC43334 for ; Wed, 8 Jun 2022 15:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4K0HFzN2Pn1rIXE467stlN+oNnPMEWn56g1W6utlyxc=; b=xamKndv8PJGVKx A5Xsy0HJRTi+2XUdbUbiusjRtpJBKcbQa8pzRxT0oVxtcd0ZdgzjxH/V6JioCHfOAAwG+lCDB9CWt fwn3erPVspXngf8L57Hinj4MInNkf4QRAfrO/0RLOfK9TcOWPYKiepge8t2lhUy3YX6LifJJtv8iC 7q4yhS/rzPZ9HqjCedMZPFrgb2yvJjSlr9NoWqY0z9xmY5TjSWfj1nlBg0ioAbdF5bQXWS2Duk8dR Yv7tBQPStAcpOiAmRfR90I1GHEhscpxoyGcrRhzc+C/v8WRwSnbvWF5jhM9BDp8Pfli4OzMtWeguf oXUSf8j8+KPM7+S4BZzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyxXQ-00E1Ge-3Q; Wed, 08 Jun 2022 15:24:04 +0000 Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyxXM-00E1Er-37 for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 15:24:01 +0000 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-e656032735so27655722fac.0 for ; Wed, 08 Jun 2022 08:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H6iQ1oiG4jqbRTAVgqyiczhzaZiBR3863cdsPwx94jE=; b=ZAKXSBqjVvyYD1DtUywOeOLaK2m28DXPZEgG+1XMHv4nCFXk9wRZ4biu72jxqhOm2V qTZJVZMpWLHLA7oFHQHqsVjYECEus3IgpInDpaRrPTb7j1wUP83DQSzd1EXj2o3OMnqu It1KIGAuzXgMOJX+IOOYkqXCa7ty/Jt7xW2kThXu+Ko2EniIDv0fylfnsEKFcD3e3Ax6 1r5LlP5HizW0m3xa/eiqTnrEnsuil6ghqC6sZ6/zybBIzsXp2bpx/I5Q8g5FXzd5/svK pZRuqt1zH8i66lqQX9tzqcDCxh+vWpC/JFuPnWKGOWmcRkxKfj5XYmjFfByQOYpCEnDT YB6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H6iQ1oiG4jqbRTAVgqyiczhzaZiBR3863cdsPwx94jE=; b=BL42xieEwcI2qDVO6hRAWI6Brl2/cPX91hpl86fSFufTPPQ3DqwW9LQcTzhvhC8deq h6GLeTv2TPEZTt/lxMEBrlUL76mCAMyIQeiw8ZJhLALJ1Q8XiZUZtyh054IBUbQuGbb0 4aG+O3vXGEOt8NNMKq8JyTm0tPx3jdphf6B7jSHqkGbuqhNB0vODJmcKrd5gInlrFtFQ 9/bttVxtWF0f3nf33EgT+CAYPLx1OuSlCfrHutIJSi2ncr/8jtBsRiQp7C9s654XeaEX DngtOk6rBwCmcr3IukzJkFkrtfmgJkJK2/wA5f2KgN1TKcmGsxWwRjRJQoWYDQaWSnZO urQQ== X-Gm-Message-State: AOAM5303wiqrObV3uqTxnFabbzTIrB7l/LKJjjP6HRAzVHcRMMF/ZkqS JYgBxWof3wr3ywa07pacKLqB7jrdiY1Yk4QXcts6sg== X-Google-Smtp-Source: ABdhPJwWh0t18ojumdlRudXhBLwAtkB8k6FbFwmPSKZgVK0Aco06/t4gPcQUgndn2klBnUFc65KaTHwARgYsZ7pj0Sc= X-Received: by 2002:a05:6870:828d:b0:f3:4dd7:5ceb with SMTP id q13-20020a056870828d00b000f34dd75cebmr2758965oae.294.1654701837865; Wed, 08 Jun 2022 08:23:57 -0700 (PDT) MIME-Version: 1.0 References: <20220528113829.1043361-1-maz@kernel.org> <20220528113829.1043361-7-maz@kernel.org> In-Reply-To: <20220528113829.1043361-7-maz@kernel.org> From: Fuad Tabba Date: Wed, 8 Jun 2022 16:23:21 +0100 Message-ID: Subject: Re: [PATCH 06/18] KVM: arm64: Add three sets of flags to the vcpu state To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Alexandru Elisei , Oliver Upton , Will Deacon , Quentin Perret , Mark Brown , kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_082400_172404_5C5B9126 X-CRM114-Status: GOOD ( 27.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On Sat, May 28, 2022 at 12:38 PM Marc Zyngier wrote: > > It so appears that each of the vcpu flags is really belonging to > one of three categories: > > - a configuration flag, set once and for all > - an input flag generated by the kernel for the hypervisor to use > - a state flag that is only for the kernel's own bookkeeping I think that this division makes sense and simplifies reasoning about the state and what needs to be communicated to the hypervisor. I had a couple of minor nits, which I have already pointed out in the relevant patches. With that, patches 6~18: Reviewed-by: Fuad Tabba Cheers, /fuad > > As we are going to split all the existing flags into these three > sets, introduce all three in one go. > > No functional change other than a bit of bloat... > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 5eb6791df608..c9dd0d4e22f2 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -338,6 +338,15 @@ struct kvm_vcpu_arch { > /* Miscellaneous vcpu state flags */ > u64 flags; > > + /* Configuration flags */ > + u64 cflags; > + > + /* Input flags to the hypervisor code */ > + u64 iflags; > + > + /* State flags, unused by the hypervisor code */ > + u64 sflags; > + > /* > * We maintain more than a single set of debug registers to support > * debugging the guest from the host and to maintain separate host and > -- > 2.34.1 > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel