From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6996C11F64 for ; Thu, 1 Jul 2021 13:46:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99611613FD for ; Thu, 1 Jul 2021 13:46:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99611613FD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Kb3YsyLt18NeR1LSpdK8zMmQA/X+av7NQD13/fy4Vk=; b=b4kO15h4iWadgo euCAD0pg5LIcN+wEEpFhVXHbws0H2hFTD/Cz9EtlEn4I7GEaCw7wwrikB1Gcza8UW+ri6eZA6j3HU NrimTHo1hh7aUT3s3ZBvNYZkUNsM76zB6jLRzJcOinLHfAQfNL5Ju0JePrlLqlk2ip2Kf31mAf0js +6QBZaG2xZRlfLVpefyrfxrY6Pk+RFui7quGdvlSFzOVo9qUK2zHEMiInq0AJ44SPTP4vPdQeDbHJ vdJiMB0yaP/QRnad5FnkS0mTzsquNSClO0zX9Z5iXNsRDvh2oooYs+9Gc0GcSUi3PkL8N+ryeF9Qc gI/QVKCCKiGqZ31ZpPJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyx0V-00HX8H-H0; Thu, 01 Jul 2021 13:45:31 +0000 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyx0R-00HX7n-KZ for linux-arm-kernel@lists.infradead.org; Thu, 01 Jul 2021 13:45:28 +0000 Received: by mail-ot1-x333.google.com with SMTP id 110-20020a9d0a770000b0290466fa79d098so6542051otg.9 for ; Thu, 01 Jul 2021 06:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3Z3Ky60fuRUeEkGom9Yl2zloU6rr5fasjCslnLTq5J4=; b=h1FHCJUTz+cPJ99ikqnWnu26wAhDi9Pbj2yi2ayDZV8XMkma6MQmm1iJ1OfkLzQrXa s5vBTY5sOM3h7IYkT+9aN9odhxcQqU/WjX9wH1rSGjswAXS2yGBj1/V4Le1bIYfGzIP8 GB3QWd2YPXBm4mhdC7uFzRXGV7BIv6cGzzQARDWby9RfgrAQ9GfuGYLENR65ZlArlxGe sPzzTVQBS2Dgh5WIyzqCHF7hazDhs1V/KKprP8FODoL+Z4SgzHINpIca+4jAfnccHvGL jezzJBTipS2zc1gyrEhz6lmv9r9GdVsSHfXL9DzEnqZr6/IxlIM9FYXz4FkPxm5tI98n +J4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3Z3Ky60fuRUeEkGom9Yl2zloU6rr5fasjCslnLTq5J4=; b=TooY4zfQu+NeHk8k8a30GOhfzGuleuvaYrLx/XZJs02i2K0povFcsNSdP5r1nqhGWC IHrCXze4YnItAUIcgBtfWr/157QKd7PhIoThBnB1bKalcBzEHRPzw/0kJwzkjcDrOwWe 22wlrTAz6JUt4gpI25eXZScTjf5CLhKmnBq7IDVW6Msd6X8fGN52ZZEMutbRrw5wOFhX FVlhjHqlw+czTOh79QVKRhP/9RKym8l1BKnZ6VX0s0d52MUBacw6uWT2t8IHdBpW6TmK Qxf/aL+WVhZ36uuWhIyolNqKyOIF59rOYpM8ZhfZSLSjjJQC74fkfoCNvBSzP1HTa4nS kBzw== X-Gm-Message-State: AOAM532MvU3ppWA5p9McxXvhn4AzmBUYITehkT8zQT1JFfqs5CwMuke6 aSjvBG/v4nXFAEQm5jK0kD46wPqB2k8B+k3rcFJOkw== X-Google-Smtp-Source: ABdhPJzeim6ujWY7qJh+wtQAcoH/aBYP+t9YLKycAH2wxkD4xqTn7Nen+pj2ik7IL4o31/4yRywN6rMyo9yoBfWXbvM= X-Received: by 2002:a05:6830:1de2:: with SMTP id b2mr30219otj.365.1625147126448; Thu, 01 Jul 2021 06:45:26 -0700 (PDT) MIME-Version: 1.0 References: <20210615133950.693489-1-tabba@google.com> <20210615133950.693489-4-tabba@google.com> <20210701130149.GC9757@willie-the-truck> In-Reply-To: <20210701130149.GC9757@willie-the-truck> From: Fuad Tabba Date: Thu, 1 Jul 2021 14:44:50 +0100 Message-ID: Subject: Re: [PATCH v2 03/13] KVM: arm64: Fix names of config register fields To: Will Deacon Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_064527_733006_B2DCD7AE X-CRM114-Status: GOOD ( 23.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, On Thu, Jul 1, 2021 at 2:01 PM Will Deacon wrote: > > On Tue, Jun 15, 2021 at 02:39:40PM +0100, Fuad Tabba wrote: > > Change the names of hcr_el2 register fields to match the Arm > > Architecture Reference Manual. Easier for cross-referencing and > > for grepping. > > > > Also, change the name of CPTR_EL2_RES1 to CPTR_NVHE_EL2_RES1, > > because res1 bits are different for VHE. > > > > No functional change intended. > > > > Signed-off-by: Fuad Tabba > > --- > > arch/arm64/include/asm/kvm_arm.h | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h > > index 25d8a61888e4..bee1ba6773fb 100644 > > --- a/arch/arm64/include/asm/kvm_arm.h > > +++ b/arch/arm64/include/asm/kvm_arm.h > > @@ -31,9 +31,9 @@ > > #define HCR_TVM (UL(1) << 26) > > #define HCR_TTLB (UL(1) << 25) > > #define HCR_TPU (UL(1) << 24) > > -#define HCR_TPC (UL(1) << 23) > > +#define HCR_TPCP (UL(1) << 23) > > This one is a bit weird: the field is called TPCP if the CPU supports > FEAT_DPB but is called TPC otherwise! So I don't think renaming it like > this really makes anything better. Perhaps add a comment: > > #define HCR_TPC (UL(1) << 23) /* TPCP if FEAT_DPB */ I missed that. That's why it's referred to as Bit[23] in the diagram. I'll add the comment and revert its name. Thanks, /fuad > ? > > Rest of the patch looks good: > > Acked-by: Will Deacon > > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel