From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A00C5C433EF for ; Mon, 18 Oct 2021 12:35:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CEC9604E9 for ; Mon, 18 Oct 2021 12:35:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6CEC9604E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GdEbF44StaY+ChpVp+mgbQ24AgHDqirK87H79PK7mFY=; b=iX9cqsFYIM09qn 6UyZgMnnc3w+6x2u9ja5lhcxON/meqWCwC5cEF1qSPnoq1efQVWBv6Fu8NTYC0SQK7mzVvnu7+XAI PBifIz6IETNQ0N9Cq9IGCMk4SCAoEHelmZdlwwcyNG5clOUicBsGqaL409lRmjlqTqwhowRnQ8mfl Dy5wBXc08jPq5zD4hBAIOBAP29it9lSWCAZYSRA/AQzbJpaHdjXW7iyTdk+u4RqzD9iP+uYOEHxu6 JYR/HYJLkyU9epehH9ZDRL0okllwRqP2JxEwNqdCyUXKMqvsDx5BZc1I2lEdUL9UowKqV9Hn6QQL0 ZVTnLpOY0EG+/lmlqzbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcRqd-00FeEU-0r; Mon, 18 Oct 2021 12:34:35 +0000 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcRqZ-00FeE4-T4 for linux-arm-kernel@lists.infradead.org; Mon, 18 Oct 2021 12:34:33 +0000 Received: by mail-ot1-x335.google.com with SMTP id p6-20020a9d7446000000b0054e6bb223f3so356230otk.3 for ; Mon, 18 Oct 2021 05:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1pbSkqWxiSZgJ8e5OjIcgFH/1bBQSml1rT02P7vRiI8=; b=Mgez5oeoSkR2Rfz90An/K8bMShcEt62O9xMJHG2RoiYEVmzfIBQxHJ4d5vdTZ6v31H L0IT059zRHYOmef8sJmO1oflziQY7bbPRfhrja6d7dtbka+dM6x6L8/4FQOfHwB26wdv kY7Gh2SM5lI9RuTLn0YbJB9veeZN+M3KRADX5Yv1nSFP5i99IGPTCpAC5P0T7Wt9HtuN uNmuTJkg4ag9DNYfCqh9pbvTVWwOx6ZiLp1tKrtkJs3JcmYE6DxAi+M/E8NdiyFFVRwY LXRR+V84Bqp2JG2NInoUALz+Q5xh7vVpNXCVVZpk8JAD8PYdsSzJUQfE30kYhpzXQ/Lm ne3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1pbSkqWxiSZgJ8e5OjIcgFH/1bBQSml1rT02P7vRiI8=; b=MdHMBHlpJyzL/TQoq7IvE05aWjD7x+0VhRWR1iQsNzN2GwcBo+FS+14XNSr/Yvn2pK jU/KzZEmUpK2gyp2FHg67PlDeLxfqqCaIkq27zXhbLMHaMZWULPFjOHp6T9H2Mp2Fu7P P55E8PZRcOx16t4bejoVTd/7yuVhQw9cnddVRfvCAvoWyVc72hQCi366lbJt2c44T8Ge VforSbSfHa3SXylzLt2kePqLs1P8BuNcvHpH8aFl/yJjggKYlIb/KQWmjQ4y3jKd5cJh luXam7lkVjK+Z1pDvn+Euex+1j03jK+ji7HDy0BuyrJxVFcCpEl1/vMiozEt2Hx578fK zVXA== X-Gm-Message-State: AOAM5317iPJO4sSHKPizF36Vzm3xrclTVyHjS0/s+iQdFPMY4UIDEmWD WwXzrS4W24+0ZtkQmmb7LGAZRIKJQg8/wq8Rmff10Q== X-Google-Smtp-Source: ABdhPJwmLCo4x7wGytVHP4ezHwU7qhNTDaKBXu8Z84dYPzNngqLyw3XKmfneyTsFw7kja67groR2U7W6EsbitXQCZTU= X-Received: by 2002:a05:6830:210c:: with SMTP id i12mr21214780otc.102.1634560470718; Mon, 18 Oct 2021 05:34:30 -0700 (PDT) MIME-Version: 1.0 References: <20211010145636.1950948-12-tabba@google.com> <20211013120346.2926621-1-maz@kernel.org> <20211018104505.52jvpuhxkbstzerg@gator.home> In-Reply-To: <20211018104505.52jvpuhxkbstzerg@gator.home> From: Fuad Tabba Date: Mon, 18 Oct 2021 13:33:54 +0100 Message-ID: Subject: Re: [PATCH v9 00/22] KVM: arm64: Fixed features for protected VMs To: Andrew Jones Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, pbonzini@redhat.com, oupton@google.com, qperret@google.com, kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_053431_983099_14B268D3 X-CRM114-Status: GOOD ( 26.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Oct 18, 2021 at 11:45 AM Andrew Jones wrote: > > On Mon, Oct 18, 2021 at 10:51:54AM +0100, Fuad Tabba wrote: > > Hi Marc, > > > > On Wed, Oct 13, 2021 at 1:04 PM Marc Zyngier wrote: > > > > > > This is an update on Fuad's series[1]. > > > > > > Instead of going going back and forth over a series that has seen a > > > fair few versions, I've opted for simply writing a set of fixes on > > > top, hopefully greatly simplifying the handling of most registers, and > > > moving things around to suit my own taste (just because I can). > > > > > > I won't be reposting the initial 11 patches, which is why this series > > > in is reply to patch 11. > > > > Thanks for this series. I've reviewed, built it, and tested it with a > > dummy protected VM (since we don't have proper protected VMs yet), > > which initializes some of the relevant protected VMs metadata as well > > as its control registers. So fwiw: > > > > Reviewed-by: Fuad Tabba > > > > And to whatever extent possible at this stage: > > Tested-by: Fuad Tabba > > > > Hi Fuad, > > Out of curiosity, when testing pKVM, what VMM do you use? Also, can you > describe what a "dummy pVM" is? Is it a just pVM which is not actually > protected? How similar is a pVM to a typical VIRTIO-using VM? Actually, > maybe I should just ask if there are instructions for playing with pKVM > somewhere that I could get a pointer to. Considering the WIP state of pKVM, my setup is hacky and not that stable. I use QEMU, along with Will'ls pKVM user ABI patches [*] and a couple of hacks added on top to run a normal VM with the protected codepath applied to it, to be able to do some testing and sanity checking. There isn't really any proper way of playing with protected VMs yet. Thanks, /fuad [*] https://lore.kernel.org/kvmarm/20210603183347.1695-1-will@kernel.org/ > Thanks, > drew > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel