From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
Vincent Abriou <vincent.abriou@st.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Sean Paul <sean@poorly.run>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm/sti: Include the right header
Date: Mon, 2 Sep 2019 15:12:06 +0200 [thread overview]
Message-ID: <CA+M3ks7TbSmr4LQkEbOD0WnzO2aSg-8cyg5UAfo5YdfOBMwFfg@mail.gmail.com> (raw)
In-Reply-To: <20190823071428.6155-1-linus.walleij@linaro.org>
Le ven. 23 août 2019 à 09:14, Linus Walleij <linus.walleij@linaro.org> a écrit :
>
> The sti_hdmi.c file include <linux/of_gpio.h> despite not even
> using any GPIOs.
>
> What it does use is devm_ioremap_nocache() which comes from
> <linux/io.h> implicitly by including that header.
>
> Fix this up by including the right header instead.
Applied on drm-misc-next,
Thanks
Benjamin
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index f03d617edc4c..4f1aaf222cb0 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -9,7 +9,7 @@
> #include <linux/debugfs.h>
> #include <linux/hdmi.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> +#include <linux/io.h>
> #include <linux/platform_device.h>
> #include <linux/reset.h>
>
> --
> 2.21.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-09-02 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 7:14 [PATCH] drm/sti: Include the right header Linus Walleij
2019-09-02 13:12 ` Benjamin Gaignard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+M3ks7TbSmr4LQkEbOD0WnzO2aSg-8cyg5UAfo5YdfOBMwFfg@mail.gmail.com \
--to=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).