From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06874C07E96 for ; Tue, 6 Jul 2021 11:07:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C666561C18 for ; Tue, 6 Jul 2021 11:07:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C666561C18 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vkG2PakAurhjz/dKHN4u80woltDujpB2YcahrgL32HU=; b=2NYXW+4Fsg8nTC wiUPCokL/ZYclvU+wSWHX6wpwxm8DDykslWmMSfCv7IwNa8jspHI2V4DzubOl2S944C6+WMVLfcly uHnTNYRtELjziEnyQkB2yBIwkcKOmed71wKhU4fTCjbHslWX9i1ajLc5J16Z/6AGDf/XitjYqBhqQ DNqnNxlXm+ECRNB3rPW/gAdJ6ahmyFPkK56QAqNOXKaBeSCJukSxwqNnLEWankQW1ZZZHcjfKMrgf rHNz7riGKqVas6QWqXfaY/f+S8C3A1isUyeqXVwJEQKx7aVTHqv/RbDnilrHcfjF2j/qnJlDL2Z47 35h73FO+bEt8F4dt9PSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0iqR-00B9k8-BY; Tue, 06 Jul 2021 11:02:27 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0ipA-00B9BE-43 for linux-arm-kernel@lists.infradead.org; Tue, 06 Jul 2021 11:01:09 +0000 Received: by mail-io1-xd2b.google.com with SMTP id u7so22165359ion.3 for ; Tue, 06 Jul 2021 04:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FYk8/MFnVtA7gBfngdQB39lzbb1HLN8KQZCQ/UZ++gI=; b=mqRfuAl9FMaPmM8mndYbPgNaTr/4muXGUtAj0aCIVo1DzDJZHyZxeNF57pK/mEv4G2 bCYhHwF3fX7HA8RxBT8bMsEaXi5swrk6OA2lSrk7s9Bd3Y1QYqzG8ChA2G1FIhPDgDs6 Mftlv3kB7UFCoozmFUffi/lYHnU1fchrthktlfUbcONCXWyLYtWUsMJsZNM169S4pNZd QxaLqqDFtyZ8OuBFNuBPSLrOHtb8+4L6a5s7/JrMGfJj+pvUNYtDQHNz2oqYH9mjum96 VNtiixoAp3LPgG7Roj8oGTOI8UBQWLwtgFEkf+QxM1lQjGOY+BIkqTtd06ukNz327txp bWkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FYk8/MFnVtA7gBfngdQB39lzbb1HLN8KQZCQ/UZ++gI=; b=GGNiln2IQqaWiZ4HEibhyxWba90zrOH8CgoN3cSSyrmoYR4yj0Zld/jXTiwp6dRMW2 SESVrv8N4CyRWR7qkjuSGZR9/cr5BIFYtw9i8BbzAQ3ZvlpuQLFqpQVZZyUItw9l8LqQ 7lru1QQKi1Nu6S4dPuFF6KrQlnvx6MWUKs0SUSunoWmGiHMzZs8NjkDHn+13DVbPzeB7 IQZZphOjb9l9hgY8l4zlxK2GIs3N6tl5hbDj3pYfuSSa7jPAgk2VbNng1hcSx9waybkP /DnFTBnKjAtJQxo8o3X+s8lNrW0GZUTpVZ8diwFwHFSZcdPVlV0/JRAZRnkNhhJWnH+I Rq9Q== X-Gm-Message-State: AOAM532OdBdttC+eREBGEjVKg9nVYUPaRW0ZbDqOaiRW/8qfzu1APUh7 H9V8VjPo/lqja1NK9iMg/XJOiLVYKei9eFgyvnVa/g== X-Google-Smtp-Source: ABdhPJwfVqDJZJ8YMxlfHDI/5iWfU93hNngTm71CYO5d2lEfAycitsV1Wbt0lZDaTUxVYOgEgo1j1trbkKDAIraFWas= X-Received: by 2002:a5d:96cb:: with SMTP id r11mr586569iol.53.1625569267395; Tue, 06 Jul 2021 04:01:07 -0700 (PDT) MIME-Version: 1.0 References: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com> <1625038079-25815-9-git-send-email-kyrie.wu@mediatek.com> In-Reply-To: <1625038079-25815-9-git-send-email-kyrie.wu@mediatek.com> From: Tzung-Bi Shih Date: Tue, 6 Jul 2021 19:00:56 +0800 Message-ID: Subject: Re: [PATCH v2,8/9] media: mtk-jpegenc: Generalize jpegenc HW operations interfaces To: "kyrie.wu" Cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Bin Liu , Matthias Brugger , Tzung-Bi Shih , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Tomasz Figa , xia.jiang@mediatek.com, maoguang.meng@mediatek.com, srv_heupstream@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210706_040108_221632_A399D105 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu wrote: > Generalizes jpegenc select/deselect HW and set params interfaces. No code is using the functions. The patch needs to be submitted with other patches. > +static int mtk_jpeg_select_hw(struct mtk_jpeg_ctx *ctx) > +{ > + int hw_id = -1; > + int i; > + unsigned long flags; > + struct mtk_jpeg_dev *jpeg = ctx->jpeg, *comp_jpeg = NULL; comp_jpeg doesn't need to be initialized. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel