From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A625C433DB for ; Tue, 2 Feb 2021 03:52:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FD8964ECE for ; Tue, 2 Feb 2021 03:52:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FD8964ECE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2vG5Q2FOgGo38hSDpcwYbsjYdpOILPWqsVW0ZWAGVqw=; b=s9WTwinexLrarUHI2ntXgH2dE +wK84qvBdd5QQqYp+2KFHeZRnviwjyRuTChzk1Q91LmMKsQj6ZdqQeQblTLXdg3rrh5kQIiIa+XbO Rgrz6gKXMvoVREwbET1CI5aMwTbBCugNIUcgyxQBmJRLnKqiVMhiGkYy1XW/ldn6AGPmRSX2ogGEU ISnQ6JEL2zglu6dTI1VOEgDA5ILhiDwsvon/Yg8CBS50ZyxU2FYt+fTiNgylUfJ65rLBKTZPRwz4a S1V90BMV2IZw3ahHDkPYSkewAs6ZbQsgtLbxcN70uaORYc49Lx/Zy7uqLn5R08Qf/vhz+WK4ocIWP dja8xFWoA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6miw-0001OJ-23; Tue, 02 Feb 2021 03:51:30 +0000 Received: from mail-il1-x129.google.com ([2607:f8b0:4864:20::129]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6mit-0001NV-G6 for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 03:51:28 +0000 Received: by mail-il1-x129.google.com with SMTP id a16so153181ilq.5 for ; Mon, 01 Feb 2021 19:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DUbVLJ+6EapSl5sVNLf8sgof9k3YF74Apn4NRNuZrBI=; b=G139zDlnZdSnzIKH7yG75Inkorodk6X7AjLca6dTCwnjSMyL1PTsMAWZbIzfthY3R/ l8oxeWNBoH7WS3B3ILFRsEFRguGNqVruEpnIW/oJuq9kukOrYVIY2fSXSvBptglZ0eM9 bb2hgs2LbjxiECmNi0TNOMF+lqm5YVN30AvK20Y18+IAq4YKOET0Vli6u3q9SXw68Mhj 6xYne4B8ydAADwTKwuzAnO6mKZ9F40RtN1M4C4i6N9Asa8uh/R9oJd5EL+sq5mg/hVpP iTohNwVMbv2/+j6wVhOL99ZY/Ng+qkog64cUg44UbFyz2AaHNfIDKKcZyE8pbPQV6gtM 0HVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DUbVLJ+6EapSl5sVNLf8sgof9k3YF74Apn4NRNuZrBI=; b=m8HRJXTUWEFy3rTMtC/sL03QUfv1TJpKnhSKQaK/m0CoWUl4X9Gfz4MibZ9mMwBiuz 5tZvtxFVrT2atYZ5m2Mlfb0jzdPI8By8r3AY8rGhkB+pnRuOi2+EZdj1DRFgQQbnBQjs 0K+ejWyTJ4c9TBVufnerz0QDXec0f5Xvy0sU2fWK0cqieKtB6waOi3NWdtdcBCy3jCRp QLcPyh69vASakCmLxll9b2ooqB53BQBTuqpIh6+RttDKC/cBWFg0JXTz3jI78PVMoCR0 glVASbPFVEihcZtthOpTpbcvLHCquE8N4OEI/iWnuKixt3kR7xP0GMWbnTdgPF5b+fDi J06g== X-Gm-Message-State: AOAM532Y7u/23NKjpgsQhCCGwdKPzciXJDWclTLGFIY3ERSv/7XqcoNT nElJfGc9W52G+5pEon7kb7A6nOYsCGJlq5HXOHBy9g== X-Google-Smtp-Source: ABdhPJxc3qlV1vDkvr6AKiJA6v8PIzxjnHjrC8AiVb4RHEO7WgoEnWmUihcs05hGWpDlchzD4tCKWKvEQhihhe0Ou5s= X-Received: by 2002:a05:6e02:d42:: with SMTP id h2mr17203540ilj.204.1612237882649; Mon, 01 Feb 2021 19:51:22 -0800 (PST) MIME-Version: 1.0 References: <1611913781-23460-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1611913781-23460-9-git-send-email-hsin-hsiung.wang@mediatek.com> <1cbf58f1-376c-fa93-98a2-53a41fa24273@gmail.com> In-Reply-To: <1cbf58f1-376c-fa93-98a2-53a41fa24273@gmail.com> From: Tzung-Bi Shih Date: Tue, 2 Feb 2021 11:51:11 +0800 Message-ID: Subject: Re: [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes To: Matthias Brugger X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_225127_606285_4BA4FA18 X-CRM114-Status: GOOD ( 15.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , Jiaxin Yu , Wen Su , srv_heupstream@mediatek.com, Fei Shao , Ran Bi , Sean Wang , Liam Girdwood , Rob Herring , Linux Kernel Mailing List , Project_Global_Chrome_Upstream_Group@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Mark Brown , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , Eddie Huang , Lee Jones , Yuchen Huang , Hsin-Hsiung Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 31, 2021 at 7:06 PM Matthias Brugger wrote: > On 29/01/2021 10:49, Hsin-Hsiung Wang wrote: > > + mt6359codec: mt6359codec { > > + }; > > I understand that the dmic-mode and mic-type-X depends on the actual board on > which it is used. In that case I think we should add mt6359codec node in the dts > instead of dtsi file. I'd advise to set these properties as well as otherwise we > get a (slightly misleading) warning in the driver. I feel it is better to include the node in dtsi to represent the whole MT6359 PMIC. We could either: - Set default values of these properties in the dtsi to avoid the warning message. - Or https://patchwork.kernel.org/project/alsa-devel/patch/20210202033557.1621029-1-tzungbi@google.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel