From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F31FC4707F for ; Thu, 27 May 2021 11:50:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01839613B5 for ; Thu, 27 May 2021 11:50:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01839613B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OD7SN+mfQmvpjW2kYjczBn1mhYKGmpAYmoSYfp/QVlE=; b=40ubI79gpGOB11 6Sq7zovnNWuWdV1t/7naTaPglS6Wphs2nsHJTrNCS4pWX7MaQ6DtndfwzNVuBSTDpccMWgJRz8CPH h5MPaVkkuQXfw/IqrmP00whXNx1oK6ePiOWAz7NzMvaNgBgRxfnp+VxxRYNLLN9ZLvShVE5016SvP o5H2pZT+IFuJqsCuDVmLnGzMb8/7Gcnb8Y1h8PwncP0W2kWt3GCu9+Lf+6l9cVLrhcYsqN5FRI2Ts ff1GDnftDSKzI9EWewuWXGIaJfa28Eh6KqzRzADi/UbCHO/TdAxmSQmsoiEHn4EBPfYx87fiS+P/W mWqliCY9bqbflz2+V+6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmEUQ-005QfT-St; Thu, 27 May 2021 11:47:51 +0000 Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmEUH-005Qba-JC for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 11:47:43 +0000 Received: by mail-yb1-xb2c.google.com with SMTP id e10so240083ybb.7 for ; Thu, 27 May 2021 04:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uAvn4qJmbR7pfsWrroZ0CpB4BVEbmomEKDPF3PtlO9Q=; b=Pgyvf5UZZlOlje+DRt5xMdDa/bInnZPl9vYw4fr6na3v2is5metZCFw0K+2sJh+u7H 0zdLzfCNEocGoW/fo2SdQ8WVXE8txJ2dXIUbLnQVxzqcKLVBoTkcpjADfeHWf/I9heK5 +PRZ8FT1cphqzk8/asfCdsaydQpZ03qWxikvGF9wNH6iwuIrGbb+yLhPDzlNtLlMFyC0 YJc/aFyXbBm3K1Y7mi4LxSyXyjFL0plD8cJsSnAb3CSciSzkfFOF6j2CDSeNPFHTsxt/ RJF3YI3489LlhC4lmgV2SQDYDGFrf06+uC37/8wKkDjFB8yYwKiMdJFJROmzOzAM5E3x c5qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uAvn4qJmbR7pfsWrroZ0CpB4BVEbmomEKDPF3PtlO9Q=; b=uY0dM1aRJfTwnAUeaKg+52w5MWU1RayooEYFJG78NGutdk2tond4AP0921LJHwY2gv OymZtVP/3fbqlfm4uYqVGPwAwkPCWSYS6f5HQRlx74DzvR7hN8v7tpkVb4hyIm7FTkcM 4JRnC1jZ+i5gd2Tr7Am/eV1XFfbcSljFNLfmkBMuo0eyJpMBb05aLmgDGpZsQ+uqldrA QLzSZewxoBkfSS2IPTguD03jlBudpP2fpbKv2d9+NtgOoGxmUJ143r910p5RRd3M3R8R Bm5M43WWZSVwUBHg/aBOow5o3Jgh7IieLLvaU+e8vijQ2FWS1au1JM7M39zdGgIEdu7i sNiw== X-Gm-Message-State: AOAM532wSpL+nZLkgFMTJnY+ACR0bpDkTVTFppOVvYW/zgj1Rn4ya6vq aSynjlWNhkg1LJ0lZJDAha6fNUf7TdrMQoUg2fg= X-Google-Smtp-Source: ABdhPJzSWw3v1y5zfVZV8NDGqJl70Whj+zfZ0W2Vfv6uxkL3uU2XbiCIe3bcX9FmGEF3G4ld8NmnTGJTmQN+HXKq7Ro= X-Received: by 2002:a25:8190:: with SMTP id p16mr3955667ybk.156.1622116060146; Thu, 27 May 2021 04:47:40 -0700 (PDT) MIME-Version: 1.0 References: <20210514192218.13022-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210514192218.13022-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 27 May 2021 12:47:14 +0100 Message-ID: Subject: Re: [PATCH 01/16] dt-bindings: arm: renesas: Document Renesas RZ/G2UL SoC To: Geert Uytterhoeven Cc: Lad Prabhakar , Rob Herring , Magnus Damm , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Philipp Zabel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , linux-clk , "open list:SERIAL DRIVERS" , Linux ARM , Biju Das X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_044741_714323_C228B42F X-CRM114-Status: GOOD ( 27.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, On Thu, May 27, 2021 at 12:29 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Fri, May 21, 2021 at 6:54 PM Lad, Prabhakar > wrote: > > On Fri, May 21, 2021 at 2:23 PM Geert Uytterhoeven wrote: > > > On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar > > > wrote: > > > > Add device tree bindings documentation for Renesas RZ/G2UL SoC. > > > > > > > > Signed-off-by: Lad Prabhakar > > > > Reviewed-by: Biju Das > > > > Reviewed-by: Chris Paterson > > > > > > Thanks for your patch! > > > > > > > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > > > > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > > > > @@ -302,6 +302,12 @@ properties: > > > > - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package) > > > > - const: renesas,r9a06g032 > > > > > > > > + - description: RZ/G2UL (R9A07G043) > > > > + items: > > > > + - enum: > > > > + - renesas,r9a07g043u11 # Single Cortex-A55 RZ/G2UL > > > > > > Is there any specific reason you're including the final "1", unlike the > > > RZ/G2{L,LC} binding? > > > > > To be consistent with the RZ/G2L family of SoC's "1" is appended to > > the compatible string. > My bad, the reason for adding 1 in the end was there are two variants of RZ/G2UL [1]. For the next respin I'll include renesas,r9a07g043u12 too. > No, for RZ/G2L you have: > > renesas,r9a07g044c1 for r9a07g044c12 > renesas,r9a07g044c2 for r9a07g044c22 > renesas,r9a07g044l1 for r9a07g044l13 and r9a07g044l14 > renesas,r9a07g044l2 for r9a07g044l23 and r9a07g044l24 > > i.e. the compatible value lacks the final digit. > > For RZ/G2UL, I do not know if we have to distinguish between > r9a07g043u11 and r9a07g043u12. > Some IP blocks are missing in type2 compared to type1. And at the higher level we might want to know the exact SoC type the board is built ? > > > As RZ/G2UL is always single-core, perhaps this compatible value can be > > > dropped? > > > > > Do agree with you. > > In light of the continued discussion for [PATCH 02/16], perhaps it's > good to keep it anyway? > Yes will keep the compatible string. [1] https://www.renesas.com/us/en/products/microcontrollers-microprocessors/rz-arm-based-high-end-32-64-bit-mpus/rzg2ul-general-purpose-microprocessors-single-core-arm-cortex-a55-10-ghz-cpu-2ch-giga-bit-ethernet Cheers, Prabhakar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel