From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA7A6C47076 for ; Fri, 21 May 2021 18:38:53 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3816B61163 for ; Fri, 21 May 2021 18:38:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3816B61163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Lg+CSjHIBQ2yuogRycXQZthjSBF3hz4w3kJR180rVMg=; b=omXRGWX3PBHZYKtMCXqAgAzTEZ ZZsCYMyvlnjYaNXIlsRTzBtgZda+XaynEHReKhk3tvF0DWxwgn4OctkawdMVGuI6c/DpnoThHwdO9 W1MA/CihV1Y16D4LrWVKI8uc0LS4K/ENWRc21O6ipdHud3wZUJa9qb+8Mb+x/XwF0MFs7QL+1R74h PSANy76vqQc802Z9CK0dbfNWEYC09wAYQczs658ecmodLhPbExwpkCT7/HD2HXR63VcYJkjaRiq2R hQppoGfTbxLuUqBSA1eBtHo0HOMRoLOGeMWjnFWqHMfNw9l/Q9mRZwsB/mHV3IosNyXao1N/5WlZS VMhfeGIw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkA1P-000kEK-Jw; Fri, 21 May 2021 18:37:19 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkA1L-000kDh-5R for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 18:37:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6q0ikK0Mie3JrQ+cMfG9/RKVJO02t8l8yLC5xdmKsBw=; b=3Qm8PMHGixRxhFMiWEVfy/a/mp NzdnNtYjyMb8ynKX7JzzSCed4kT9SklXaBc5iuz6jJl6MQA4x2i7FY5LxaHLb/SB/tR2XXfFn8M0L Uk1aSvOTxz9Z2dSYoEu2FE+bNvyS3tHiZ55u1PURUypwh/70xoXHHPZeYobtV4tkPmB8INBwc/sRg Rz+42hywq4RYNzW5ohTrMm6w5Pse0D/BDKB8976zqKtyZfRrHwtBxkXwm01jXGt4Kyj2na0UpWvmR gAm7S1aLOWJkpUSzDtXGgoDV/Fj8bvmhYVCi4GoDBio52lQH6M8tfFxrx60OctysW2MRMC7Tuz4QI uaE5ikvw==; Received: from mail-yb1-xb36.google.com ([2607:f8b0:4864:20::b36]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lkA1H-00HMHk-RT for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 18:37:13 +0000 Received: by mail-yb1-xb36.google.com with SMTP id y2so28711508ybq.13 for ; Fri, 21 May 2021 11:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6q0ikK0Mie3JrQ+cMfG9/RKVJO02t8l8yLC5xdmKsBw=; b=qve62GhX7V7MgWo9gLUyHND9hmpf6NVdUoWsUKMisatS+WdIRwQP8g34HhH8XDj5Bf /ErZWMzTVJp68znHsoxmAxbyO0+fEpOu+nDRqh/DHlx8ToRx3DlcHiW+zVBlJP/kYmK2 cPlSiWKiYkfOY0C1jxPTsTB0nj/eqKAgLugHE26T1iAl770p8an96tyvB0kMwVhoZeTP ZvvMqAxy9sKqqXrapuOdeBr9tpVgnqMxWnocbsafBvYEP3bSY4zjr/s5CvT99Tb7pn8K 1YHm6jlNvpDw4nkdUta6PqIeJUiu1Cu1n9UiqL7uIuYKWGrN+BACZjuydCBjCzaS7jEM 5Nbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6q0ikK0Mie3JrQ+cMfG9/RKVJO02t8l8yLC5xdmKsBw=; b=QQFcNjb26CsexJbXRuWGBY3xMV7SPx4VLTQULh7CqSmmj/+o8vzgTrSqWNU2yE7sbu RNG2O601u2946DMcsG0rvKIxKTwLTipUHEvl8jhngrnU74mtfk5jdtCkfEKALIGMUkgd B5C+sxukD+Gb9S23hAmL6ASbyn06EIx9ouBt+5Y+zXyOI+3uBtBgrn5UIT8UUbE68DwX K5LffMkRSfD19ZFHpBCDHbi0ycmjFmhDfeWEefymq/Xvhy2ASPMSThi+hAB5fcPwKcku Y9Y5szNABgNfJImTq9+lxEjeU7SoEn4+ZSoPocy2BJLNoR9nw01HfRnjCy4JJsyYkSa2 2OMw== X-Gm-Message-State: AOAM533AX4iyCOSI5NBLXr3eTug/4oUN2shSc8kdOkeiMfCsniPmtuxu A8zOgI/IeaPcZddMmXa8krLM+MUjZY54nzG1Vv4= X-Google-Smtp-Source: ABdhPJwiafq3UQhuczJqMYIiBK2lR02zSKjM4tO5dDN/6B3ZhjnMtO6d0k+6Mhq2E+1bu18LcAAUo17ZmZbtPBESD6c= X-Received: by 2002:a25:a26a:: with SMTP id b97mr17025060ybi.62.1621622227144; Fri, 21 May 2021 11:37:07 -0700 (PDT) MIME-Version: 1.0 References: <20210514192218.13022-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210514192218.13022-16-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Fri, 21 May 2021 19:36:41 +0100 Message-ID: Subject: Re: [PATCH 15/16] arm64: dts: renesas: Add initial DTSI for RZ/G2{L,LC} SoC's To: Geert Uytterhoeven Cc: Lad Prabhakar , Rob Herring , Magnus Damm , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Philipp Zabel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , linux-clk , "open list:SERIAL DRIVERS" , Linux ARM , Biju Das X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_113711_919965_D451FB0A X-CRM114-Status: GOOD ( 41.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, Thank you for the review. On Fri, May 21, 2021 at 4:35 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Fri, May 14, 2021 at 9:24 PM Lad Prabhakar > wrote: > > Add initial DTSI for RZ/G2{L,LC} SoC's. > > > > File structure: > > r9a07g044.dtsi => RZ/G2L family SoC common parts > > r9a07g044l.dtsi => Specific to RZ/G2L (R9A07G044L) SoC > > r9a07g044l1.dtsi => Specific to RZ/G2L (R9A07G044L single cortex A55) SoC > > r9a07g044l2.dtsi => Specific to RZ/G2L (R9A07G044L dual cortex A55) SoC > > > > Signed-off-by: Lad Prabhakar > > Signed-off-by: Biju Das > > Thanks for your patch! > > > index 000000000000..c625d302f889 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > > @@ -0,0 +1,70 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > Do we want to use > > SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > for new DTS files? > This actually also applies to files. > > > +/* > > + * Device Tree Source for the RZ/G2L and RZ/G2LC common SoC parts > > + * > > + * Copyright (C) 2021 Renesas Electronics Corp. > > + */ > > + > > +#include > > +#include > > + > > +/ { > > + compatible = "renesas,r9a07g044"; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + extal_clk: extal { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + /* This value must be overridden by the board */ > > + clock-frequency = <0>; > > + }; > > + > > + psci { > > + compatible = "arm,psci-1.0", "arm,psci-0.2"; > > + method = "smc"; > > + }; > > + > > + soc: soc { > > + compatible = "simple-bus"; > > + interrupt-parent = <&gic>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + scif0: serial@1004b800 { > > + compatible = "renesas,scif-r9a07g044"; > > + reg = <0 0x1004b800 0 0x400>; > > + interrupts = > > + , > > + , > > + , > > + , > > + ; > > "make dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/renesas,scif.yaml": > > arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dt.yaml: > serial@1004b800: interrupts: 'oneOf' conditional failed, one must be > fixed: > [[0, 380, 4], [0, 382, 4], [0, 383, 4], [0, 381, 4], [0, 384, 4]] > is too long > Additional items are not allowed ([0, 382, 4], [0, 383, 4], [0, > 381, 4], [0, 384, 4] were unexpected) > Additional items are not allowed ([0, 384, 4] was unexpected) > [[0, 380, 4], [0, 382, 4], [0, 383, 4], [0, 381, 4], [0, 384, 4]] > is too short > > One interrupt is missing. According to the documentation, "tei" and > "dri" share an interrupt, so they should map to the same interrupt number. > Please add interrupt-names. > Agreed will do. > > + clocks = <&cpg CPG_MOD R9A07G044_CLK_SCIF0>; > > + clock-names = "fck"; > > + power-domains = <&cpg>; > > + resets = <&cpg R9A07G044_CLK_SCIF0>; > > + status = "disabled"; > > + }; > > + > > + devid: chipid@11020a04 { > > + compatible = "renesas,devid"; > > + reg = <0 0x11020a04 0 4>; > > + }; > > + > > + gic: interrupt-controller@11900000 { > > + compatible = "arm,gic-v3"; > > + #interrupt-cells = <3>; > > + #address-cells = <0>; > > + interrupt-controller; > > + reg = <0x0 0x11900000 0 0x40000>, > > + <0x0 0x11940000 0 0x60000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD R9A07G044_CLK_GIC600>; > > + clock-names = "gic6000"; > > This looks like a weird name ;-) > In addition, it should be the consumer clock name, not the provider > clock name. > Agreed will rename that. > > + power-domains = <&cpg>; > > + resets = <&cpg R9A07G044_CLK_GIC600>; > > "make dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml": > > arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dt.yaml: > interrupt-controller@11900000: 'clock-names', 'clocks', > 'power-domains', 'resets' do not match any of the regexes: > '^(msi-controller|gic-its|interrupt-controller)@[0-9a-f]+$', > '^gic-its@', '^interrupt-controller@[0-9a-f]+$', 'pinctrl-[0-9]+' > > These properties should be added to the GIC-v3 bindings, cfr. the normal > GIC bindings. > Agreed will do that. > > > + }; > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/renesas/r9a07g044l.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044l.dtsi > > new file mode 100644 > > index 000000000000..8d396b9100c1 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/r9a07g044l.dtsi > > @@ -0,0 +1,21 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Device Tree Source for the RZ/G2L common SoC parts > > + * > > + * Copyright (C) 2021 Renesas Electronics Corp. > > + */ > > + > > +/dts-v1/; > > +#include "r9a07g044.dtsi" > > + > > +&soc { > > + cpg: clock-controller@11010000 { > > + compatible = "renesas,r9a07g044l-cpg"; > > + reg = <0 0x11010000 0 0x10000>; > > + clocks = <&extal_clk>; > > + clock-names = "extal"; > > + #clock-cells = <2>; > > + #reset-cells = <1>; > > + #power-domain-cells = <0>; > > + }; > > As I think this is shared by RZ/G2L and RZ/G2LC, it belongs to > r9a07g044.dtsi. > As some of the IP blocks present on RZ/G2L aren't present in RZ/G2LC the clocks for the IP will be missing hence this is added to SoC specific dtsi. > > +}; > > diff --git a/arch/arm64/boot/dts/renesas/r9a07g044l1.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044l1.dtsi > > new file mode 100644 > > index 000000000000..44d4504e44c3 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/r9a07g044l1.dtsi > > @@ -0,0 +1,43 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Device Tree Source for the RZ/G2L R9A07G044L1 common parts > > + * > > + * Copyright (C) 2021 Renesas Electronics Corp. > > + */ > > + > > +/dts-v1/; > > +#include "r9a07g044l.dtsi" > > + > > +/ { > > + compatible = "renesas,r9a07g044l1"; > > + #address-cells = <2>; > > + #size-cells = <2>; > > #{address,size}-cells already defined in r9a07g044.dtsi. > Will drop that. > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + a55_0: cpu@0 { > > + compatible = "arm,cortex-a55"; > > + reg = <0>; > > + device_type = "cpu"; > > + next-level-cache = <&L3_CA55>; > > + enable-method = "psci"; > > + }; > > + > > + L3_CA55: cache-controller-0 { > > + compatible = "cache"; > > + cache-unified; > > + cache-size = <0x40000>; > > + }; > > I think the first CPU core should be in the base r9a07g044.dtsi file. > OK will move that. > > + }; > > + > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts-extended = > > + <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>, > > + <&gic GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>, > > + <&gic GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>, > > + <&gic GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>; > > Also in the base file, with interrupts-extended overridden where > needed? > OK will override here with the timer node moved from r9a07g044l2.dtsi to common SoC file. > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/renesas/r9a07g044l2.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044l2.dtsi > > new file mode 100644 > > index 000000000000..33bb35e1c369 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/r9a07g044l2.dtsi > > @@ -0,0 +1,62 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Device Tree Source for the RZ/G2L R9A07G044L2 common parts > > + * > > + * Copyright (C) 2021 Renesas Electronics Corp. > > + */ > > + > > +/dts-v1/; > > +#include "r9a07g044l.dtsi" > > + > > +/ { > > + compatible = "renesas,r9a07g044l2"; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu-map { > > + cluster0 { > > + core0 { > > + cpu = <&a55_0>; > > + }; > > + core1 { > > + cpu = <&a55_1>; > > + }; > > + }; > > + }; > > + > > + a55_0: cpu@0 { > > + compatible = "arm,cortex-a55"; > > + reg = <0>; > > + device_type = "cpu"; > > + next-level-cache = <&L3_CA55>; > > + enable-method = "psci"; > > + }; > > + > > + a55_1: cpu@1 { > > + compatible = "arm,cortex-a55"; > > + reg = <0x100>; > > + device_type = "cpu"; > > + next-level-cache = <&L3_CA55>; > > + enable-method = "psci"; > > + }; > > + > > + L3_CA55: cache-controller-0 { > > + compatible = "cache"; > > + cache-unified; > > + cache-size = <0x40000>; > > + }; > > I think (at least) the first CPU core should be in the base > r9a07g044.dtsi file. > Probably the second CPU core should be in the base file, too, and > removed by /delete-node/ in r9a07g044l1.dtsi? > Agreed will do that. > > + }; > > + > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts-extended = > > + <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, > > + <&gic GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, > > + <&gic GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, > > + <&gic GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; > > + }; > > Also in the base file, with interrupts-extended overridden where > needed? > Will move this node to common SoC r9a07g044.dtsi file and override in r9a07g044l1.dtsi with CPU maks to 1. Cheers, Prabhakar > > +}; > > -- > > 2.17.1 > > > > > -- > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel