From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Ezequiel Garcia <ezequiel@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Magnus Damm <magnus.damm@gmail.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
NXP Linux Team <linux-imx@nxp.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Shawn Guo <shawnguo@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] media: dt-bindings: media: i2c: Switch to assigned-clock-rates
Date: Wed, 18 Mar 2020 20:13:00 +0000 [thread overview]
Message-ID: <CA+V-a8veXbwMrda8UEu2mN6gGgrBJA8Mp7gdN7Q3-iXNw9c4pg@mail.gmail.com> (raw)
In-Reply-To: <20200313212717.GO4751@pendragon.ideasonboard.com>
Hi Laurent,
On Fri, Mar 13, 2020 at 9:27 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Prabhakar,
>
> On Fri, Mar 13, 2020 at 09:25:01PM +0000, Prabhakar Mahadev Lad wrote:
> > On Sent: 13 March 2020 21:20, Laurent Pinchart wrote:
> > > On Fri, Mar 13, 2020 at 09:12:31PM +0000, Lad Prabhakar wrote:
> > > > Use assigned-clock-rates to specify the clock rate. Also mark
> > > > clock-frequency property as deprecated.
> > >
> > > I would phrase it the other way around, this patch mainly deprecates clock-
> > > frequency, and as a side effect recommends usage of assigned-clock-rates.
> > >
> > > "Deprecate usage of the clock-frequency propertly. The preferred method
> > > to set clock rates is to use assigned-clock-rates."
> >
> > Agreed will do that.
> >
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > ---
> > > > Documentation/devicetree/bindings/media/i2c/ov5645.txt | 5 +++--
> > > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> > > > b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> > > > index 72ad992..e62fe82 100644
> > > > --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> > > > +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> > > > @@ -8,7 +8,7 @@ Required Properties:
> > > > - compatible: Value should be "ovti,ov5645".
> > > > - clocks: Reference to the xclk clock.
> > > > - clock-names: Should be "xclk".
> > > > -- clock-frequency: Frequency of the xclk clock.
> > > > +- clock-frequency (deprecated): Frequency of the xclk clock.
> > >
> > > I would drop this completely. Drivers need to ensure backward compatibility,
> > > but DT bindings should only document the latest version, the history is
> > > available in git.
> > >
> > Sure will drop it.
> >
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > While at it, can I enlist you to convert these bindings to yaml ? :-)
> > >
> > Sure will do the honours , will make sure yaml patch is ontop of this patch too.
>
Shall I enlist you as the maintainer in the json-schema ?
dt_binding_check says 'maintainers' is a required property.
Cheers,
--Prabhakar Lad
> Thank you :-)
>
> > > > - enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This corresponds
> > > > to the hardware pin PWDNB which is physically active low.
> > > > - reset-gpios: Chip reset GPIO. Polarity is GPIO_ACTIVE_LOW. This corresponds to
> > > > @@ -37,7 +37,8 @@ Example:
> > > >
> > > > clocks = <&clks 200>;
> > > > clock-names = "xclk";
> > > > -clock-frequency = <24000000>;
> > > > +assigned-clocks = <&clks 200>;
> > > > +assigned-clock-rates = <24000000>;
> > > >
> > > > vdddo-supply = <&camera_dovdd_1v8>;
> > > > vdda-supply = <&camera_avdd_2v8>;
>
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-18 20:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 21:12 [PATCH v3 0/4] ov5645: Switch to assigned-clock-rates Lad Prabhakar
2020-03-13 21:12 ` [PATCH v3 1/4] media: dt-bindings: media: i2c: " Lad Prabhakar
2020-03-13 21:20 ` Laurent Pinchart
2020-03-13 21:25 ` Prabhakar Mahadev Lad
2020-03-13 21:27 ` Laurent Pinchart
2020-03-18 20:13 ` Lad, Prabhakar [this message]
2020-03-18 22:33 ` Laurent Pinchart
2020-03-18 22:37 ` Lad, Prabhakar
2020-03-19 12:44 ` Maxime Ripard
2020-03-19 13:03 ` Laurent Pinchart
2020-03-19 13:17 ` Lad, Prabhakar
2020-03-24 15:40 ` Maxime Ripard
2020-03-24 16:04 ` Lad, Prabhakar
2020-03-24 16:12 ` Laurent Pinchart
2020-03-25 21:52 ` Lad, Prabhakar
2020-03-19 13:05 ` Lad, Prabhakar
2020-03-13 21:12 ` [PATCH v3 2/4] media: i2c: ov5645: " Lad Prabhakar
2020-03-13 21:16 ` Laurent Pinchart
2020-03-13 21:19 ` Prabhakar Mahadev Lad
2020-03-13 21:12 ` [PATCH v3 3/4] media: i2c: ov5645: Set maximum leverage of external clock frequency to 24480000 Lad Prabhakar
2020-03-13 21:23 ` Laurent Pinchart
2020-03-13 21:31 ` Prabhakar Mahadev Lad
2020-03-18 22:41 ` Lad, Prabhakar
2020-03-18 23:22 ` Laurent Pinchart
2020-03-19 8:00 ` Lad, Prabhakar
2020-03-18 23:18 ` Laurent Pinchart
2020-03-19 7:59 ` Lad, Prabhakar
2020-03-13 21:12 ` [PATCH v3 4/4] ARM: dts: imx6qdl-wandboard: Switch to assigned-clock-rates for ov5645 node Lad Prabhakar
2020-03-13 21:25 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8veXbwMrda8UEu2mN6gGgrBJA8Mp7gdN7Q3-iXNw9c4pg@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).