From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0435C433E6 for ; Wed, 10 Mar 2021 21:27:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48EC264FA9 for ; Wed, 10 Mar 2021 21:27:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48EC264FA9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UeaPt3FKIW8I8IPgbQZlUqwy9mr2UcFauebgTDysydw=; b=myDPb0h971NxMd8UWquUokoEn xTZDyerIvJnJWQfihbsgJ1uBE6ca1qc33XMTJUd4qyh0ejf/eNGw8/i1FH/OuYRQhIJYJ1JSLIh2B VhQPcCM3l9FOIZg4LPIl7I2STUZO2PmhDR4t4kzZjw19qyhRma30/50Nv08ne645RfXDbX/uEyGQ3 bysHg4Z1TI0mH9Tw1Ln9/+Xe7GMOMvazBnAbDPNWA0M4WdyGrkMGJG2hLzVZ/jYl0qCjJ8rwfrMii oIB0/2qGObmS0Goc875YpEtetYY2DELQ+Pw4dmiOvBFjtLqtv70u8I3FxWMfwxvGAHjcuJLQIXTUw xrqL2CCkg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lK6KC-007nYd-AV; Wed, 10 Mar 2021 21:25:00 +0000 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lK6Jz-007nVm-Qz for linux-arm-kernel@lists.infradead.org; Wed, 10 Mar 2021 21:24:53 +0000 Received: by mail-il1-x12a.google.com with SMTP id d5so16981631iln.6 for ; Wed, 10 Mar 2021 13:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=x9/KVHsZmsTxm4DmBJPx7KZ95KUta5lJt2VQVkp5nXQ=; b=J4/FovK5/IFzdNwT6SDP+/56qzSzoZU8CGgsbbDExEStmADA5YhBfmx9a5ShnyP8H/ Za59jSREIff9LUTkgxgcfk8b4oXG+3mi5kK5xNL2j5bDyGHTPAlcqYk4FiksRBLD4Yem UJjDLJsn1Qm+0abv+DWcBDDdcdo3/wnDqWJlf7foX+49GrBh+mh2/hivz3c6utdUSFJK JHBxT3fR+QCot2AiBnugMs/swZsKyAiHeEUoSSBzq2BogDSmibF8LBCaYpc5PHkOJSqM kl0xV2W1/fdQIz6/KWU5Nd+2QqlF7C2CiI95u9qy7nWEtZF4wt/yRDBQ3N7vdoRB24G+ AveA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=x9/KVHsZmsTxm4DmBJPx7KZ95KUta5lJt2VQVkp5nXQ=; b=Ar6QFVDqTz7bdjjP8PItNF/b18uRQRVXlotGzuVw20pTAZzHyxhA6gNjrvbsl0t/dv 4WifxaEl8mVkW0Z6R6KaxrDLlBNn+LUd7FnOuchnImfzcCOfDwIdaxn98KkSDtBQ3uX2 oXQepq9a07KLr2Aa9X6HKWeNg8MwXfN6wxWVnOflXWBkf2HltgTdoZCocgIEqnfofVWI z1DrNlR7fKn6yPUfSMesSHLm6SEXiD1cAijYNgNG/nBaYiJ/4rF4gGrcY7DZWu2o5BTj n+jLtrUyHCdvpBtXcyiKUNUjUUz5OVGP2100dyOG9oEvwBEcOtFNUDnSIXnnXBx8abjb G+Gg== X-Gm-Message-State: AOAM532er7OD/yLk0kpejTAG8HuAxfJwuPhsIDGEjaddBS0zFGMS3YpE C8YS37WQPZGSGNYno7Z+hp5Rph/hpq5nhmflxCw= X-Google-Smtp-Source: ABdhPJy633aCpve8a5kvlspgo54swQ+mQuOfSQDMRzcn9Ieihnos1FFhWVmMsGMT0QazyTbNUiIaCRH5xVe7vaLLVB8= X-Received: by 2002:a92:c7c2:: with SMTP id g2mr4293277ilk.209.1615411484772; Wed, 10 Mar 2021 13:24:44 -0800 (PST) MIME-Version: 1.0 References: <20210225112122.2198845-1-arnd@kernel.org> <20210226211323.arkvjnr4hifxapqu@google.com> <1614559739.p25z5x88wl.astroid@bobo.none> In-Reply-To: From: Sedat Dilek Date: Wed, 10 Mar 2021 22:24:07 +0100 Message-ID: Subject: Re: [PATCH] [RFC] arm64: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION To: Arnd Bergmann Cc: Masahiro Yamada , Nicholas Piggin , Fangrui Song , Ard Biesheuvel , Andrew Scull , Mark Brown , Catalin Marinas , clang-built-linux , David Brazdil , Geert Uytterhoeven , Ionela Voinescu , Kees Cook , Kristina Martsenko , Linux ARM , "linux-kernel@vger.kernel.org" , Mark Rutland , Marc Zyngier , Nathan Chancellor , Nick Desaulniers , Vincenzo Frascino , Will Deacon , Nicolas Pitre X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_212448_486376_DCD79610 X-CRM114-Status: GOOD ( 24.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sedat.dilek@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 10, 2021 at 10:08 PM Arnd Bergmann wrote: > > On Wed, Mar 10, 2021 at 9:50 PM Masahiro Yamada wrote: > > On Mon, Mar 1, 2021 at 10:11 AM Nicholas Piggin wrote: > > > Excerpts from Arnd Bergmann's message of February 27, 2021 7:49 pm: > > > > > masahiro@oscar:~/ref/linux$ echo 'void this_func_is_unused(void) {}' > > >> kernel/cpu.c > > masahiro@oscar:~/ref/linux$ export > > CROSS_COMPILE=/home/masahiro/tools/powerpc-10.1.0/bin/powerpc-linux- > > masahiro@oscar:~/ref/linux$ make ARCH=powerpc defconfig > > masahiro@oscar:~/ref/linux$ ./scripts/config -e EXPERT > > masahiro@oscar:~/ref/linux$ ./scripts/config -e LD_DEAD_CODE_DATA_ELIMINATION > > masahiro@oscar:~/ref/linux$ > > ~/tools/powerpc-10.1.0/bin/powerpc-linux-nm -n vmlinux | grep > > this_func > > c000000000170560 T .this_func_is_unused > > c000000001d8d560 D this_func_is_unused > > masahiro@oscar:~/ref/linux$ grep DEAD_CODE_ .config > > CONFIG_HAVE_LD_DEAD_CODE_DATA_ELIMINATION=y > > CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y > > > > > > If I remember correctly, > > LD_DEAD_CODE_DATA_ELIMINATION dropped unused functions > > when I tried it last time. > > > > > > I also tried arm64 with a HAVE_LD_DEAD_CODE_DATA_ELIMINATION hack. > > The result was the same. > > > > > > > > Am I missing something? > > It's possible that it only works in combination with CLANG_LTO now > because something broke. I definitely saw a reduction in kernel > size when both options are enabled, but did not try a simple test > case like you did. > > Maybe some other reference gets created that prevents the function > from being garbage-collected unless that other option is removed > as well? > The best results on size-reduction of vmlinux I got with Clang-CFI on x86-64. Clang-LTO and Clang-CFI: I was able to build with CONFIG_TRIM_UNUSED_KSYMS=y which needs to add a whitelist file or add a whitelist to scripts/gen_autoksyms.sh. And boot on bare metal. Furthermore, I was able to compile CONFIG_HAVE_LD_DEAD_CODE_DATA_ELIMINATION=y with and without CONFIG_TRIM_UNUSED_KSYMS=y. Every kernel I had CONFIG_HAVE_LD_DEAD_CODE_DATA_ELIMINATION=y does not boot. Yes, there is a size reduction with both enabled but not that good as with Clang-CFI. All testings with several iterations of LLVM/Clang v13-git. With CONFIG_TRIM_UNUSED_KSYMS=y I see a 3x-loops of building .version and folowing steps - got no answer if this is intended. Means longer build-time. I did not follow this anymore as both Kconfigs with Clang-LTO consume more build-time and the resulting vmlinux is some MiB bigger than with Clang-CFI. If someone is interested in x86-64 I can provide the whitelist files and or (alternatively) changes to scripts/gen_autoksyms.sh. AFAICS I had open a thread for this - damn digital dementia. - Sedat - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel