From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9DA1C433B4 for ; Sat, 8 May 2021 11:17:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45F09601FD for ; Sat, 8 May 2021 11:17:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45F09601FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DWifOts4083fxpBNt1mAwrg4bUW81OhKGI7hqFBJetA=; b=HSfxcRj34SRB+gkk/53ainFIZ KZVphHcW/rtpp2Recs5aVZ0WgFSOQGOxG9POR2UdGDWuazIuLXeVhgIKOuNXYLipBce+Chn1b41fm xtDiCnFMo52BEp2BUJkk5fzRSL23a1y8yPn8idDzrHqWMo9cQMllkXBMZ8vi5eIfXBTOszrylmqy5 CKLDowNjsSSJ7sDIjr8r+emiNthCoqnTmBiZJ5kJxaMHiAzUfHTNJowqRUAmY9MLmlzbFsE/dJDTq Zf4NI00b1KVKpTsFX9Aw89/TgBMUgwGCGmiWBMXa3Yb2OYAsmL7uTCXkii206q3Yh82NX9DD6zcML cWsyN/l3w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfKvB-009P83-Nr; Sat, 08 May 2021 11:14:58 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfKv4-009P7j-0G for linux-arm-kernel@desiato.infradead.org; Sat, 08 May 2021 11:14:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pXbSQAyhG6W2ZQ5ums5vjGpNRe3vyzAhG3D2OB6FJtA=; b=hSwCMVdgz1YzBzDm7gXayjIokL h83J2YBx0ZmH9nWy6rvf2V1hiVqxMV21p67+zlrSyG/i7m5La+uICvn3tlgE8aGmmFerxtVBaeTDA V44eVQY0MdCgQgmSXPYGGD9cNk0moENJOqGqS4EsJLKfnvLKeb2jX+CbuWB1rcojWePUOnJXLSgVA HQ5q/q3LjUUG2H2VcdA93JHvUabdnav3/dPxhxz8jmRf8zhWLygSK40HZH38lc+n6vSA6dIIA2nlZ 5yedM5BW7bnKv89qHlsNhoP1O/eDkv4EXXgY0etxHguIPh6Nar8Jc2Qm7lHFfhEEnzfgGGd/1ULe0 VqPsFelw==; Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfKv0-007V21-J1 for linux-arm-kernel@lists.infradead.org; Sat, 08 May 2021 11:14:48 +0000 Received: by mail-qt1-x82e.google.com with SMTP id f8so4365492qth.6 for ; Sat, 08 May 2021 04:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pXbSQAyhG6W2ZQ5ums5vjGpNRe3vyzAhG3D2OB6FJtA=; b=MEaQk6XPhXourlRG1ktFxx9flPigPi5AhTwrHElyyTSb6GnddHT2NBqQzAk7pfHBGh bxeC3+pH57tIvA67Zb42zGAcZKXFca8aAOfP6/GgJwC3zsVMuMFVYGKdHUVUh9x9fxRz AuqV344d7kd4prNGA6D5wBzbTIUZfWhDs1A7RiMm+8zxj1b5bv6/VA94Lmp2cEaF8qvP brtOwOdEzI1+3uPAV2G4hmFqWHImm3SpA7dyouODAAP8Mjio6LclJl4ZGBtVrPq4Fi8p 0+/pQsi16Tp9y3Q1qRTOfWp4qnx2ADsyVbfSyZmqK613n4bOlpNGMAeYOsMaUVGML0CG kQOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pXbSQAyhG6W2ZQ5ums5vjGpNRe3vyzAhG3D2OB6FJtA=; b=MccN4PNhgbVwYAGBjFENlPLq+R8RF5MjgbrxDO2s/g8SU8JYM3wiK9QT296FRphYSH VynVBj9BUg9gldYB4Jt9ACmCjjUd3/bcqYyxctN+kXd7TWjyFq/Ud8sxxDZdpKdWUR6y rlcYqtqsSar0JvC8A89diqa2HacYwkSitYcATxebbriUhVkicJKSg1DN7cZuTm9n1eCb 5oBG76u6EVBU0oo6TSCf2kb3q2O5xSjAnA9EfPybewq9DtCnpaVeWKVUEUDzRuaeM2O+ SwUl8nzv7LDuHTyUSQuB5GjN2EUahEpS6bbLGCJOt2Z5HZO+6tTD3RTHZTst3tGEQHom 5o0g== X-Gm-Message-State: AOAM531dlm76nR9qqb5naZs+LuN7lqmTOCVVO7jtGJtBjCaY9NkovJYR eTnyyyvlnmCuAhMA2FhGZ8h2DC6xMWfonvy3o10= X-Google-Smtp-Source: ABdhPJyRCbYhCpRfDI8+hasLkF4yP7yMUxLuTdvAzoQoMJyQJahYYgoI6qqRk4w4Lw9Mgcet1WmcDyaHhNNKa/rS4Jc= X-Received: by 2002:ac8:47da:: with SMTP id d26mr13187735qtr.292.1620472484696; Sat, 08 May 2021 04:14:44 -0700 (PDT) MIME-Version: 1.0 References: <1619157107-3734-1-git-send-email-shengjiu.wang@nxp.com> <1619157107-3734-2-git-send-email-shengjiu.wang@nxp.com> <20210503170030.GA1987906@robh.at.kernel.org> In-Reply-To: <20210503170030.GA1987906@robh.at.kernel.org> From: Shengjiu Wang Date: Sat, 8 May 2021 19:14:33 +0800 Message-ID: Subject: Re: [PATCH 2/2] ASoC: dt-bindings: imx-akcodec: Add binding doc for akcodec machine driver To: Rob Herring Cc: Shengjiu Wang , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Shawn Guo , Sascha Hauer , linuxppc-dev , Takashi Iwai , Liam Girdwood , Nicolin Chen , Mark Brown , NXP Linux Team , Sascha Hauer , Fabio Estevam , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210508_041446_655242_B688466F X-CRM114-Status: GOOD ( 32.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi On Tue, May 4, 2021 at 1:01 AM Rob Herring wrote: > > On Fri, Apr 23, 2021 at 01:51:47PM +0800, Shengjiu Wang wrote: > > Imx-akcodec is a new added machine driver for supporting > > ak4458/ak5558/ak5552/ak4497 codec on i.MX platforms. > > > > Signed-off-by: Shengjiu Wang > > --- > > .../bindings/sound/imx-audio-akcodec.yaml | 60 +++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > new file mode 100644 > > index 000000000000..7419bf7224e9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > @@ -0,0 +1,60 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/imx-audio-akcodec.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP i.MX audio complex with AK4458/AK5558/AK5552/AK4497 codec > > Looks like the existing fsl-asoc-card.txt? You should convert to schema > and use that. Otherwise, my comments are based on this all being 'new'. Ok, let's treat it as 'new' > > > + > > +maintainers: > > + - Shengjiu Wang > > + > > +properties: > > + compatible: > > + enum: > > + - fsl,imx8mq-audio-ak4458 > > + - fsl,imx8mq-audio-ak4497 > > + - fsl,imx8mq-audio-ak5558 > > + - fsl,imx-audio-ak4497 > > + - fsl,imx-audio-ak4458 > > + - fsl,imx-audio-ak5558 > > + - fsl,imx-audio-ak5552 > > I continue to not understand why audio bindings need the codec(s) in the > compatible strings. Can't you look up the codec thru the audio-codec > property? I will try to remove the codecs type from the compatible string and check the codec type in driver. > > > + > > + model: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: User specified audio sound card name > > + > > + audio-cpu: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of a CPU DAI controller > > + > > + audio-codec: > > + description: The phandle of Codec DAI controllers, there are two > > + controllers maximum. > > We have the common 'sound-dai' property. See the simple-card.yaml > binding. ok, will use sound-dai. > > > + > > + audio-asrc: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of ASRC. It can be absent if there's no > > + need to add ASRC support via DPCM. > > Needs a vendor prefix. ok, can be removed in the next version. > > > + > > + fsl,tdm: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: | > > + This is a boolean property. If present, the TDM mode is enabled. > > But this one seems like something that could or should be common. Ok, I will use the common one in the next version. > > > + > > +required: > > + - compatible > > + - model > > + - audio-cpu > > + - audio-codec > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + sound-ak4458 { > > + compatible = "fsl,imx-audio-ak4458"; > > + model = "ak4458-audio"; > > + audio-cpu = <&sai1>; > > + audio-codec = <&ak4458_1>, <&ak4458_2>; > > + }; > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel