From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99917C433DF for ; Wed, 29 Jul 2020 08:20:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65BD92076E for ; Wed, 29 Jul 2020 08:20:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uDHWdTIY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FBCR2aA2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65BD92076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yxktRqYy/fRqw6MyCd4ZQKd/vFKUC6HqF9ahvi94GGs=; b=uDHWdTIYIp9E53lyNjQePIfKv tltuw3wXWr6EK83LnvCVrizuuMKEFQHC8oAUhIXzBVj1eOrYPPnWwhIaNMcYtmN/T08MVH8Ss9YFH UWgr602ALKuRUXVtWtNKU3yP9QFE0U74V5PeTHW8QtX0d+liFFkbKjuNf/7NjKWgODTdIuzu5IQ8z 8lRcjJ3ngvx8Jib6s/zQaOzW/BuXb3EAqRp7acP9vXpKcTkfNucX6YCZvqeNURwJYbMAOPchjGQNK 6LsTXnMYGUg/V4FGUOojrjmmztqvKEKe4x9T7FtxsqHh68f+pm0wQX5CqcWCqx3a54sIsL0mA4cjR Rd3BjcIWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0hIS-0003a5-St; Wed, 29 Jul 2020 08:18:44 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0hIR-0003ZW-5T for linux-arm-kernel@lists.infradead.org; Wed, 29 Jul 2020 08:18:44 +0000 Received: by mail-ed1-x544.google.com with SMTP id i26so13442072edv.4 for ; Wed, 29 Jul 2020 01:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xvxyjwl1Zq8e84u08zFLgcKDZLY0RcVfXlHy+Lt6fac=; b=FBCR2aA2bQ121FWaRdsh3p/p0OjGMqxeMBSzfGUgQfIfWo+5s2Hqz8IGL8Wau9joZV hleUEaWAr1MBJgFHmQrvaxdcubILzxve7ZJunTYiBpIOfRNoHYvaO2yudmaedj0TFoZF X24C5pmOVEJ9KjB2g1W2v1fh/ENk1sjIGJ4L3VbFKy/DovFf6xqocUr/xqgQELIkwBxp s4qSgvKw32zI5j22YDpGvgrZS3wyK4zLAzpglUn9b4v0h0XyePrO/tCpxxcyPKCL5Jk7 MDC03vdoqKsZM0HFNJkESJTo7BT62XNUEy2vcjFu9Sz8xTyzBTtE7GkD+c7FKBorh/Fs WONg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xvxyjwl1Zq8e84u08zFLgcKDZLY0RcVfXlHy+Lt6fac=; b=ra7uY2ka/zlZhHwRAmhL7+/vjnQUfYXcDNIMEFJcaTNNXwdsaXZuw217GNBZg49U8D AitLWKO0PbjXCWKl4/xaJ6F6QzrpS83Qm0lptfDlHN7PwRFnJHLUYxj6IoZf3hQNIef7 C43frYFxNcD4al3DjtKB3X8ixx8ji2ltV3DLdmqBHLzLUr4ayOEDcZ7wm8bJ5duvW+Mm eNs+PECf2tV1emiarv+5OSAPc6pMvGzCOxTJtSWv7JbjmZdDeQZo4c5fV3QX+J9yv6Hj uyKsQzD1X4O1UT9l3SNYoclmaWSfPCwy8clbF75gHZyF8pX3OYWwXgPF+jTOlFTtojbx pwIg== X-Gm-Message-State: AOAM53339PwNmOL9yQ8wi7OFtTLq1HVWoyDaDUWSkGQkxaVfEcOSVrXH 6ACD5T16FfiuU5vl6gc7+EqUu6DB7gZECC2DEdg= X-Google-Smtp-Source: ABdhPJxZMfTNUeXJM0SGigzKriD+NN0szyTWSBDvTFsNGDD5qgu7eT/mxUlG43ZDj6yQXbHrwWQybPWqhnERoynnUF0= X-Received: by 2002:a05:6402:1803:: with SMTP id g3mr28708635edy.377.1596010718092; Wed, 29 Jul 2020 01:18:38 -0700 (PDT) MIME-Version: 1.0 References: <1596009618-25516-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1596009618-25516-1-git-send-email-aisheng.dong@nxp.com> From: Dong Aisheng Date: Wed, 29 Jul 2020 16:04:11 +0800 Message-ID: Subject: Re: [PATCH v7 00/11] clk: imx8: add new clock binding for better pm support To: Dong Aisheng X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200729_041843_235871_050343A1 X-CRM114-Status: GOOD ( 27.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , dl-linux-imx , Sascha Hauer , Fabio Estevam , Shawn Guo , linux-clk , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stephen, This patchset addressed all your new comments. Right now only Patch 2/3 still haven't got any R-b or A-b tags. So still need your help to review. All other patches already got the R-b tags. BTW, for [PATCH v7 02/11] dt-bindings: clock: imx-lpcg: add support to parse clocks from device tree. It was reviewed by Rob/Shawn and you before, however, due to the legacy binding file has been removed and changed to json format. So this patch also updated to json format accordingly based on the former reviewed patch and need a re-review. Regards Aisheng On Wed, Jul 29, 2020 at 4:04 PM Dong Aisheng wrote: > > This patch series is a preparation for the MX8 Architecture improvement. > As for IMX SCU based platforms like MX8QM and MX8QXP, they are comprised > of a couple of SS(Subsystems) while most of them within the same SS > can be shared. e.g. Clocks, Devices and etc. > > However, current clock binding is using SW IDs for device tree to use > which can cause troubles in writing the common -ss-xx.dtsi file for > different SoCs. > > This patch series aims to introduce a new binding which is more close to > hardware and platform independent and can makes us write a more general > drivers for different SCU based SoCs. > > Another important thing is that on MX8, each Clock resource is associated > with a power domain. So we have to attach that clock device to the power > domain in order to make it work properly. Further more, the clock state > will be lost when its power domain is completely off during suspend/resume, > so we also introduce the clock state save&restore mechanism. > > It's based on latest shanw/for-next branch. > > The top commit is: > 3c1a41dab7b8 Merge branch 'imx/defconfig' into for-next > > ChangeLog: > v6->v7: > * addressed all comments from Stephen > * rebased to latest shawn/for-next > v5->v6: > * add scu clk unregister if add provider failed > v4->v5: > * Address all comments from Stephen > v3->v4: > * use clk-indices for LPCG to fetch each clks offset from dt > v2->v3: > * change scu clk into two cells binding > * add clk pm patches to ease the understand of the changes > v1->v2: > * SCU clock changed to one cell clock binding inspired by arm,scpi.txt > Documentation/devicetree/bindings/arm/arm,scpi.txt > * Add required power domain property > * Dropped PATCH 3&4 first, will send the updated version accordingly > after the binding is finally determined, > > Dong Aisheng (11): > dt-bindings: firmware: imx-scu: new binding to parse clocks from > device tree > dt-bindings: clock: imx-lpcg: add support to parse clocks from device > tree > clk: imx: scu: add two cells binding support > clk: imx: scu: bypass cpu power domains > clk: imx: scu: allow scu clk to take device pointer > clk: imx: scu: add runtime pm support > clk: imx: scu: add suspend/resume support > clk: imx: imx8qxp-lpcg: add parsing clocks from device tree > clk: imx: lpcg: allow lpcg clk to take device pointer > clk: imx: clk-imx8qxp-lpcg: add runtime pm support > clk: imx: lpcg: add suspend/resume support > > .../bindings/arm/freescale/fsl,scu.txt | 12 +- > .../bindings/clock/imx8qxp-lpcg.yaml | 79 ++++-- > drivers/clk/imx/clk-imx8qxp-lpcg.c | 139 +++++++++++ > drivers/clk/imx/clk-imx8qxp.c | 136 +++++----- > drivers/clk/imx/clk-lpcg-scu.c | 53 +++- > drivers/clk/imx/clk-scu.c | 234 +++++++++++++++++- > drivers/clk/imx/clk-scu.h | 56 ++++- > include/dt-bindings/clock/imx8-lpcg.h | 14 ++ > 8 files changed, 620 insertions(+), 103 deletions(-) > create mode 100644 include/dt-bindings/clock/imx8-lpcg.h > > -- > 2.23.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel