From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F07B1C07E9A for ; Wed, 14 Jul 2021 10:24:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3E5F61363 for ; Wed, 14 Jul 2021 10:24:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3E5F61363 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UAyNLW7zJCLIGSekWkvexPiieM5HzVX4vyu9YVs+sgY=; b=i3UJKtju6spBhs Or0zejyF+d2vqxbdi26wgtHCkmiOoJiH8qa/Nx9G3DR1DXzbftZZcoBBCo92EmUBMokhvz7dNBqI+ vEmXTP6/GPJArHUwNl25W+5Wu018F7IQXEC8bAjDznGsCSY1pmFgQQ4NFRbWE0Rbb8Zr6k5qbXDKn WHwl/xkf52AkL4kMNkpa1QMl3h6GNd8o7mDcYN/z2KK71V7JlZV5Cs+hn0hQAkMIoLsqZa44UIIiT 12vRGBshJ5O1Ugt/9cas8O9jU5JfaCXo9cwoaQtwRP1NVgwuoWSojOT1K6efAZEqz5GD67cgpTkaE sd88a4UDg548YKwoHB0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3c2s-00D7G7-Bk; Wed, 14 Jul 2021 10:23:14 +0000 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3c2j-00D7F8-U8 for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 10:23:12 +0000 Received: by mail-oi1-x230.google.com with SMTP id l26so1710607oic.7 for ; Wed, 14 Jul 2021 03:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5nhr8B0n0RJGETsMiDfrGu6uX0+jGDPR9/ExJgu53y4=; b=Sf8uihogrC75HgQHqsvXQsonGBlCv/tXwN7fVcXbpxL/ZsetpS4CMr29/U7GDlUbN1 wwz8EHI8nDQ+iDXbm9YF1Ig1GF4riNbxemavcNZlfOxHSRwT/gHV3MXB5iEc8F4GduLQ sbw0Pqrg6khIWmmVhOcpEdgEznZ1PsE5vF51uoROyWTqq3LqU65Dgzh8S910Hj2Sqm4J 51ynKkIgMohES2YLAlrZT69TX06QpGba67o/3sEzKHbSdpbqw8xLsBDXauD6bJmdzHib x2Qa3cJvldfBE+ysY4x7rvHZUvK4ydmgvECqjx8KIkaaCHu7TmhjHwdmlWEpBdv3F/D9 h/NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5nhr8B0n0RJGETsMiDfrGu6uX0+jGDPR9/ExJgu53y4=; b=AdrOBnJIw8MqLcVJJVlQ9YrExXfeF4DAdD0WkykYBZHghOFuoRUFj2adP7RkDRdrI1 prJmmKgaw1ssuzFqkm06z1wYXXz4BvXA5tEDJFXxmq8qApIa9yPdDbnXcBnwLZ2fnH/n YV8LYLlOWBNkLUWh6nw8bRzjzOZzVT+ic9HA6Y3TPRlZN0+iP90H79byfa3NiN5CU29e YJ65UsSQyv7C2yz2RB2qbR2ESNT9mOhJxha6B5NDtqMu5bkcO670hV++z+m01OIyV9R/ jskk/p/DWVIYf6grw9FKCGs5xdUJ80RZD4D7T3arduXWl4rbOMcMu9ll1R/aqL/aszJN or1A== X-Gm-Message-State: AOAM532hD55ud+hJOmTALsMB88/elpMuGZ+xh4JMwkC4XW/vjLBifo2F RKJu/auAUznF+nocHSzIPUBo8HQ7gomy0EQkF18= X-Google-Smtp-Source: ABdhPJzraJn5LUt25CrK6LSqeATY94HhjXYPgMVCP/fOOsvRlLeIMv3k9hA0lpEfK/TPME0lCJKNguomF5hAbrVya0E= X-Received: by 2002:aca:d64d:: with SMTP id n74mr2337174oig.47.1626258184545; Wed, 14 Jul 2021 03:23:04 -0700 (PDT) MIME-Version: 1.0 References: <20210707094033.1959752-1-aisheng.dong@nxp.com> <20210707094033.1959752-5-aisheng.dong@nxp.com> <20210713170638.GA1816225@p14s> In-Reply-To: From: Dong Aisheng Date: Wed, 14 Jul 2021 18:21:04 +0800 Message-ID: Subject: Re: [PATCH V2 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram To: Peng Fan Cc: Mathieu Poirier , Aisheng Dong , "linux-remoteproc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "ohad@wizery.com" , "bjorn.andersson@linaro.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_032306_034714_7C616061 X-CRM114-Status: GOOD ( 33.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 14, 2021 at 8:59 AM Peng Fan wrote: > > Hi Mathieu, > > > Subject: Re: [PATCH V2 5/5] remoteproc: imx_rproc: change to ioremap_wc > > for dram > > > > On Wed, Jul 07, 2021 at 05:40:33PM +0800, Dong Aisheng wrote: > > > DRAM is not io memory, so changed to ioremap_wc. This is also aligned > > > with core io accessories. e.g. memcpy/memset and cpu direct access. > > > > > > Cc: Bjorn Andersson > > > Cc: Mathieu Poirier > > > Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores > > > booted before Linux Kernel") > > > Reviewed-by: Peng Fan > > > Signed-off-by: Dong Aisheng > > > --- > > > v1->v2: > > > * new patch > > > > It's a new patch and yet Peng's RB tag is already on it... > > Aisheng's reply in the other email. > " > Above two lines were added by mistake. (copied from patch 4) > I'm going to wait for review comments first and resend with changes if any. > > Regards > Aisheng > " > > > > > > --- > > > drivers/remoteproc/imx_rproc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080 > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc > > *priv, > > > break; > > > > > > /* Not use resource version, because we might share region */ > > > - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, > > resource_size(&res)); > > > + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, > > res.start, > > > +resource_size(&res)); > > > > How was it working before? > > we took all memory used by M-core as io memory, including TCM/SRAM/DRAM. > > Will it really work for all platforms and was this > > extensively tested? > > Aisheng may confirm, I not test this patchset. > > > > > Peng - I will need an explicit reply from you that you are in agreement with > > this change. > > I not test, but it should work per my understanding. > i.MX TCM area has limitation that not use ioremap_wc, DRAM has no such > limitation. Just think this not deserve a fix tag. > I tested with MX8MQ, i could find more to test although it should work theoretically. Why adding fixes tag is because using normal memory accessories (e.g. memset) for io memory (device type) may have issues. Does it make sense? Regards Aisheng > > I will also need you to review patch 01 and 02 of this set. > > Sure, I'll review. > > Thanks, > Peng. > > > > > Thanks, > > Mathieu > > > > > if (!priv->mem[b].cpu_addr) { > > > dev_err(dev, "failed to remap %pr\n", &res); > > > return -ENOMEM; > > > -- > > > 2.25.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel