From: Dong Aisheng <dongas86@gmail.com>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-remoteproc@vger.kernel.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram
Date: Thu, 8 Jul 2021 16:12:14 +0800 [thread overview]
Message-ID: <CAA+hA=So0nWDw8KFS=MjnfjfpsByLkwiFh98w2gbyMDDHx_A6A@mail.gmail.com> (raw)
In-Reply-To: <20210707094033.1959752-5-aisheng.dong@nxp.com>
On Wed, Jul 7, 2021 at 5:41 PM Dong Aisheng <aisheng.dong@nxp.com> wrote:
>
> DRAM is not io memory, so changed to ioremap_wc. This is also
> aligned with core io accessories. e.g. memcpy/memset and cpu direct
> access.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
[...]
> Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores booted before Linux Kernel")
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Above two lines were added by mistake. (copied from patch 4)
I'm going to wait for review comments first and resend with changes if any.
Regards
Aisheng
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> v1->v2:
> * new patch
> ---
> drivers/remoteproc/imx_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index ff620688fad9..4ae416ba5080 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
> break;
>
> /* Not use resource version, because we might share region */
> - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res));
> + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, res.start, resource_size(&res));
> if (!priv->mem[b].cpu_addr) {
> dev_err(dev, "failed to remap %pr\n", &res);
> return -ENOMEM;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-08 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 9:40 [PATCH V2 1/5] remoteproc: fix the wrong default value of is_iomem Dong Aisheng
2021-07-07 9:40 ` [PATCH V2 2/5] remoteproc: imx_rproc: fix TCM io memory type Dong Aisheng
2021-07-14 1:12 ` Peng Fan
2021-07-14 10:25 ` Dong Aisheng
2021-07-07 9:40 ` [PATCH V2 3/5] remoteproc: imx_rproc: fix ignoring mapping vdev regions Dong Aisheng
2021-07-07 9:40 ` [PATCH V2 4/5] remoteproc: imx_rproc: fix rsc-table name Dong Aisheng
2021-07-07 9:40 ` [PATCH V2 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram Dong Aisheng
2021-07-08 8:12 ` Dong Aisheng [this message]
2021-07-13 17:06 ` Mathieu Poirier
2021-07-14 0:59 ` Peng Fan
2021-07-14 10:21 ` Dong Aisheng
2021-07-14 10:15 ` Dong Aisheng
2021-07-14 1:01 ` [PATCH V2 1/5] remoteproc: fix the wrong default value of is_iomem Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA+hA=So0nWDw8KFS=MjnfjfpsByLkwiFh98w2gbyMDDHx_A6A@mail.gmail.com' \
--to=dongas86@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).