From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA2A9C433DF for ; Tue, 30 Jun 2020 14:21:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83A1420672 for ; Tue, 30 Jun 2020 14:21:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EuUc8cpd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fbb+OAM/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83A1420672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fnu2ohSJyJ0h923hp3vj48vy5WrnIu7YQCvu/zxelKM=; b=EuUc8cpdr5dzsTLW4dVQqMu/7 VJBERoZuqmYnZjVkEkMaQh47UHSuQ0VB/vesMcGJANnD2qfRK6Q1EhyhhuBDVkXLcqzfkTmaJ3h/G 3eHf5cO1tffkp5IlhtGD5ofT+H8rrg8RbhwJ9nqPMiWgPT0WuM/YCqt43hqfWbWQRhHkcWXakNfIz eh47EhQ54sif2SeJ+o1CgfZgydbt5oZe6HnXm1a0js9j75diJon3fRlJIX35fIp9JvZvBahuqQgcl xA+aUq0GJ9cjTRHtlCC19IoZXCRsBKIdfVjvREpRVcMVtuWEUHSJYtzWsIMF97XxZRhAOXPAWFnXS tsbSEwETQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqH7U-0002By-HS; Tue, 30 Jun 2020 14:20:20 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqH7R-0002Az-1u for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 14:20:18 +0000 Received: by mail-ed1-x541.google.com with SMTP id z17so16407898edr.9 for ; Tue, 30 Jun 2020 07:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K7kro9hNrZw4yDhFcFBRDmY6tQ/XNr6sZDxWZvaTmI4=; b=fbb+OAM/VHLXp9op4ixkqVNNxAQ+AO+wFy6+opDXTqYBpCyfnzhufpwAHCNZvaj8kg DJ+6uWN0mKRJ7bqj+Iv1hbIadPkNcXf/a7lA0O6qm5p1gS9JwHijs7FGKG/tUF1c/eG8 7/dTNgZH+T8g7F1BjSSVshO7eeBQASWyG+Vd8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K7kro9hNrZw4yDhFcFBRDmY6tQ/XNr6sZDxWZvaTmI4=; b=WZQkevEJbvTqR27SRJPC0WTzF7qSrkRsKBXyM3KojOwZeqzLRKpAifzhrpHG7fRFwT prm8FM16ldjErsJ7Dl+IsqRb0KeN85JhqFHlIIOFGIFrsjgX6DHnMP9uufyvVBX8M2kh 2QQqKs9+vk4k7abmkGJ9toLt4sFag8ADxl+Q38rA6uRoFP46WMIZ6tlp2kcLr9AXWcn3 pVheeCZ06Vn6xGz2b8ASt3J+9wvbFK0QZOpgbrQ8jOSNKLCz41L7Uc/50DIxa2PwFjUp gKIf/Eowe5f7IszOHH0E1HJTelNbxTcaGre6rKhaiNfu/dpptPtwP6ky2oNi0Qn0lcct +dIQ== X-Gm-Message-State: AOAM533uOMpShwtmoqydKFR9xguUhHg0wdtMa+6//SeNySUIIN/gQVD5 JHsnv+Yo/f3UmrYUbUkUzGgp2a1zf4Y= X-Google-Smtp-Source: ABdhPJwB2veANo8A79KHyOOjPwH0pT0oEPFxrRuJc+Mx3hgb7X7zgGQeGoJGtBDg3I2RkxT5BSjkYg== X-Received: by 2002:a05:6402:c06:: with SMTP id co6mr23712536edb.142.1593526814192; Tue, 30 Jun 2020 07:20:14 -0700 (PDT) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com. [209.85.128.44]) by smtp.gmail.com with ESMTPSA id q21sm2141667ejd.30.2020.06.30.07.20.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2020 07:20:12 -0700 (PDT) Received: by mail-wm1-f44.google.com with SMTP id o2so19787753wmh.2 for ; Tue, 30 Jun 2020 07:20:11 -0700 (PDT) X-Received: by 2002:a7b:c2a9:: with SMTP id c9mr22251088wmk.11.1593526811079; Tue, 30 Jun 2020 07:20:11 -0700 (PDT) MIME-Version: 1.0 References: <20200630024942.20891-1-dongchun.zhu@mediatek.com> <20200630024942.20891-3-dongchun.zhu@mediatek.com> <20200630095430.GF16711@paasikivi.fi.intel.com> In-Reply-To: <20200630095430.GF16711@paasikivi.fi.intel.com> From: Tomasz Figa Date: Tue, 30 Jun 2020 16:19:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V11 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver To: Sakari Ailus X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , =?UTF-8?B?U2hlbmduYW4gV2FuZyAo546L5Zyj55S3KQ==?= , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Dongchun Zhu , Louis Kuo , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 30, 2020 at 11:54 AM Sakari Ailus wrote: > > Hi Dongchun, > > Thanks for the update. > > On Tue, Jun 30, 2020 at 10:49:42AM +0800, Dongchun Zhu wrote: > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > Signed-off-by: Dongchun Zhu > > --- > > MAINTAINERS | 1 + > > drivers/media/i2c/Kconfig | 13 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/ov02a10.c | 1052 +++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 1067 insertions(+) > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 378c961..a6a2f8b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -12566,6 +12566,7 @@ L: linux-media@vger.kernel.org > > S: Maintained > > T: git git://linuxtv.org/media_tree.git > > F: Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > +F: drivers/media/i2c/ov02a10.c > > > > OMNIVISION OV13858 SENSOR DRIVER > > M: Sakari Ailus > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index da11036..65519cf 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -812,6 +812,19 @@ config VIDEO_IMX355 > > To compile this driver as a module, choose M here: the > > module will be called imx355. > > > > +config VIDEO_OV02A10 > > + tristate "OmniVision OV02A10 sensor support" > > + depends on I2C && VIDEO_V4L2 > > + select MEDIA_CONTROLLER > > + select VIDEO_V4L2_SUBDEV_API > > + select V4L2_FWNODE > > + help > > + This is a Video4Linux2 sensor driver for the OmniVision > > + OV02A10 camera. > > + > > + To compile this driver as a module, choose M here: the > > + module will be called ov02a10. > > + > > config VIDEO_OV2640 > > tristate "OmniVision OV2640 sensor support" > > depends on VIDEO_V4L2 && I2C > > diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile > > index 993acab..384e676 100644 > > --- a/drivers/media/i2c/Makefile > > +++ b/drivers/media/i2c/Makefile > > @@ -63,6 +63,7 @@ obj-$(CONFIG_VIDEO_VP27SMPX) += vp27smpx.o > > obj-$(CONFIG_VIDEO_SONY_BTF_MPX) += sony-btf-mpx.o > > obj-$(CONFIG_VIDEO_UPD64031A) += upd64031a.o > > obj-$(CONFIG_VIDEO_UPD64083) += upd64083.o > > +obj-$(CONFIG_VIDEO_OV02A10) += ov02a10.o > > obj-$(CONFIG_VIDEO_OV2640) += ov2640.o > > obj-$(CONFIG_VIDEO_OV2680) += ov2680.o > > obj-$(CONFIG_VIDEO_OV2685) += ov2685.o > > diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c > > new file mode 100644 > > index 0000000..f7fd329 > > --- /dev/null > > +++ b/drivers/media/i2c/ov02a10.c > > ... > > > + ov02a10->rst_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); > > > Shouldn't this be GPIOD_OUT_HIGH? That's the state it'll be after powering > the sensor off the first time. Alternatively make reset signal high in > runtime suspend callback. We might want to keep the signals low when the regulators are powered down, to reduce the leakage. Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel