From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF59BC4321A for ; Tue, 11 Jun 2019 10:13:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8701D2089E for ; Tue, 11 Jun 2019 10:13:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G0mYt2Xn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hMSEhr1I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8701D2089E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mNfKT5oSOypJbIRAZwNVQZoayY86uNtDhZyiflS/xa8=; b=G0mYt2XnwjyyBK 4ALxTcEHwikgK02qJ5VLePKNLr8jvd2ewTiiTRtq50BhOvPOkEGN62fx4F6xsimxgzeyRWscQrAfo PaZnyN6wmnQYBqtpdBSFUw38QITxl0awxNUVrRpyIhfVuVulFE4QtAPGVNOD1oDYPeF1F8wlGH/9/ 9LLwS3JMQCaQt1ji3Guq5iHbttxjyszwwgibGYAzl0ZD223iauZvUVFwowiiRGiq/ooiZJCqCSJBh xCRswO+J/YX/N1gvZiASqwbQ/zxfEM1b9yzwzSPS0/uCftX2upBLIKbVFukYzaoSwHUJ7HSDxMuEu Zb90to5hRl6tEnM6d1Iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hadmP-0007bD-7D; Tue, 11 Jun 2019 10:13:25 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hadmM-0007ae-7G for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2019 10:13:23 +0000 Received: by mail-ed1-x542.google.com with SMTP id k8so19189484edr.11 for ; Tue, 11 Jun 2019 03:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X0C5tQts1L+LXt2Q6k9c6ouRJcr990w6/a3NoyIORNQ=; b=hMSEhr1Ibx3hCZ1fwXTjoT0WNF47kP/wJklo2hoCJz1xUYosHQcyhZduBi4ldMd4u5 E1DFtj7cgLW/CRLILv3exZPt3kEXlkD3pLqVUz+QF2sMXilMvWtC3DtptVfHdjGIuxi2 y8sVqaA5Phb46+tnfHdR/Z1k05JiQ36ou7x8Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X0C5tQts1L+LXt2Q6k9c6ouRJcr990w6/a3NoyIORNQ=; b=YLAfJ6M/11Svj7Oodfc9icJ9IYDdzjj/3V88QhXlU476zRDOyFlq476qDJnhomxd6Z si8QDw2DP1Aqd84HvKJSQdfpdXZ7H3B0ko1IheM8bOSj2PStf66pc8mIfZl0/1K8eMY8 hYHnp9bfUZwc9doB/QeMHloGJyj9rkSGVCrIrizbYQZP6gAhultSgMIrSpK5zQPiNtWL ZqD8sW5WX/1Af4qpr1DwReaROWuMc7T5/QLA6sGrV4EnRrfsjV4Mx2uNpUUArmVYeb6s 1bwHna1YoswHe2XZsjKz8p8pirZzBd0tvxMcBgJiBaaOmx+0ggpshQjHLP40H6CDhIuy TOHA== X-Gm-Message-State: APjAAAUXJutc2FfjZhGadGJNd9oxJ+oygj9Fa/tzUJ0CiGCd0eHyZEkt C+bJIyJEqslorzIK4KzngTupg8GwPmkl3g== X-Google-Smtp-Source: APXvYqwdMCoimLlutKtGy13ACJ1a0oRQJjRzds/zkaQ4ijmdtpgVOLJbe8KTU4BV/g99wJ5vTEzl6g== X-Received: by 2002:a17:906:55d6:: with SMTP id z22mr15020391ejp.154.1560248000476; Tue, 11 Jun 2019 03:13:20 -0700 (PDT) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com. [209.85.221.53]) by smtp.gmail.com with ESMTPSA id a17sm3581203edt.63.2019.06.11.03.13.18 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jun 2019 03:13:19 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id n4so12372484wrs.3 for ; Tue, 11 Jun 2019 03:13:18 -0700 (PDT) X-Received: by 2002:a5d:514d:: with SMTP id u13mr32683805wrt.77.1560247997738; Tue, 11 Jun 2019 03:13:17 -0700 (PDT) MIME-Version: 1.0 References: <20190417104511.21514-1-frederic.chen@mediatek.com> <20190417104511.21514-7-frederic.chen@mediatek.com> <20190509094846.GA65444@google.com> <1558466055.15388.342.camel@mtksdccf07> <1560242886.23799.13.camel@mtksdccf07> <1560247648.23799.16.camel@mtksdccf07> In-Reply-To: <1560247648.23799.16.camel@mtksdccf07> From: Tomasz Figa Date: Tue, 11 Jun 2019 19:13:06 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver To: Frederic Chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_031322_261292_DA0FAA18 X-CRM114-Status: GOOD ( 28.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shik Chen , devicetree@vger.kernel.org, =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , Laurent Pinchart , =?UTF-8?B?UnlubiBXdSAo5ZCz6IKy5oGpKQ==?= , srv_heupstream , =?UTF-8?B?SG9sbWVzIENoaW91ICjpgrHmjLop?= , suleiman@chromium.org, Jerry-ch Chen , =?UTF-8?B?SnVuZ28gTGluICjmnpfmmI7kv4op?= , Sj Huang , yuzhao@chromium.org, "moderated list:ARM/Mediatek SoC support" , zwisler@chromium.org, Matthias Brugger , =?UTF-8?B?Q2hyaXN0aWUgWXUgKOa4uOmbheaDoCk=?= , Mauro Carvalho Chehab , Hans Verkuil , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 11, 2019 at 7:07 PM Frederic Chen wrote: > > Hi Tomasz, > > > On Tue, 2019-06-11 at 17:59 +0900, Tomasz Figa wrote: > > On Tue, Jun 11, 2019 at 5:48 PM Frederic Chen > > wrote: > > > > > > Dear Tomasz, > > > > > > I'd like to elaborate more about the tuning_data.va. > > > Would you like to give us some advice about our improvement proposal inline? > > > > > > Thank you very much. > > > > > > > > > On Wed, 2019-05-22 at 03:14 +0800, Frederic Chen wrote: > > > > Dear Tomasz, > > > > > > > > I appreciate your comment. It is very helpful for us. > > > > > > > > > > > > > > diff --git a/drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c b/drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c > > > > > > new file mode 100644 > > > > > > index 000000000000..54d2b5f5b802 > > > > > > --- /dev/null > > > > > > +++ b/drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c > > > > > > @@ -0,0 +1,1384 @@ > > > > > > [snip] > > > > > > > > > +static void dip_submit_worker(struct work_struct *work) > > > > > > +{ > > > > > > + struct mtk_dip_hw_submit_work *dip_submit_work = > > > > > > + container_of(work, struct mtk_dip_hw_submit_work, frame_work); > > > > > > + struct mtk_dip_hw *dip_hw = dip_submit_work->dip_hw; > > > > > > + struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw); > > > > > > + struct mtk_dip_hw_work *dip_work; > > > > > > + struct mtk_dip_hw_subframe *buf; > > > > > > + u32 len, num; > > > > > > + int ret; > > > > > > + > > > > > > + num = atomic_read(&dip_hw->num_composing); > > > > > > + > > > > > > + mutex_lock(&dip_hw->dip_worklist.queuelock); > > > > > > + dip_work = list_first_entry(&dip_hw->dip_worklist.queue, > > > > > > [snip] > > > > > > > > > + > > > > > > + if (dip_work->frameparams.tuning_data.pa == 0) { > > > > > > + dev_dbg(&dip_dev->pdev->dev, > > > > > > + "%s: frame_no(%d) has no tuning_data\n", > > > > > > + __func__, dip_work->frameparams.frame_no); > > > > > > + > > > > > > + memcpy(&dip_work->frameparams.tuning_data, > > > > > > + &buf->tuning_buf, sizeof(buf->tuning_buf)); > > > > > > > > > > Ditto. > > > > > > > > > > > > > I got it. > > > > > > > > > > + memset((char *)buf->tuning_buf.va, 0, DIP_TUNING_SZ); > > > > > > > > > > Ditto. > > > > > > > > I got it. > > > > > > > > > > > > > > > + /* > > > > > > + * When user enqueued without tuning buffer, > > > > > > + * it would use driver internal buffer. > > > > > > + * So, tuning_data.va should be 0 > > > > > > + */ > > > > > > + dip_work->frameparams.tuning_data.va = 0; > > > > > > > > > > I don't understand this. We just zeroed the buffer via this kernel VA few > > > > > lines above, so why would it have to be set to 0? > > > > > > > > > > > > > I will remove this unnecessary line. > > > > > > > > > > + } > > > > > > After confirming the firmware part, I found that we use this field > > > (tuning_data.va) to notify firmware if there is no tuning data from > > > user. > > > > > > - frameparams.tuning_data.va is 0: use the default tuning data in > > > SCP, but we still need to pass > > > frameparams.tuning_data.pa because > > > the buffer contains some working > > > buffer required. > > > - frameparams.tuning_data.va is not 0: the tuning data was passed from > > > the user > > > > > > Since we should not pass cpu addres to SCP, could I rename tuning_data.va > > > as tuning_data.cookie, and write a constant value to indicate if SCP > > > should use its internal default setting or not here? > > > > > > For example, > > > /* SCP uses tuning data passed from userspace*/ > > > dip_work->frameparams.tuning_data.cookie = MTK_DIP_USER_TUNING_DATA; > > > > > > /* SCP uses internal tuning data */ > > > dip_work->frameparams.tuning_data.cookie = MTK_DIP_DEFAULT_TUNING_DATA; > > > > Perhaps we could just call it "present" and set to true or false? > > > > Yes. I would like to use "present" here. > > Original: > struct img_addr { > u64 va; /* Used by Linux OS access */ > u32 pa; /* Used by CM4 access */ > u32 iova; /* Used by IOMMU HW access */ > } __attribute__ ((__packed__)); > > struct img_ipi_frameparam { > u32 index; > u32 frame_no; > u64 timestamp; > u8 type; /* enum mdp_stream_type */ > u8 state; > u8 num_inputs; > u8 num_outputs; > u64 drv_data; > struct img_input inputs[IMG_MAX_HW_INPUTS]; > struct img_output outputs[IMG_MAX_HW_OUTPUTS]; > struct img_addr tuning_data; > struct img_addr subfrm_data; > struct img_sw_addr config_data; > struct img_sw_addr self_data; > } __attribute__ ((__packed__)); > > > Modified: > struct tuning_buf { > u8 present; I'd make this u32 to keep the other fields aligned. > u32 pa; /* Used by CM4 access */ > u32 iova; /* Used by IOMMU HW access */ > } __attribute__ ((__packed__)); Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel