From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 801ACC5DF61 for ; Thu, 7 Nov 2019 03:14:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EE3120869 for ; Thu, 7 Nov 2019 03:14:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nQmxCmUU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YMfJpiCN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EE3120869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2h5pYa4F03YSy2YWyQwepp8UDI/dxPZhiiLW3T+lHaM=; b=nQmxCmUUuvWFK7 +/kZF90g9WKkZYRpGfUmQpu1bNwzxLq0oQC4+53KsZfKbfG5h62hXXB5blxT3At0+y+h4GnWS9ovw 8hWkkpuSlL9hWHWK+6chw0E5FiOrWYPw/EtB0O0k8OmF2i3IxCAjx9jVZcIiavArTUzZZfm0HhiB8 vEzeP7v4apUqgZyPG68tUfZ4QDr5rq7wlRZ7rLgXwUjkylbXAkQk3+uFH0eAgQ4Hk1bVL7zkxYgy7 AG5/Q57VsoYHDRwx6oOa/Y/B3xcqMsGfj8gRHfjfFko2YpsWb5O9vf0tUuUMcRV4I+4uf9iOL7AYm tpQg/P776aVZDpxIiFmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSYG6-0002Ym-5X; Thu, 07 Nov 2019 03:14:54 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSYG2-0002YS-SH for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2019 03:14:52 +0000 Received: by mail-ed1-x541.google.com with SMTP id p59so637605edp.7 for ; Wed, 06 Nov 2019 19:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AAfjo+6GX40N8x/qOoAPJLTNhLDPy6SYwK6lSBU1urk=; b=YMfJpiCN4Ig8D+LLOBNrepFfMz7Ze5j63f+c9Uw8V5q9niZmdpwGA+CXuQuw5PrWS3 7dTE+HC+yEBDy3rtNxNpUJeDPn2L8svDkdkUHIxc9CIRoxICSYDdy1kzKdOnOPS2U2cX ak6fy7fMi6PIbdJJLXbqqFBQHk80kW0gbEpmk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AAfjo+6GX40N8x/qOoAPJLTNhLDPy6SYwK6lSBU1urk=; b=Kgnt4Jvz6eH4NX8v1RsVMlFURg45iAO5XLwpFOWqePkklvuNNRMFMytPcSMFbiNXVY AS4YHm8FhF+LfHdoKBYF5K+5dSywX2gHLmaQVYX3X5pvkqBKgVt9zmceHyMMPn1Vmlxe NaDdVkAff+D3z8Bq7cpfeEjku+Pn8M1Mk5TQW/yq4sl0UAlJnN2sVjFiUDlOL6Ny//ms rPeGT6gM51XZWtwD2A7y7YfHffWUvY8IREJe0T0HIXwTp9JZ8zMzlrze7Ccj1H0k7mNs y3pwR/+b1GrV8ijEF4ZjldldmQLQRvQVv1DJ6Zf9VtraSS0afacOIsLAQY+VOp8yQf6V iQgQ== X-Gm-Message-State: APjAAAXfWh4l7Axnx1QT6knrSPun2QYf+0Z2mVI1iIsjxtl76glIhcFB YVtxEFXCig2QsGvV8kKwu8hvC+MImUOC+w== X-Google-Smtp-Source: APXvYqxtTjbM3CLBbpPV58n74owu1FMRP9sEs74HNLlL2Ncvn8yYiUZQAshnX5EpWGTZtbZEfi2Z8w== X-Received: by 2002:a17:906:ccd6:: with SMTP id ot22mr959779ejb.166.1573096487970; Wed, 06 Nov 2019 19:14:47 -0800 (PST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com. [209.85.221.50]) by smtp.gmail.com with ESMTPSA id r3sm18963eds.64.2019.11.06.19.14.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Nov 2019 19:14:47 -0800 (PST) Received: by mail-wr1-f50.google.com with SMTP id p2so1314273wro.2 for ; Wed, 06 Nov 2019 19:14:47 -0800 (PST) X-Received: by 2002:a5d:4946:: with SMTP id r6mr52152wrs.155.1573096120434; Wed, 06 Nov 2019 19:08:40 -0800 (PST) MIME-Version: 1.0 References: <20191106120132.6876-1-helen.koike@collabora.com> <20191106120132.6876-2-helen.koike@collabora.com> <9102bcf8-0279-7972-daff-b15aaf98804d@cisco.com> <28cff7ab-ef56-791e-0342-571f64cb9807@collabora.com> In-Reply-To: From: Tomasz Figa Date: Thu, 7 Nov 2019 12:08:27 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v9 1/4] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format To: Helen Koike X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_191450_916015_C69959F9 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "eddie.cai.linux@gmail.com" , "kernel@collabora.com" , "heiko@sntech.de" , "gregkh@linuxfoundation.org" , "jeffy.chen@rock-chips.com" , "zyc@rock-chips.com" , "linux-kernel@vger.kernel.org" , Jacob Chen , "Hans Verkuil \(hansverk\)" , "linux-rockchip@lists.infradead.org" , "hans.verkuil@cisco.com" , "laurent.pinchart@ideasonboard.com" , "sakari.ailus@linux.intel.com" , "zhengsq@rock-chips.com" , "mchehab@kernel.org" , Ezequiel Garcia , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 7, 2019 at 8:26 AM Helen Koike wrote: > > > > On 11/6/19 11:44 AM, Ezequiel Garcia wrote: > > Hi Hans, Helen: > > > > On Wed, 2019-11-06 at 09:30 -0300, Helen Koike wrote: > >> > >> On 11/6/19 10:22 AM, Hans Verkuil (hansverk) wrote: > >>> On 11/6/19 1:01 PM, Helen Koike wrote: > >>>> From: Shunqian Zheng > >>>> > >>>> Add the Rockchip ISP1 specific processing parameter format > >>>> V4L2_META_FMT_RK_ISP1_PARAMS and metadata format > >>>> V4L2_META_FMT_RK_ISP1_STAT_3A for 3A. > >>>> > >>>> Signed-off-by: Shunqian Zheng > >>>> Signed-off-by: Jacob Chen > >>>> Acked-by: Hans Verkuil > >>> > >>> I acked this? It is missing documentation for these new formats. > >> > >> I think so https://www.spinics.net/lists/linux-rockchip/msg18999.html :) > >> > >> I'll update the docs and the fixes you pointed below. > >> > >> Thanks. > >> Helen > >> > >>>> [refactored for upstream] > >>>> Signed-off-by: Helen Koike > >>>> Reviewed-by: Laurent Pinchart > >>>> > >>>> --- > >>>> > >>>> Changes in v9: > >>>> - Add reviewed-by tag from Laurent > >>>> > >>>> Changes in v8: None > >>>> Changes in v7: > >>>> - s/IPU3/RK_ISP1 > >>>> > >>>> drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > >>>> include/uapi/linux/videodev2.h | 4 ++++ > >>>> 2 files changed, 6 insertions(+) > >>>> > >>>> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > >>>> index 315ac12c3e0a..ade990554caf 100644 > >>>> --- a/drivers/media/v4l2-core/v4l2-ioctl.c > >>>> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > >>>> @@ -1341,6 +1341,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > >>>> case V4L2_META_FMT_UVC: descr = "UVC Payload Header Metadata"; break; > >>>> case V4L2_META_FMT_D4XX: descr = "Intel D4xx UVC Metadata"; break; > >>>> case V4L2_META_FMT_VIVID: descr = "Vivid Metadata"; break; > >>>> + case V4L2_META_FMT_RK_ISP1_PARAMS: descr = "Rockchip ISP1 3A params"; break; > >>> > >>> params -> Params > >>> > >>>> + case V4L2_META_FMT_RK_ISP1_STAT_3A: descr = "Rockchip ISP1 3A statistics"; break; > >>> > >>> statistics -> Statistics > >>> > >>>> > >>>> default: > >>>> /* Compressed formats */ > >>>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > >>>> index f98bbcced8ff..56798b09cd85 100644 > >>>> --- a/include/uapi/linux/videodev2.h > >>>> +++ b/include/uapi/linux/videodev2.h > > > > Can we avoid touching videodev2.h, as we did for the stateless codec pixfmts? > > I think it should be part of the uapi, as it is the metadata format used in the video output device. > I propose to leave it inside drivers/staging/media/rkisp1/uapi/rkisp1-config.h while the driver is in staging, > then we expose it later with a better documentation too. Make sense? Makes sense, as it's also what we've done for ipu3, +/- a slightly different path: https://elixir.bootlin.com/linux/latest/source/drivers/staging/media/ipu3/include/intel-ipu3.h#L12 We could possibly move the header to include/rockchip-isp1.h to be consistent. Best regards, Tomasz > > Thanks, > Helen > > > > > Thanks, > > Ezequiel > > > >>>> @@ -762,6 +762,10 @@ struct v4l2_pix_format { > >>>> #define V4L2_META_FMT_D4XX v4l2_fourcc('D', '4', 'X', 'X') /* D4XX Payload Header metadata */ > >>>> #define V4L2_META_FMT_VIVID v4l2_fourcc('V', 'I', 'V', 'D') /* Vivid Metadata */ > >>>> > >>>> +/* Vendor specific - used for RK_ISP1 camera sub-system */ > >>>> +#define V4L2_META_FMT_RK_ISP1_PARAMS v4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 params */ > >>>> +#define V4L2_META_FMT_RK_ISP1_STAT_3A v4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A statistics */ > >>>> + > >>>> /* priv field value to indicates that subsequent fields are valid. */ > >>>> #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe > >>>> > >>>> > >>> > >>> Regards, > >>> > >>> Hans > >>> > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel