From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11976C7618B for ; Fri, 26 Jul 2019 14:10:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBFF521850 for ; Fri, 26 Jul 2019 14:10:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Uy2WaaCk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aw5WQtbs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBFF521850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aY6ADIpCw9XnO897mQu1Wm3PESsCOuB3i+Nb6Xrcpro=; b=Uy2WaaCkrFgpSt OXNvEFS1Xmne0v3HBcXlnLB/OWd1A5HSthecf3zxFT1wSlHgGglHJRyYoSaLNi77h8yUGa1zOxu5v OTvknV56Dz8RFfGd6Ij90LAu+aa2RPdyQMjfu9iyaDmwQRRkiufVqpMVlB4MwvDFZwIFt8Wi8teUu wulQaFdGLkv6l6b0kL8a4iS0jNlgI8Bc/v0b9CLN98/c2ksZX6a03u/BSGZJOXIi3OXUs9dPpLuYw RGyDlTummcskfB2fRHnwkHXPCha2L5V91fBhEtTB/ZNhvn0I5bmdRKiaOZyhYS4hMebqLK5L3nnjN UHjpzl0dazwk+pqBan5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hr0vB-0002YR-P1; Fri, 26 Jul 2019 14:10:09 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hr0v8-0001wK-J7 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 14:10:08 +0000 Received: by mail-ed1-x541.google.com with SMTP id e3so53416671edr.10 for ; Fri, 26 Jul 2019 07:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h4O4z+O+RC1JwnWktDyaiJMFv2NH81YwETYIA8cC4R4=; b=aw5WQtbsqLZ0f8nctZ02nXZA/NLGPbLx7lFP0F/tGyj5eow+za6vJHr/9xIVsd7jnU ICYACBFD9ozBMsUnq5wBnpaA1P5MkvkEaMvwi/UUfWLl/NLvdQdq4mOOsEUKDqD1+dzu FW4cq5+prK2G5oYhDDqTLWI43JgEgs9ZbmDCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h4O4z+O+RC1JwnWktDyaiJMFv2NH81YwETYIA8cC4R4=; b=lVXA2TDYRofzcHrzJomcQul4A1zBcwc0vaO6JEbLgPf5AJC8WI/XV/tpZnYaARsO2k njruSbGQrxsG+RGq70OHWG+h9e20E86mYVJUzjxOpgl1Jd5sS1Lbpe9PnOSyszu00ch4 KoM4up1hYrD02PgV9YOfFbkGkNfM3MadN0QImrRLzS4Xp5N43uSkozD3qSZzP6b4k/7V DLKjmSB4oQRV/DutzxiA8xIvfXdYz9mPGn1G6SLjMcls47vndELENQ6i9EbbST1Lcnvw Ho+davlyEBqqiNRiC0TNgoGLsBg8KVWkFHIMSij5Zo529T5wHpXZupcUH7EMyLQNL2pz L/lQ== X-Gm-Message-State: APjAAAUwqi0n28hwqllTJCZHC7y+K1AJizhvBlrjX9n7cSAVqv1AF9FT nO26wuxXc2rPWp0ClhgCmT04QxvnhniXPg== X-Google-Smtp-Source: APXvYqylg5ALI+ipwqtISPclIXNh8DAFBDfOIzNCBFTFlvLiHD4Yiq+XdDZRmhZJZZ2cVZJ+a7cCtA== X-Received: by 2002:a50:eb96:: with SMTP id y22mr82347168edr.211.1564150204912; Fri, 26 Jul 2019 07:10:04 -0700 (PDT) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com. [209.85.221.48]) by smtp.gmail.com with ESMTPSA id gz5sm10297987ejb.21.2019.07.26.07.10.04 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2019 07:10:04 -0700 (PDT) Received: by mail-wr1-f48.google.com with SMTP id y4so54624160wrm.2 for ; Fri, 26 Jul 2019 07:10:04 -0700 (PDT) X-Received: by 2002:adf:ed41:: with SMTP id u1mr97366899wro.162.1564149894620; Fri, 26 Jul 2019 07:04:54 -0700 (PDT) MIME-Version: 1.0 References: <20190611035344.29814-1-jungo.lin@mediatek.com> <20190611035344.29814-10-jungo.lin@mediatek.com> <20190701072532.GB137710@chromium.org> <1562297618.1212.46.camel@mtksdccf07> <1562313579.1212.73.camel@mtksdccf07> <1563870117.1212.455.camel@mtksdccf07> <20190726074116.GA19745@infradead.org> <4460bc91-352a-7f3a-cbed-1b95e743ca8c@arm.com> <1564142386.1212.621.camel@mtksdccf07> In-Reply-To: <1564142386.1212.621.camel@mtksdccf07> From: Tomasz Figa Date: Fri, 26 Jul 2019 23:04:42 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC, v3 9/9] media: platform: Add Mediatek ISP P1 shared memory device To: Jungo Lin , Robin Murphy X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190726_071006_670724_EE17F744 X-CRM114-Status: GOOD ( 23.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , =?UTF-8?B?RnJlZGVyaWMgQ2hlbiAo6Zmz5L+K5YWDKQ==?= , =?UTF-8?B?UnlubiBXdSAo5ZCz6IKy5oGpKQ==?= , srv_heupstream , Rob Herring , Joerg Roedel , =?UTF-8?B?UnlhbiBZdSAo5L2Z5a2f5L+uKQ==?= , =?UTF-8?B?RnJhbmtpZSBDaGl1ICjpgrHmloflh7Ep?= , "list@263.net:IOMMU DRIVERS" , Christoph Hellwig , Matthias Brugger , Sj Huang , "moderated list:ARM/Mediatek SoC support" , Laurent Pinchart , Hans Verkuil , ddavenport@chromium.org, Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 26, 2019 at 8:59 PM Jungo Lin wrote: > > Hi Robin: > > On Fri, 2019-07-26 at 12:04 +0100, Robin Murphy wrote: > > On 26/07/2019 08:42, Tomasz Figa wrote: > > > On Fri, Jul 26, 2019 at 4:41 PM Christoph Hellwig wrote: > > >> > > >> On Fri, Jul 26, 2019 at 02:15:14PM +0900, Tomasz Figa wrote: > > >>> Could you try dma_get_sgtable() with the SCP struct device and then > > >>> dma_map_sg() with the P1 struct device? > > >> > > >> Please don't do that. dma_get_sgtable is a pretty broken API (see > > >> the common near the arm implementation) and we should not add more > > >> users of it. If you want a piece of memory that can be mapped to > > >> multiple devices allocate it using alloc_pages and then just map > > >> it to each device. > > > > > > Thanks for taking a look at this thread. > > > > > > Unfortunately that wouldn't work. We have a specific reserved memory > > > pool that is the only memory area accessible to one of the devices. > > > Any idea how to handle this? > > > > If it's reserved in the sense of being outside struct-page-backed > > "kernel memory", then provided you have a consistent CPU physical > > address it might be reasonable for other devices to access it via > > dma_map_resource(). > > > > Robin. > > Thank you for your suggestion. > > After revising to use dma_map_resource(), it is worked. Below is the > current implementation. Pleas kindly help us to check if there is any > misunderstanding. > > #define MTK_ISP_COMPOSER_MEM_SIZE 0x200000 > > /* > * Allocate coherent reserved memory for SCP firmware usage. > * The size of SCP composer's memory is fixed to 0x200000 > * for the requirement of firmware. > */ > ptr = dma_alloc_coherent(p1_dev->cam_dev.smem_dev, > MTK_ISP_COMPOSER_MEM_SIZE, &addr, GFP_KERNEL); > if (!ptr) { > dev_err(dev, "failed to allocate compose memory\n"); > return -ENOMEM; > } > p1_dev->composer_scp_addr = addr; > p1_dev->composer_virt_addr = ptr; > dev_dbg(dev, "scp addr:%pad va:%pK\n", &addr, ptr); > > /* > * This reserved memory is also be used by ISP P1 HW. > * Need to get iova address for ISP P1 DMA. > */ > addr = dma_map_resource(dev, addr, MTK_ISP_COMPOSER_MEM_SIZE, > DMA_BIDIRECTIONAL, DMA_ATTR_SKIP_CPU_SYNC); This is still incorrect, because addr is a DMA address, but the second argument to dma_map_resource() is a physical address. > if (dma_mapping_error(dev, addr)) { > dev_err(dev, "Failed to map scp iova\n"); > ret = -ENOMEM; > goto fail_free_mem; > } > p1_dev->composer_iova = addr; > dev_info(dev, "scp iova addr:%pad\n", &addr); > > Moreover, appropriate Tomasz & Christoph's help on this issue. Robin, the memory is specified using the reserved-memory DT binding and managed by the coherent DMA pool framework. We can allocate from it using dma_alloc_coherent(), which gives us a DMA address, not CPU physial address (although in practice on this platform they are equal numerically). Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel