From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF0E4C2D0A3 for ; Thu, 12 Nov 2020 04:28:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EEA6207BB for ; Thu, 12 Nov 2020 04:28:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jRskhvQZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HWhp+x5n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EEA6207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wz5cPIhdl2vVe/SMFyCx3bSR5N0LbPu5mnKzwHmbSD8=; b=jRskhvQZwIFQuXduHRMJzBNj4 +s9Z7d4y+24fElZNm16YHVjGvj0gQ8joeK78SDWyb27hTouInHwocsiASkq6bSnM1eGWfR1JZ7f9P M3FaLc0oo4lY/eLCqFTEhEZC3/1e1bXPNpUChQy1VLadCG4EwIaY0xkR86XC6suTl5fySzrbKMWf7 Okl1jDN7UM/wNQ/Z6UjzFzw1KXBheWWlwWBZACxUJ/DSkiq8zTar+CIxqqwUSD84p1puJjcTAfvjK 3bU2Vq8Y59MckQz3qR5YV42A179lI2nQeMNQsD2RTE8+6gJwpg0HISHdVXYrn5pXAd94ttFnFYGwh 2d8FOYWGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd4CJ-0001g8-4H; Thu, 12 Nov 2020 04:26:59 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd4CF-0001fG-Rz for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 04:26:56 +0000 Received: by mail-ej1-x642.google.com with SMTP id o21so5827341ejb.3 for ; Wed, 11 Nov 2020 20:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PrJGFWR5LfPadBQJXtxR3X13DiYJSukzmCqstyB653Y=; b=HWhp+x5nR3T+EuumQWwhx5XTPD7QV5SlMbprd7oGYb7NT1tsUS8M5b4CCExQirLXf1 n6xB1vMrsTHoCd3FbJvdOGzMuDQtsl1hs78cs62DjPqqlEQe7GQ0p/ZW5fyjKOmsxAtD iRHM55F9z6oGEmav+yyjAu5YCy5KSCZCidFCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PrJGFWR5LfPadBQJXtxR3X13DiYJSukzmCqstyB653Y=; b=E2TYIQp7MOe2Jn8ykhj3DCPeA3HiJaZrOVv8/ZQI53wz5sABTYpHwSFiAK6ewAnCBJ 9B+EV95gt3YMV2UDlPkN2KRkvWrZPBvJD6sWDzh9rDSNNYx46xwYzX5uvlX5EYoB2gox JtkhLx/1RkBOlPQRCjq2JgJ2IDnf46an/SMrEWB0Qi6xGPolL7c1Y4deTCvbLylIU2TQ 1mdGGNABV5HHo3sY8rNg/DzuQVQ/XONyE1lPuOoVNnNCDkcRs75I5GanDHhiEKB6NPtm TYtGDuLMFXWJH3NoRaLYVUHbosYBLZsNaMg7XqxQdMTdlkkEYa1CVht6xB5es1aN3Jb7 1eVw== X-Gm-Message-State: AOAM532zHBiYIL1UUUlksYaXo9iHwdaHPmigAT+VTjwURs2wjzc4TX/s O7tpiXPMPr+auLvuBAZoOQVqe0uqsJxKKw== X-Google-Smtp-Source: ABdhPJxS9c/qD2SvJItbL12CsjghL8vaK5OBgbCnGBOYYwWVaNqo1TmL/HWiokuSm+2JyF45TaqJFw== X-Received: by 2002:a17:906:8401:: with SMTP id n1mr27931350ejx.215.1605155212715; Wed, 11 Nov 2020 20:26:52 -0800 (PST) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com. [209.85.221.41]) by smtp.gmail.com with ESMTPSA id fx1sm1579606ejb.12.2020.11.11.20.26.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 20:26:51 -0800 (PST) Received: by mail-wr1-f41.google.com with SMTP id p1so4545129wrf.12 for ; Wed, 11 Nov 2020 20:26:50 -0800 (PST) X-Received: by 2002:adf:e54f:: with SMTP id z15mr32685970wrm.159.1605155209811; Wed, 11 Nov 2020 20:26:49 -0800 (PST) MIME-Version: 1.0 References: <20191204124732.10932-1-Jerry-Ch.chen@mediatek.com> <1588903371.16825.14.camel@mtksdccf07> <20200521183825.GB249683@chromium.org> <1593526253.29676.28.camel@mtksdccf07> <20200630171912.GE1212092@chromium.org> <1605095509.28992.7.camel@mtksdccf07> In-Reply-To: <1605095509.28992.7.camel@mtksdccf07> From: Tomasz Figa Date: Thu, 12 Nov 2020 13:26:39 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH V4 0/4] media: platform: Add support for Face Detection (FD) on mt8183 SoC To: Jerry-ch Chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_232655_985764_2395C22C X-CRM114-Status: GOOD ( 39.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , "laurent.pinchart+renesas@ideasonboard.com" , "zwisler@chromium.org" , srv_heupstream , =?UTF-8?B?Q2hyaXN0aWUgWXUgKOa4uOmbheaDoCk=?= , HansVerkuil , =?UTF-8?B?SnVuZ28gTGluICjmnpfmmI7kv4op?= , =?UTF-8?B?U2ogSHVhbmcgKOm7g+S/oeeSiyk=?= , "yuzhao@chromium.org" , "hans.verkuil@cisco.com" , "pihsun@chromium.org" , =?UTF-8?B?RnJlZGVyaWMgQ2hlbiAo6Zmz5L+K5YWDKQ==?= , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 11, 2020 at 8:51 PM Jerry-ch Chen wrote: > > Hi Tomasz, > > On Wed, 2020-07-01 at 01:19 +0800, Tomasz Figa wrote: > > Hi Jerry, > > > > On Tue, Jun 30, 2020 at 10:10:53PM +0800, Jerry-ch Chen wrote: > > > Hi Tomasz, > > > > > > On Thu, 2020-05-21 at 18:38 +0000, Tomasz Figa wrote: > > > > Hi Jerry, > > > > > > > > On Wed, May 13, 2020 at 11:45:37PM +0200, Tomasz Figa wrote: > > > > > Hi Jerry, > > > > > > > > > > On Fri, May 8, 2020 at 4:03 AM Jerry-ch Chen wrote: > > > > > > > > > > > > Hi Laurent, Tomasz, Matthias, > > > > > > > > > > > > gentle ping for this patch set, > > > > > > If no new comments, I would like to send a newer version. > > > > > > > > > > > > > > > > Sorry, I still haven't had a chance to look at the series, so feel > > > > > free to send a new version and I will take a look at the new one. > > > > > > > > > > > > > Finally found some time to review the series. Again sorry for the delay > > > > and thanks for your patience. > > > > > > > > Some general comments: > > > > 1) The metadata format FourCC should be added in a separate patch, > > > > together with documentation for it. > > > > 2) Control IDs, structs used by the userspace, etc. should be defined in > > > > a header under include/uapi/linux. > > > > > > > > Please also check my replies to particular patches for further comments. > > > > > > > > Best regards, > > > > Tomasz > > > > > > Appreciate for your reply, > > > > > > So far, I've locally created an uapi header: > > > include/uapi/linux/mtk_fd_40.h > > > which provides some values, control ids, and the definitions of > > > structures that would be needed by user of mtk_fd_40 driver. > > > In addition, I also provide a MACRO as example in comments that can > > > extract the struct member with bit length and offset > > > definitions(eliminate the bit-fields). > > > > > > Also, I would like to rename struct fd_user_output with struct > > > mtk_fd_hw_result. I worry fd_user_output would be a confusing name. > > > > The change sounds good to me. > > > > > I will add them in a separate patch in next version. > > > > > > > Okay. > > > > > I am still working on the documentation, which might be > > > Documentation/media/uapi/v4l/pixfmt-meta-mtk-fd-40.rst. > > > Refering the other pixfmt-*.rst files, I will try to provide the > > > flat-table of the metadata with the structure of the mtk_fd_hw_result. > > > > > > > Sounds good to me. > > > > > I am confusing that should I remain the name with -40 in the tail of rst > > > file? > > > > The header and documentation file names should match the driver name. I > > just noticed there is some inconsistency in the naming, though. The > > driver seems to be located under drivers/media/platform/mtk-isp/fd, but > > the driver name in the platform driver struct and as reported by > > VIDIOC_QUERYCAP seems to be "mtk-fd-4.0". > > > Since we have many mtk-* drivers in the tree currently, I think it might > > make sense to consolidate them under drivers/media/platform/mediatek, > > similarly to drivers/media/platform/qcom or /rockchip. But it could be > > done later, as a follow-up. > > > > My suggestion would be to place the driver under > > drivers/media/platform/mtk-fd-40 and also rename the related Kconfig > > symbol to include the _40 suffix. > > > > What do you think? > > > > I Appreciate your comments, > Sorry for the late reply. > > Would it be possible for me to replace the driver as drivers/media/platform/mtk_fd/mtk-fd-40?(Just like mtk-isp/isp_50) > I'm not a big fan of duplicating "mtk fd" in the path. How about just making it drivers/media/platform/mtk-fd-40? Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel