From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5F6C4363D for ; Wed, 7 Oct 2020 12:49:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBEBD20789 for ; Wed, 7 Oct 2020 12:49:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u02m6M2T"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OwAuf7F2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBEBD20789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fu+pcaVNTWmzRZLg01PDw54oYVLnMbB/7Q5TY8Cwlmw=; b=u02m6M2TZa03zrZBU+CXXTcRH NNUKiXgkz9k1kqlbmGPsSMEcP6yQdRaYRI3VcIK9EpRwFdj+QJUJpaJOpjFki6iYpAsP+1UAP/ngL oPXXuiWtFL1wJrI4S+7pCxFSXqDwSFdetg/OFpxPs3ruGCgk0CKfn9NkOus72y8fiG18XWCDmX5/C Uje22PNpnnU9ch/aaR+XA7883PR/w5jl0LkFXkT3K6YvAqII6ekwSGqe7v0PG4zv1+rypt+H3XkLo Di2+nbiFgIyccwEwq8cnGMdWpvjyAiqazHxKU1s5a7XPiUcspdACONM9rJtnf1EiUSQJlxVP2miCv GZwUN02iQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ8s3-0003A4-8S; Wed, 07 Oct 2020 12:48:39 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ8s0-00033N-9x for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 12:48:37 +0000 Received: by mail-ej1-x644.google.com with SMTP id h24so2736189ejg.9 for ; Wed, 07 Oct 2020 05:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8DgUuIRfcHlPhdxgua6tbSE2mebG0xHkllja1Sz9A+A=; b=OwAuf7F2NQb/bsfTM2qcO5DjrhllMR1QqFDtj/L3iekZAReq3qsqXSiEABTatoXxTB rDETHWmgxlHX7z4dhuSD2d4gWdOO/SQlLd1ksmCUxOY435tx1KNZZq94LRBlSVJGBKWq DO8qOQ4lkUnHLmdS85byS9GsBNdfVMiJquDxE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8DgUuIRfcHlPhdxgua6tbSE2mebG0xHkllja1Sz9A+A=; b=GxYMP1frhplVE5JAqyFqrE7VQDj6hgnatMxB9MTUWqVSEQPeYNMg9VeMe+Hbsz+4o9 /x9jUUHFubenJLi34KRal9fjqT23J7Bf/wY6b7vf8h2qwCoPgMUqhkXTuzKWfNhBXeh7 nX3LgxTammqkUUThjrG/WJ6Lq/l8ZW0tjH/N5IMWuVg08pIw27yCkuY7swcT1LZdSKzT JrYvKgGCAtvl23E3gYsFmCp52z4969ZJbcuREGP5UyBJUwtq1FGy2Y0sV4Qbb8XETwaf +XOYCV9uruMjh4cmlBtOhjBkoPCxTfxKuz/KmBPX2u0prtNVS+XRmLGwWlhBQANczej1 +B2A== X-Gm-Message-State: AOAM532OyS7cTI3jSIO9+syINEkwf1Jq2XbLVRBmrTPU9QNX3gk7p/L0 Rxs6cwNbZShu1FSGA98Z4MhqeAiM2Fg07g== X-Google-Smtp-Source: ABdhPJwPeS+3rVTgO3zxe3wjB5xAOmfwWFiYdAKjfvZtcKCRdeX18o9bCG5rykwPP4oOL8cFTMOvIg== X-Received: by 2002:a17:906:aec1:: with SMTP id me1mr3267436ejb.225.1602074889940; Wed, 07 Oct 2020 05:48:09 -0700 (PDT) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com. [209.85.128.49]) by smtp.gmail.com with ESMTPSA id nu20sm1440144ejb.109.2020.10.07.05.48.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Oct 2020 05:48:07 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id p15so2163061wmi.4 for ; Wed, 07 Oct 2020 05:48:07 -0700 (PDT) X-Received: by 2002:a1c:4904:: with SMTP id w4mr2925784wma.99.1602074886765; Wed, 07 Oct 2020 05:48:06 -0700 (PDT) MIME-Version: 1.0 References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> <20201002175303.390363-2-daniel.vetter@ffwll.ch> <20201002180603.GL9916@ziepe.ca> <20201002233118.GM9916@ziepe.ca> <725819e9-4f07-3f04-08f8-b6180406b339@samsung.com> <20201007124409.GN5177@ziepe.ca> In-Reply-To: <20201007124409.GN5177@ziepe.ca> From: Tomasz Figa Date: Wed, 7 Oct 2020 14:47:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM To: Jason Gunthorpe X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_084836_355673_7A0B1C2C X-CRM114-Status: GOOD ( 19.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Inki Dae , linux-samsung-soc , Jan Kara , Joonyoung Shim , Pawel Osciak , Daniel Vetter , Seung-Woo Kim , LKML , DRI Development , Kyungmin Park , Linux MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , John Hubbard , Daniel Vetter , Andrew Morton , "open list:DMA BUFFER SHARING FRAMEWORK" , Dan Williams , Linux ARM , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 7, 2020 at 2:44 PM Jason Gunthorpe wrote: > > On Wed, Oct 07, 2020 at 02:33:56PM +0200, Marek Szyprowski wrote: > > Well, it was in vb2_get_vma() function, but now I see that it has been > > lost in fb639eb39154 and 6690c8c78c74 some time ago... > > There is no guarentee that holding a get on the file says anthing > about the VMA. This needed to check that the file was some special > kind of file that promised the VMA layout and file lifetime are > connected. > > Also, cloning a VMA outside the mm world is just really bad. That > would screw up many assumptions the drivers make. > > If it is all obsolete I say we hide it behind a default n config > symbol and taint the kernel if anything uses it. > > Add a big comment above the follow_pfn to warn others away from this > code. Sadly it's just verbally declared as deprecated and not formally noted anyway. There are a lot of userspace applications relying on user pointer support. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel