From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BB1C3A5A2 for ; Tue, 3 Sep 2019 12:12:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FBFF22CF7 for ; Tue, 3 Sep 2019 12:12:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I2yUY7Oz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="f+pChn1D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FBFF22CF7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xAeb1/l997h6afRkV6n8hIwsXO/gNAMrvoH/2HV1NSM=; b=I2yUY7OzPVINb+ DODUb1sRLLWjVkLN2NEbtRuYwMr+kX1yahEOLy2O9Qr/6l9uKw29oJHg9ej0fk1/pQxwR5OSgyqU9 5Yrvc9DQdp+UAY0yjrOLhO3LHRVUndZ1+vP1YybbbAfz6pQRD8ZfNr7MwnnWXibtgjpdCDHwHXxny YhQ5TQeKeqSfXiGMIE5zyvmvgzstG5uRO9D9Sw2d+VJBcXdVa36Pqv6QWNuIjNom5C5UoYGv9BRZ7 TbEVljvHBJjK415wcgx19T1y2WceAtdBz9NAxfnH4MbA2NVjpeb/AnkKNhgRrARpotJoRLVQMOyj7 zqrdmRI/UXhL0Ov1lEVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i57fV-0002om-Sn; Tue, 03 Sep 2019 12:12:17 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i57fS-0002o6-5J for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2019 12:12:16 +0000 Received: by mail-ed1-x541.google.com with SMTP id o9so6747960edq.0 for ; Tue, 03 Sep 2019 05:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=shfr8al4rhi7VC5dVA+njaWSgXwMHRZNL54RSSYO5X8=; b=f+pChn1DWI1kDyOALPT3YGKMc4fVTuji+fBHe796ew5lH7tmQdpTtcCo8tu0yBBCIY fmvRBhepeoyrUIhT5r9BlPlCbKYmb4aZoK6V/NPJNt5pMwSCTiQxV+5uU3ci46ZflHh5 a1oZwxt/uIM0qlJ1KtcbDrn+cGw1+ztea5YZ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=shfr8al4rhi7VC5dVA+njaWSgXwMHRZNL54RSSYO5X8=; b=O4j2Cfkskm73xzz4AyFjKRvc070tux82SvNCYow4xfniIVXWDCn6B1Z3Q8OgMvsSHq AlZ7Q7yAHsVL5KEtzGMr6CIvnlWsDrTDLS6Ey85WL1DS8NFBfcgRYe9wn1Z2GhmwTMmH pZspcDm4rbM7WUvkSv3C6l96Ej5+z2opPm/f3ZHIs00wut8NOE6q7GPh6xDRcgQ18FFE b6AF3YYlpn6vWVQYZIO3V1qzW4noQqohpgGTNPk7G8pAvO7Ffblg8X+3ricNJaoz6iNn 4H17+HC/Gby9VdB1ztwZhrDKELtf72nDqZtnOuU0ZWahhwTVzhoYIERHHGiZfWBW536H QtWg== X-Gm-Message-State: APjAAAWOk/cJ81vNb0e1iKO24ugcSTkCEjwD9woGruswW5wYKAByipAH h+4MU1W4G/AsQLQz26nE+M2r3JBZl0Ir4Q== X-Google-Smtp-Source: APXvYqx3cF9jSNntl/1mr9iDVWzgqOI1vK6XeFUx3OGoKsCOmbQsZxJzVN8A9Tv3M+Utbrm3FVim0Q== X-Received: by 2002:aa7:c542:: with SMTP id s2mr6004171edr.32.1567512732461; Tue, 03 Sep 2019 05:12:12 -0700 (PDT) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com. [209.85.128.46]) by smtp.gmail.com with ESMTPSA id mh8sm975913ejb.74.2019.09.03.05.12.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2019 05:12:12 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id o184so17947779wme.3 for ; Tue, 03 Sep 2019 05:12:12 -0700 (PDT) X-Received: by 2002:a05:600c:240a:: with SMTP id 10mr17374468wmp.113.1567512346368; Tue, 03 Sep 2019 05:05:46 -0700 (PDT) MIME-Version: 1.0 References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-5-git-send-email-Jerry-Ch.chen@mediatek.com> <20190802082815.GA203993@chromium.org> <1566724680.20680.8.camel@mtksdccf07> <1566957625.20680.33.camel@mtksdccf07> <1567424859.18318.32.camel@mtksdccf07> <1567493081.18318.49.camel@mtksdccf07> <1567511169.18318.65.camel@mtksdccf07> In-Reply-To: <1567511169.18318.65.camel@mtksdccf07> From: Tomasz Figa Date: Tue, 3 Sep 2019 21:05:34 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver To: Jerry-ch Chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190903_051214_231556_28EA79D0 X-CRM114-Status: GOOD ( 36.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , "laurent.pinchart+renesas@ideasonboard.com" , =?UTF-8?B?UnlubiBXdSAo5ZCz6IKy5oGpKQ==?= , srv_heupstream , =?UTF-8?B?UG8tWWFuZyBIdWFuZyAo6buD5p+P6Zm9KQ==?= , "mchehab@kernel.org" , "suleiman@chromium.org" , "shik@chromium.org" , =?UTF-8?B?SnVuZ28gTGluICjmnpfmmI7kv4op?= , =?UTF-8?B?U2ogSHVhbmcgKOm7g+S/oeeSiyk=?= , "yuzhao@chromium.org" , "linux-mediatek@lists.infradead.org" , "zwisler@chromium.org" , "matthias.bgg@gmail.com" , =?UTF-8?B?Q2hyaXN0aWUgWXUgKOa4uOmbheaDoCk=?= , =?UTF-8?B?RnJlZGVyaWMgQ2hlbiAo6Zmz5L+K5YWDKQ==?= , "hans.verkuil@cisco.com" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 3, 2019 at 8:46 PM Jerry-ch Chen wrote: > > Hi Tomasz, > > On Tue, 2019-09-03 at 15:04 +0800, Tomasz Figa wrote: > > On Tue, Sep 3, 2019 at 3:44 PM Jerry-ch Chen wrote: > > > > > > On Tue, 2019-09-03 at 13:19 +0800, Tomasz Figa wrote: > > > > On Mon, Sep 2, 2019 at 8:47 PM Jerry-ch Chen wrote: > > > > > > > > > > Hi Tomasz, > > > > > > > > > > On Fri, 2019-08-30 at 16:33 +0800, Tomasz Figa wrote: > > > > > > On Wed, Aug 28, 2019 at 11:00 AM Jerry-ch Chen > > > > > > wrote: > > > > > > > > > > > > > > Hi Tomasz, > > > > > > > > > > > > > > On Mon, 2019-08-26 at 14:36 +0800, Tomasz Figa wrote: > > > > > > > > Hi Jerry, > > > > > > > > > > > > > > > > On Sun, Aug 25, 2019 at 6:18 PM Jerry-ch Chen > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > Hi Tomasz, > > > > > > > > > > > > > > > > > > On Fri, 2019-08-02 at 16:28 +0800, Tomasz Figa wrote: > > > > > > > > > > Hi Jerry, > > > > > > > > > > > > > > > > > > > > On Tue, Jul 09, 2019 at 04:41:12PM +0800, Jerry-ch Chen wrote: > > > > [snip] > > > > > > > static int mtk_fd_vb2_queue_setup(struct vb2_queue *vq, > > > > > > > unsigned int *num_buffers, > > > > > > > unsigned int *num_planes, > > > > > > > unsigned int sizes[], > > > > > > > struct device *alloc_devs[]) > > > > > > > { > > > > > > > struct mtk_fd_ctx *ctx = vb2_get_drv_priv(vq); > > > > > > > struct device *dev = ctx->dev; > > > > > > > unsigned int size[2]; > > > > > > > > > > > > > > switch (vq->type) { > > > > > > > case V4L2_BUF_TYPE_META_CAPTURE: > > > > > > > size[0] = ctx->dst_fmt.buffersize; > > > > > > > break; > > > > > > > case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE: > > > > > > > size[0] = ctx->src_fmt.plane_fmt[0].sizeimage; > > > > > > > if (*num_planes == 2) > > > > > > > size[1] = ctx->src_fmt.plane_fmt[1].sizeimage; > > > > > > > break; > > > > > > > } > > > > > > > > > > > > > > if (*num_planes == 1) { > > > > > > > if (sizes[0] < size[0]) > > > > > > > return -EINVAL; > > > > > > > } else if (*num_planes == 2) { > > > > > > > if ((sizes[0] < size[0]) && (sizes[1] < size[1])) > > > > > > > return -EINVAL; > > > > > > > > > > > > Can we just use a loop here and combine the 2 cases above? > > > > > > > > > > > > Also, we need to fail with -EINVAL if *num_planes is > 2. > > > > > > > > > > > > > } else { > > > > > > > *num_planes = 1; > > > > > > > sizes[0] = size[0]; > > > > > > > > > > > > This should be the case if *num_planes == 0 and the number of planes > > > > > > and sizes should match the currently active format. > > > > > > > > > > > I appreciate your comments, > > > > > > > > > > Ok, I will update as following: > > > > > static int mtk_fd_vb2_queue_setup(struct vb2_queue *vq, > > > > > unsigned int *num_buffers, > > > > > unsigned int *num_planes, > > > > > unsigned int sizes[], > > > > > struct device *alloc_devs[]) > > > > > { > > > > > struct mtk_fd_ctx *ctx = vb2_get_drv_priv(vq); > > > > > unsigned int size[2]; > > > > > unsigned int plane; > > > > > > > > > > switch (vq->type) { > > > > > case V4L2_BUF_TYPE_META_CAPTURE: > > > > > size[0] = ctx->dst_fmt.buffersize; > > > > > break; > > > > > case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE: > > > > > size[0] = ctx->src_fmt.plane_fmt[0].sizeimage; > > > > > if (*num_planes == 2) > > > > > size[1] = ctx->src_fmt.plane_fmt[1].sizeimage; > > > > > break; > > > > > } > > > > > > > > > > if (*num_planes > 2) > > > > > return -EINVAL; > > > > > if (*num_planes == 0) { > > > > > if (vq->type == V4L2_BUF_TYPE_META_CAPTURE) { > > > > > sizes[0] = ctx->dst_fmt.buffersize; > > > > > *num_planes = 1; > > > > > return 0; > > > > > } > > > > > > > > > > *num_planes = ctx->src_fmt.num_planes; > > > > > for (plane = 0; plane < *num_planes; plane++) > > > > > sizes[plane] = ctx->src_fmt.plane_fmt[plane].sizeimage; > > > > > return 0; > > > > > } > > > > > > > > > > for (plane = 0; plane < *num_planes; plane++) { > > > > > if(sizes[plane] < size[plane]) > > > > > return -EINVAL; > > > > > } > > > > > return 0; > > > > > } > > > > > > > > > > > > > Looks good, thanks! > > > > > > > > > > > } > > > > > > > > > > > > > > return 0; > > > > > > > } > > > > > > > > > > > > > > > [snip] > > > > > > > > > > > > > > > > > > > +static void mtk_fd_vb2_stop_streaming(struct vb2_queue *vq) > > > > > > > > > > > +{ > > > > > > > > > > > + struct mtk_fd_ctx *ctx = vb2_get_drv_priv(vq); > > > > > > > > > > > + struct vb2_buffer *vb; > > > > > > > > > > > > > > > > > > > > How do we guarantee here that the hardware isn't still accessing the buffers > > > > > > > > > > removed below? > > > > > > > > > > > > > > > > > > > Maybe we can check the driver state flag and aborting the unfinished > > > > > > > > > jobs? > > > > > > > > > (fd_hw->state == FD_ENQ) > > > > > > > > > > > > > > > > > > > > > > > > > Yes, we need to either cancel or wait for the currently processing > > > > > > > > job. It depends on hardware capabilities, but cancelling is generally > > > > > > > > preferred for the lower latency. > > > > > > > > > > > > > > > Ok, it the state is ENQ, then we can disable the FD hw by controlling > > > > > > > the registers. > > > > > > > > > > > > > > for example: > > > > > > > writel(0x0, fd->fd_base + FD_HW_ENABLE); > > > > > > > writel(0x0, fd->fd_base + FD_INT_EN); > > > > > > > > > > > > > > > > > > > What's exactly the effect of writing 0 to FD_HW_ENABLE? > > > > > > > > > > > Sorry, my last reply didn't solve the question, > > > > > we should implement a mtk_fd_job_abort() for v4l2_m2m_ops(). > > > > > > > > > > which is able to readl_poll_timeout_atomic() > > > > > and check the HW busy bits in the register FD_INT_EN; > > > > > > > > > > if they are not cleared until timeout, we could handle the last > > > > > processing job. > > > > > Otherwise, the FD irq handler should have handled the last processing > > > > > job and we could continue the stop_streaming(). > > > > > > > > > > For job_abort(): > > > > > static void mtk_fd_job_abort(void *priv) > > > > > { > > > > > struct mtk_fd_ctx *ctx = priv; > > > > > struct mtk_fd_dev *fd = ctx->fd_dev; > > > > > u32 val; > > > > > u32 ret; > > > > > > > > > > ret = readl_poll_timeout_atomic(fd->fd_base + MTK_FD_REG_OFFSET_INT_EN, > > > > > val, > > > > > (val & MTK_FD_HW_BUSY_MASK) == > > > > > MTK_FD_HW_STATE_IS_BUSY, > > > > > USEC_PER_MSEC, MTK_FD_STOP_HW_TIMEOUT); > > > > > > > > Hmm, would it be possible to avoid the busy wait by having a > > > > completion that could be signalled from the interrupt handler? > > > > > > > > Best regards, > > > > Tomasz > > > > > > I suppose that would be wakeup a wait queue in the interrupt handler, > > > the the wait_event_interrupt_timeout() will be used in here and system > > > suspend e.g. mtk_fd_suspend(). > > > > Yes, that should work. > > > > > Or do you suggest to wait_event_interrupt_timeout() every frame in the > > > mtk_fd_ipi_handler()? > > > > Nope, we shouldn't need that. > > > > > I think maybe the readl_poll_timeout_atomic would be good enough. > > > > > > > Not really. Busy waiting should be avoided as much as possible. What's > > the point of entering suspend if you end up burning the power by > > spinning the CPU for some milliseconds? > > > Ok, I see, busy waiting is not a good idea, I will use the wait queue > instead. the job abort will refine as following: > > static void mtk_fd_job_abort(void *priv) > { > struct mtk_fd_ctx *ctx = priv; > struct mtk_fd_dev *fd = ctx->fd_dev; > u32 ret; > > ret = wait_event_interruptible_timeout > (fd->wq, (fd->fd_irq_result & MTK_FD_HW_IRQ_MASK), > usecs_to_jiffies(50000)); > if (ret) > mtk_fd_hw_job_finish(fd, VB2_BUF_STATE_ERROR); > dev_dbg(fd->dev, "%s, ret:%d\n", __func__, ret); > > fd->fd_irq_result = 0; > } > > static struct v4l2_m2m_ops fd_m2m_ops = { > .device_run = mtk_fd_device_run, > .job_abort = mtk_fd_job_abort, I'm not sure we should be using the functon above as the .job_abort callback. It's expected to abort the job, but we're just waiting for it to finish. I think we should just call mtk_fd_job_abort() manually from .stop_streaming. > }; > > and we could use it in suspend. > static int mtk_fd_suspend(struct device *dev) > { > struct mtk_fd_dev *fd = dev_get_drvdata(dev); > > if (pm_runtime_suspended(dev)) > return 0; > > if (fd->fd_stream_count) > mtk_fd_job_abort(fd->ctx); > > /* suspend FD HW */ > writel(0x0, fd->fd_base + MTK_FD_REG_OFFSET_INT_EN); > writel(0x0, fd->fd_base + MTK_FD_REG_OFFSET_HW_ENABLE); > clk_disable_unprepare(fd->fd_clk); > dev_dbg(dev, "%s:disable clock\n", __func__); > > return 0; > } > > static irqreturn_t mtk_fd_irq(int irq, void *data) > { > struct mtk_fd_dev *fd = (struct mtk_fd_dev *)data; > > fd->fd_irq_result = readl(fd->fd_base + MTK_FD_REG_OFFSET_INT_VAL); > wake_up_interruptible(&fd->wq); The wake up should be done at the very end of this function. Otherwise we end up with m2m framework racing with the mtk_fd_hw_job_finish() below. Also, I'd use a completion here rather than an open coded wait and wake-up. The driver could reinit_completion() before queuing a job to the hardware and the IRQ handler would complete(). There would be no need to store the IRQ flags in driver data anymore. > fd->output->number = readl(fd->fd_base + MTK_FD_REG_OFFSET_RESULT); > dev_dbg(fd->dev, "mtk_fd_face_num:%d\n", fd->output->number); > > pm_runtime_put((fd->dev)); > mtk_fd_hw_job_finish(fd, VB2_BUF_STATE_DONE); > return IRQ_HANDLED; > } > > > > > > One more thing, for the mtk_fd_video_device_register() > > > Sorry that I would need to use intermediate variable here since the 80 > > > columns check. > > > > > > function = MEDIA_ENT_F_PROC_VIDEO_STATISTICS; > > > ret = v4l2_m2m_register_media_controller(m2m_dev, vfd, function); > > > > Why not just make it like this: > > > > ret = v4l2_m2m_register_media_controller(m2m_dev, > > MEDIA_ENT_F_PROC_VIDEO_STATISTICS); > > > > The above line is aligned using tabs so that its end is as close to > > the 80 character boundary as possible. > > > I tried but the checkpatch script still gave me a check saying align to > the scope, I will refine as following: > > ret = v4l2_m2m_register_media_controller > (m2m_dev, vfd, MEDIA_ENT_F_PROC_VIDEO_STATISTICS); Please ignore that checkpatch warning, it sometimes gives false positives. The above looks clearly worse and less consistent with kernel coding style than what I suggested. Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel