From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Louis Kuo <louis.kuo@mediatek.com>
Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com,
laurent.pinchart+renesas@ideasonboard.com,
christie.yu@mediatek.com, srv_heupstream@mediatek.com,
Jerry-ch.Chen@mediatek.com, tfiga@chromium.org,
keiichiw@chromium.org, jungo.lin@mediatek.com,
sj.huang@mediatek.com, yuzhao@chromium.org,
hans.verkuil@cisco.com, zwisler@chromium.org,
frederic.chen@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-media@vger.kernel.org
Subject: Re: [RFC PATCH V6 1/3] media: platform: mtk-isp: Add Mediatek sensor interface driver
Date: Sat, 11 Apr 2020 08:16:43 +0800 [thread overview]
Message-ID: <CAAOTY_-=v4ZoPu63kPCUzGKyNFeV6S_=zM4P5_MAkrXB0b5Yew@mail.gmail.com> (raw)
In-Reply-To: <20200410071723.19720-2-louis.kuo@mediatek.com>
Hi, Louis:
Louis Kuo <louis.kuo@mediatek.com> 於 2020年4月10日 週五 下午3:18寫道：
>
> This patch adds Mediatek's sensor interface driver. Sensor interface driver
> is a MIPI-CSI2 host driver, namely, a HW camera interface controller. It
> support a widely adopted, simple, high-speed protocol primarily intended for
> point-to-point image and video transmission between cameras and host
> devices. The mtk-isp directory will contain drivers for multiple IP blocks
> found in Mediatek ISP system. It will include ISP Pass 1 driver, sensor interface
> driver, DIP driver and face detection driver.
>
> Signed-off-by: Louis Kuo <louis.kuo@mediatek.com>
> ---
> drivers/media/platform/Makefile | 1 +
> drivers/media/platform/mtk-isp/Kconfig | 18 +
> drivers/media/platform/mtk-isp/Makefile | 3 +
> .../media/platform/mtk-isp/seninf/Makefile | 5 +
> drivers/media/platform/mtk-isp/seninf/TODO | 18 +
> .../platform/mtk-isp/seninf/mtk_seninf.c | 1173 +++++++++++++
> .../platform/mtk-isp/seninf/mtk_seninf_reg.h | 1491 +++++++++++++++++
> .../mtk-isp/seninf/mtk_seninf_rx_reg.h | 1398 ++++++++++++++++
> 8 files changed, 4107 insertions(+)
> create mode 100644 drivers/media/platform/mtk-isp/Kconfig
> create mode 100644 drivers/media/platform/mtk-isp/Makefile
> create mode 100644 drivers/media/platform/mtk-isp/seninf/Makefile
> create mode 100644 drivers/media/platform/mtk-isp/seninf/TODO
> create mode 100644 drivers/media/platform/mtk-isp/seninf/mtk_seninf.c
> create mode 100644 drivers/media/platform/mtk-isp/seninf/mtk_seninf_reg.h
> create mode 100644 drivers/media/platform/mtk-isp/seninf/mtk_seninf_rx_reg.h
>
[snip]
> +
> +static void mtk_seninf_set_dphy(struct mtk_seninf *priv, unsigned int seninf)
> +{
> + void __iomem *pmipi_rx_base = priv->csi2_rx[CFG_CSI_PORT_0];
> + unsigned int port = priv->port;
> + void __iomem *pmipi_rx = priv->csi2_rx[port];
> + void __iomem *pmipi_rx_conf = priv->base + 0x1000 * seninf;
> +
> + /* Set analog phy mode to DPHY */
> + if (is_cdphy_combo(port))
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A, RG_CSI0A_CPHY_EN, 0);
> + /* 4D1C: MIPIRX_ANALOG_A_BASE = 0x00001A42 */
> + if (is_4d1c(port)) {
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L0_CKMODE_EN, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L0_CKSEL, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L1_CKMODE_EN, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L1_CKSEL, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L2_CKMODE_EN, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L2_CKSEL, 1);
> + } else {/* MIPIRX_ANALOG_BASE = 0x102 */
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L0_CKMODE_EN, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L0_CKSEL, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L1_CKMODE_EN, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L1_CKSEL, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L2_CKMODE_EN, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_DPHY_L2_CKSEL, 0);
> + }
> + if (is_cdphy_combo(port))
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B, RG_CSI0B_CPHY_EN, 0);
> +
> + /* Only 4d1c need set CSIB: MIPIRX_ANALOG_B_BASE = 0x00001242 */
> + if (is_4d1c(port)) {
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L0_CKMODE_EN, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L0_CKSEL, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L1_CKMODE_EN, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L1_CKSEL, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L2_CKMODE_EN, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L2_CKSEL, 1);
> + } else {/* MIPIRX_ANALOG_BASE = 0x102 */
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L0_CKSEL, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L1_CKMODE_EN, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L1_CKSEL, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L2_CKMODE_EN, 0);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_DPHY_L2_CKSEL, 0);
> + }
> + /* Byte clock invert */
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANAA8_CSI0A,
> + RG_CSI0A_CDPHY_L0_T0_BYTECK_INVERT, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANAA8_CSI0A,
> + RG_CSI0A_DPHY_L1_BYTECK_INVERT, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANAA8_CSI0A,
> + RG_CSI0A_CDPHY_L2_T1_BYTECK_INVERT, 1);
> +
> + if (is_4d1c(port)) {
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANAA8_CSI0B,
> + RG_CSI0B_CDPHY_L0_T0_BYTECK_INVERT, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANAA8_CSI0B,
> + RG_CSI0B_DPHY_L1_BYTECK_INVERT, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANAA8_CSI0B,
> + RG_CSI0B_CDPHY_L2_T1_BYTECK_INVERT, 1);
> + }
> +
> + /* Start ANA EQ tuning */
> + if (is_cdphy_combo(port)) {
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI0A,
> + RG_CSI0A_L0_T0AB_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI0A,
> + RG_CSI0A_L0_T0AB_EQ_BW, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA1C_CSI0A,
> + RG_CSI0A_L1_T1AB_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA1C_CSI0A,
> + RG_CSI0A_L1_T1AB_EQ_BW, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA20_CSI0A,
> + RG_CSI0A_L2_T1BC_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA20_CSI0A,
> + RG_CSI0A_L2_T1BC_EQ_BW, 1);
> +
> + if (is_4d1c(port)) { /* 4d1c */
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI0B,
> + RG_CSI0B_L0_T0AB_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI0B,
> + RG_CSI0B_L0_T0AB_EQ_BW, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA1C_CSI0B,
> + RG_CSI0B_L1_T1AB_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA1C_CSI0B,
> + RG_CSI0B_L1_T1AB_EQ_BW, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA20_CSI0B,
> + RG_CSI0B_L2_T1BC_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA20_CSI0B,
> + RG_CSI0B_L2_T1BC_EQ_BW, 1);
> + }
> + } else {
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI1A,
> + RG_CSI1A_L0_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI1A,
> + RG_CSI1A_L0_EQ_BW, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI1A,
> + RG_CSI1A_L1_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI1A,
> + RG_CSI1A_L1_EQ_BW, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA1C_CSI1A,
> + RG_CSI1A_L2_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA1C_CSI1A,
> + RG_CSI1A_L2_EQ_BW, 1);
> +
> + if (is_4d1c(port)) { /* 4d1c */
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI1B,
> + RG_CSI1B_L0_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI1B,
> + RG_CSI1B_L0_EQ_BW, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI1B,
> + RG_CSI1B_L1_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA18_CSI1B,
> + RG_CSI1B_L1_EQ_BW, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA1C_CSI1B,
> + RG_CSI1B_L2_EQ_IS, 1);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA1C_CSI1B,
> + RG_CSI1B_L2_EQ_BW, 1);
> + }
> + }
> +
> + /* End ANA EQ tuning */
> + writel(0x90, pmipi_rx_base + MIPI_RX_ANA40_CSI0A);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA24_CSI0A,
> + RG_CSI0A_RESERVE, 0x40);
> + if (is_4d1c(port))
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA24_CSI0B,
> + RG_CSI0B_RESERVE, 0x40);
> + SENINF_BITS(pmipi_rx, MIPI_RX_WRAPPER80_CSI0A,
> + CSR_CSI_RST_MODE, 0);
> + if (is_4d1c(port))
> + SENINF_BITS(pmipi_rx, MIPI_RX_WRAPPER80_CSI0B,
> + CSR_CSI_RST_MODE, 0);
> + /* ANA power on */
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_BG_CORE_EN, 1);
> + if (is_4d1c(port))
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_BG_CORE_EN, 1);
> + usleep_range(20, 40);
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0A,
> + RG_CSI0A_BG_LPF_EN, 1);
> + if (is_4d1c(port))
> + SENINF_BITS(pmipi_rx, MIPI_RX_ANA00_CSI0B,
> + RG_CSI0B_BG_LPF_EN, 1);
> +
> + udelay(1);
> + /* 4d1c: MIPIRX_CONFIG_CSI_BASE = 0xC9000000; */
> + if (is_4d1c(port)) {
> + SENINF_BITS(pmipi_rx_conf, MIPI_RX_CON24_CSI0,
> + CSI0_BIST_LN0_MUX, 1);
> + SENINF_BITS(pmipi_rx_conf, MIPI_RX_CON24_CSI0,
> + CSI0_BIST_LN1_MUX, 2);
> + SENINF_BITS(pmipi_rx_conf, MIPI_RX_CON24_CSI0,
> + CSI0_BIST_LN2_MUX, 0);
> + SENINF_BITS(pmipi_rx_conf, MIPI_RX_CON24_CSI0,
> + CSI0_BIST_LN3_MUX, 3);
> + } else { /* 2d1c: MIPIRX_CONFIG_CSI_BASE = 0xE4000000; */
> + SENINF_BITS(pmipi_rx_conf, MIPI_RX_CON24_CSI0,
> + CSI0_BIST_LN0_MUX, 0);
> + SENINF_BITS(pmipi_rx_conf, MIPI_RX_CON24_CSI0,
> + CSI0_BIST_LN1_MUX, 1);
> + SENINF_BITS(pmipi_rx_conf, MIPI_RX_CON24_CSI0,
> + CSI0_BIST_LN2_MUX, 2);
> + SENINF_BITS(pmipi_rx_conf, MIPI_RX_CON24_CSI0,
> + CSI0_BIST_LN3_MUX, 3);
> + }
> +}
I think the phy control part should be placed in
drivers/phy/mediatek/. In [1], device csis point to a device mipi_phy.
csis' driver is in [2], and mipi_phy's driver is in [3]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4.dtsi?h=v5.6
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/platform/exynos4-is/mipi-csis.c?h=v5.6
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/samsung/phy-exynos-mipi-video.c?h=v5.6
Regards,
Chun-Kuang.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-11 0:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 7:17 [RFC PATCH V6 0/3] media: support Mediatek sensor interface driver Louis Kuo
2020-04-10 7:17 ` [RFC PATCH V6 2/3] dt-bindings: mt8183: Add sensor interface dt-bindings Louis Kuo
2020-04-20 18:43 ` Rob Herring
2020-04-10 7:17 ` [RFC PATCH V6 3/3] dts: arm64: mt8183: Add sensor interface nodes Louis Kuo
[not found] ` <20200410071723.19720-2-louis.kuo@mediatek.com>
2020-04-11 0:16 ` Chun-Kuang Hu [this message]
[not found] ` <d6776ac432794cb593c4db54b8a7a089@mtkmbs02n2.mediatek.inc>
2020-04-13 9:27 ` [RFC PATCH V6 1/3] media: platform: mtk-isp: Add Mediatek sensor interface driver Chun-Kuang Hu
2020-04-13 20:45 ` Helen Koike
2020-04-11 10:25 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAOTY_-=v4ZoPu63kPCUzGKyNFeV6S_=zM4P5_MAkrXB0b5Yew@mail.gmail.com' \
--to=chunkuang.hu@kernel.org \
--cc=Jerry-ch.Chen@mediatek.com \
--cc=Sean.Cheng@mediatek.com \
--cc=christie.yu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frederic.chen@mediatek.com \
--cc=hans.verkuil@cisco.com \
--cc=jungo.lin@mediatek.com \
--cc=keiichiw@chromium.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=yuzhao@chromium.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).