From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Anand K Mistry <amistry@chromium.org>
Cc: Anand K Mistry <amistry@google.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
CK Hu <ck.hu@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0
Date: Sun, 26 Apr 2020 16:03:53 +0800 [thread overview]
Message-ID: <CAAOTY_81qB+WJN_2-ZNqM63NOp+Es1qEmsp2qje2bfePg1O5Vw@mail.gmail.com> (raw)
In-Reply-To: <20200420060834.44461-1-amistry@google.com>
Hi, Anand:
Anand K Mistry <amistry@chromium.org> 於 2020年4月20日 週一 下午2:09寫道：
>
> If dma_map_sg() merges pages when creating the mapping, only the first
> entries will have a valid sg_dma_address() and sg_dma_len(), followed by
> entries with sg_dma_len() == 0.
>
> Signed-off-by: Anand K Mistry <amistry@google.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index b04a3c2b111e09..f8fd8b98c30e3d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -224,6 +224,9 @@ struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev,
>
> expected = sg_dma_address(sg->sgl);
> for_each_sg(sg->sgl, s, sg->nents, i) {
> + if (!sg_dma_len(s))
> + break;
I think this should be 'continue'
Regards,
Chun-Kuang.
> +
> if (sg_dma_address(s) != expected) {
> DRM_ERROR("sg_table is not contiguous");
> ret = -EINVAL;
> --
> 2.26.1.301.g55bc3eb7cb9-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-26 8:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 6:08 [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0 Anand K Mistry
2020-04-26 8:03 ` Chun-Kuang Hu [this message]
2020-04-28 1:54 ` Anand K. Mistry
2020-04-28 16:37 ` Chun-Kuang Hu
2020-05-06 0:25 ` Chun-Kuang Hu
2020-05-06 11:03 ` Anand Mistry
2020-05-06 12:58 ` Chun-Kuang Hu
2020-05-07 12:04 ` Anand Mistry
[not found] ` <CAECpkiO9P1+GpQi+aH_B2B8d5Bsba5XJnUKJDfL-kZk455Edcg@mail.gmail.com>
2020-05-09 13:38 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAOTY_81qB+WJN_2-ZNqM63NOp+Es1qEmsp2qje2bfePg1O5Vw@mail.gmail.com \
--to=chunkuang.hu@kernel.org \
--cc=amistry@chromium.org \
--cc=amistry@google.com \
--cc=ck.hu@mediatek.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).