Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

[Chun-Kuang Hu <chunkuang.hu@kernel.org>]

Hi, Frank:

Frank Wunderlich <frank-w@public-files.de> 於 2020年7月28日 週二 下午7:18寫道：
>
> From: Bibby Hsieh <bibby.hsieh@mediatek.com>
>
> We can select output component by decive node port.
> Main path default output component is DSI.
> External path default output component is DPI.
>
> without this Patch i get this warning:
>
> WARNING: CPU: 3 PID: 70 at drivers/gpu/drm/drm_mode_config.c:621 drm_mode_config_validate+0x1d8/0x258
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
>
> added small fixes for warnings
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Tested-by: Frank Wunderlich <frank-w@public-files.de>
> ---

[snip]

>
> -static const enum mtk_ddp_comp_id mt8173_mtk_ddp_ext[] = {
> +static enum mtk_ddp_comp_id mt8173_mtk_ddp_ext[] = {
>         DDP_COMPONENT_OVL1,
>         DDP_COMPONENT_COLOR1,
>         DDP_COMPONENT_GAMMA,
> @@ -459,6 +466,7 @@ static int mtk_drm_probe(struct platform_device *pdev)
>
>         /* Iterate over sibling DISP function blocks */
>         for_each_child_of_node(phandle->parent, node) {
> +               struct device_node *port, *ep, *remote;
>                 const struct of_device_id *of_id;
>                 enum mtk_ddp_comp_type comp_type;
>                 int comp_id;
> @@ -522,6 +530,32 @@ static int mtk_drm_probe(struct platform_device *pdev)
>
>                         private->ddp_comp[comp_id] = comp;
>                 }
> +
> +               if (comp_type != MTK_DSI && comp_type != MTK_DPI) {
> +                       port = of_graph_get_port_by_id(node, 0);
> +                       if (!port)
> +                               continue;
> +                       ep = of_get_child_by_name(port, "endpoint");
> +                       of_node_put(port);
> +                       if (!ep)
> +                               continue;
> +                       remote = of_graph_get_remote_port_parent(ep);
> +                       of_node_put(ep);
> +                       if (!remote)
> +                               continue;
> +                       of_id = of_match_node(mtk_ddp_comp_dt_ids, remote);
> +                       if (!of_id)
> +                               continue;
> +                       comp_type = (enum mtk_ddp_comp_type)of_id->data;
> +                       for (i = 0; i < private->data->main_len - 1; i++)
> +                               if (private->data->main_path[i] == comp_id)
> +                                       private->data->main_path[i + 1] =
> +                                       mtk_ddp_comp_get_id(node, comp_type);
> +                       for (i = 0; i < private->data->ext_len - 1; i++)
> +                               if (private->data->ext_path[i] == comp_id)
> +                                       private->data->ext_path[i + 1] =
> +                                       mtk_ddp_comp_get_id(node, comp_type);
> +               }

The port property is not defined in binding document [1], so define it
in binding document first.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt?h=v5.8-rc7

Regards,
Chun-Kuang.

>         }
>
>         if (!private->mutex_node) {
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.h b/drivers/gpu/drm/mediatek/mtk_drm_drv.h
> index b5be63e53176..7fcaab648bf1 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.h
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.h
> @@ -21,9 +21,9 @@ struct drm_property;
>  struct regmap;
>
>  struct mtk_mmsys_driver_data {
> -       const enum mtk_ddp_comp_id *main_path;
> +       enum mtk_ddp_comp_id *main_path;
>         unsigned int main_len;
> -       const enum mtk_ddp_comp_id *ext_path;
> +       enum mtk_ddp_comp_id *ext_path;
>         unsigned int ext_len;
>         const enum mtk_ddp_comp_id *third_path;
>         unsigned int third_len;
> --
> 2.25.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel