From: Ikjoon Jang <ikjn@chromium.org>
To: Weiyi Lu <weiyi.lu@mediatek.com>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
Stephen Boyd <sboyd@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-clk@vger.kernel.org,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 08/22] clk: mediatek: Add configurable enable control to mtk_pll_data
Date: Wed, 6 Jan 2021 18:37:59 +0800 [thread overview]
Message-ID: <CAATdQgBvd_izVUZ7NiDeHzZsQ4rL0=3LZ04diO7HQXop5rxYsw@mail.gmail.com> (raw)
In-Reply-To: <1608642587-15634-9-git-send-email-weiyi.lu@mediatek.com>
On Tue, Dec 22, 2020 at 9:11 PM Weiyi Lu <weiyi.lu@mediatek.com> wrote:
>
> In all MediaTek PLL design, bit0 of CON0 register is always
> the enable bit.
> However, there's a special case of usbpll on MT8192.
> The enable bit of usbpll is moved to bit2 of other register.
> Add configurable en_reg and pll_en_bit for enable control or
> default 0 where pll data are static variables.
> Hence, CON0_BASE_EN could also be removed.
> And there might have another special case on other chips,
> the enable bit is still on CON0 register but not at bit0.
>
> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
Reviewed-by: Ikjoon Jang <ikjn@chromium.org>
> ---
> drivers/clk/mediatek/clk-mtk.h | 2 ++
> drivers/clk/mediatek/clk-pll.c | 15 ++++++++++-----
> 2 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mtk.h
> index c3d6756..c580663 100644
> --- a/drivers/clk/mediatek/clk-mtk.h
> +++ b/drivers/clk/mediatek/clk-mtk.h
> @@ -233,6 +233,8 @@ struct mtk_pll_data {
> uint32_t pcw_chg_reg;
> const struct mtk_pll_div_table *div_table;
> const char *parent_name;
> + uint32_t en_reg;
> + uint8_t pll_en_bit; /* Assume 0, indicates BIT(0) by default */
> };
>
> void mtk_clk_register_plls(struct device_node *node,
> diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c
> index 11ed5d1..7fb001a 100644
> --- a/drivers/clk/mediatek/clk-pll.c
> +++ b/drivers/clk/mediatek/clk-pll.c
> @@ -44,6 +44,7 @@ struct mtk_clk_pll {
> void __iomem *tuner_en_addr;
> void __iomem *pcw_addr;
> void __iomem *pcw_chg_addr;
> + void __iomem *en_addr;
> const struct mtk_pll_data *data;
> };
>
> @@ -56,7 +57,7 @@ static int mtk_pll_is_prepared(struct clk_hw *hw)
> {
> struct mtk_clk_pll *pll = to_mtk_clk_pll(hw);
>
> - return (readl(pll->base_addr + REG_CON0) & CON0_BASE_EN) != 0;
> + return (readl(pll->en_addr) & BIT(pll->data->pll_en_bit)) != 0;
> }
>
> static unsigned long __mtk_pll_recalc_rate(struct mtk_clk_pll *pll, u32 fin,
> @@ -248,8 +249,8 @@ static int mtk_pll_prepare(struct clk_hw *hw)
> writel(r, pll->pwr_addr);
> udelay(1);
>
> - r = readl(pll->base_addr + REG_CON0) | CON0_BASE_EN;
> - writel(r, pll->base_addr + REG_CON0);
> + r = readl(pll->en_addr) | BIT(pll->data->pll_en_bit);
> + writel(r, pll->en_addr);
>
> div_en_mask = pll->data->en_mask & ~CON0_BASE_EN;
> if (div_en_mask) {
> @@ -290,8 +291,8 @@ static void mtk_pll_unprepare(struct clk_hw *hw)
> writel(r, pll->base_addr + REG_CON0);
> }
>
> - r = readl(pll->base_addr + REG_CON0) & ~CON0_BASE_EN;
> - writel(r, pll->base_addr + REG_CON0);
> + r = readl(pll->en_addr) & ~BIT(pll->data->pll_en_bit);
> + writel(r, pll->en_addr);
>
> r = readl(pll->pwr_addr) | CON0_ISO_EN;
> writel(r, pll->pwr_addr);
> @@ -333,6 +334,10 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data,
> pll->tuner_addr = base + data->tuner_reg;
> if (data->tuner_en_reg)
> pll->tuner_en_addr = base + data->tuner_en_reg;
> + if (data->en_reg)
> + pll->en_addr = base + data->en_reg;
> + else
> + pll->en_addr = pll->base_addr + REG_CON0;
> pll->hw.init = &init;
> pll->data = data;
>
> --
> 1.8.1.1.dirty
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-06 10:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 13:09 [PATCH v6 00/22] Mediatek MT8192 clock support Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 01/22] dt-bindings: ARM: Mediatek: Add new document bindings of imp i2c wrapper controller Weiyi Lu
2021-02-10 12:19 ` Matthias Brugger
2021-02-18 1:40 ` Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 02/22] dt-bindings: ARM: Mediatek: Add new document bindings of mdpsys controller Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 03/22] dt-bindings: ARM: Mediatek: Add new document bindings of msdc controller Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 04/22] dt-bindings: ARM: Mediatek: Add new document bindings of scp adsp controller Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 05/22] dt-bindings: ARM: Mediatek: Document bindings of MT8192 clock controllers Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 06/22] clk: mediatek: Add dt-bindings of MT8192 clocks Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 07/22] clk: mediatek: Fix asymmetrical PLL enable and disable control Weiyi Lu
2021-01-06 10:35 ` Ikjoon Jang
2020-12-22 13:09 ` [PATCH v6 08/22] clk: mediatek: Add configurable enable control to mtk_pll_data Weiyi Lu
2021-01-06 10:37 ` Ikjoon Jang [this message]
2020-12-22 13:09 ` [PATCH v6 09/22] clk: mediatek: Add mtk_clk_simple_probe() to simplify clock providers Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 10/22] clk: mediatek: Add MT8192 basic clocks support Weiyi Lu
2021-01-06 10:25 ` Ikjoon Jang
2021-01-06 10:42 ` Weiyi Lu
2021-02-10 12:46 ` Matthias Brugger
2021-02-18 1:59 ` Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 11/22] clk: mediatek: Add MT8192 audio clock support Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 12/22] clk: mediatek: Add MT8192 camsys " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 13/22] clk: mediatek: Add MT8192 imgsys " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 14/22] clk: mediatek: Add MT8192 imp i2c wrapper " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 15/22] clk: mediatek: Add MT8192 ipesys " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 16/22] clk: mediatek: Add MT8192 mdpsys " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 17/22] clk: mediatek: Add MT8192 mfgcfg " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 18/22] clk: mediatek: Add MT8192 mmsys " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 19/22] clk: mediatek: Add MT8192 msdc " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 20/22] clk: mediatek: Add MT8192 scp adsp " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 21/22] clk: mediatek: Add MT8192 vdecsys " Weiyi Lu
2020-12-22 13:09 ` [PATCH v6 22/22] clk: mediatek: Add MT8192 vencsys " Weiyi Lu
2021-01-13 7:18 ` [PATCH v6 00/22] Mediatek MT8192 " James Liao
2021-02-09 1:00 ` Stephen Boyd
2021-02-18 1:25 ` Weiyi Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATdQgBvd_izVUZ7NiDeHzZsQ4rL0=3LZ04diO7HQXop5rxYsw@mail.gmail.com' \
--to=ikjn@chromium.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sboyd@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).