From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board
Date: Sun, 9 Aug 2020 20:49:34 +0200 [thread overview]
Message-ID: <CAAdtpL7+_inNrbDpq_wt1Eo=tU6+e+yYR9ox-BF7bN82HVV5_Q@mail.gmail.com> (raw)
In-Reply-To: <20200807100411.2904279-4-noltari@gmail.com>
Hi Álvaro,
On Fri, Aug 7, 2020 at 12:05 PM Álvaro Fernández Rojas
<noltari@gmail.com> wrote:
>
> EHCI and OHCI share the same USB ports. Therefore, if the board has OHCI
> it should also have EHCI.
This statement isn't correct. OHCI doesn't imply EHCI...
(although the opposite is almost always true).
Now per 6358-PB01-R the bcm6358 indeed has a EHCI controller.
Do you mind rewording the commit description?
Regards,
Phil.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> v2: no changes.
>
> arch/mips/bcm63xx/boards/board_bcm963xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/bcm63xx/boards/board_bcm963xx.c b/arch/mips/bcm63xx/boards/board_bcm963xx.c
> index 45f1bc437245..ac9570b66f37 100644
> --- a/arch/mips/bcm63xx/boards/board_bcm963xx.c
> +++ b/arch/mips/bcm63xx/boards/board_bcm963xx.c
> @@ -645,6 +645,7 @@ static struct board_info __initdata board_DWVS0 = {
> },
>
> .has_ohci0 = 1,
> + .has_ehci0 = 1,
> };
> #endif /* CONFIG_BCM63XX_CPU_6358 */
>
> --
> 2.27.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-09 18:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 10:04 [PATCH v2 0/4] MIPS: BCM63xx: board improvements Álvaro Fernández Rojas
2020-08-07 10:04 ` [PATCH v2 1/4] MIPS: BCM63xx: remove duplicated new lines Álvaro Fernández Rojas
2020-08-07 18:19 ` Florian Fainelli
2020-08-09 18:40 ` Philippe Mathieu-Daudé
2020-08-07 10:04 ` [PATCH v2 2/4] MIPS: BCM63xx: remove EHCI from BCM6348 boards Álvaro Fernández Rojas
2020-08-07 18:30 ` Florian Fainelli
2020-08-07 10:04 ` [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board Álvaro Fernández Rojas
2020-08-07 18:30 ` Florian Fainelli
2020-08-09 18:49 ` Philippe Mathieu-Daudé [this message]
2020-08-11 2:33 ` Florian Fainelli
2020-08-11 9:09 ` Philippe Mathieu-Daudé
2020-08-07 10:04 ` [PATCH v2 4/4] MIPS: BCM63xx: refactor board declarations Álvaro Fernández Rojas
2020-08-07 18:31 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdtpL7+_inNrbDpq_wt1Eo=tU6+e+yYR9ox-BF7bN82HVV5_Q@mail.gmail.com' \
--to=f4bug@amsat.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).