From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39272C00A89 for ; Fri, 30 Oct 2020 16:35:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA65920727 for ; Fri, 30 Oct 2020 16:35:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FdA/BaNR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="niyYm0qY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA65920727 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O4s7vgioxIOtrtIEqJMNqEAMFGvnKoHlsQF0/6YfkeU=; b=FdA/BaNRmXCjSq2ObrYX3v3RI /IJEtjiMBiRD3Qfq29fSGsanXN+SKUVzws5MACA0PkW9HjfIs0+EwapQiEbUZj3gE7L3DBRZx5Dqy y3DogAzhImA/fki2Kwv1rNNebbTSAi2ZlBmLsATmdj7cq1NBmRQgZ9k7DEWTeSY8dsPj821W0Yin8 vf5De6LmqWb3BVE6oPxjivbtMT4ohG566icInI5+XZ1EKdFZfLdnY09s7iaTBUqDQb4Q80VT9MFg+ 0GlAVbpn+DyPtmWmxe/VB8KM4AOo68fNIexFWh3oqsw/6wOXnKZa2JFIdnAjSuoWH9UrtEne2XsBk XUfpq30Ow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYXMy-0003OZ-FD; Fri, 30 Oct 2020 16:35:16 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYXMv-0003Lf-Go for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2020 16:35:14 +0000 Received: by mail-pf1-x442.google.com with SMTP id 10so5760109pfp.5 for ; Fri, 30 Oct 2020 09:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OEG72fK9A86Aj1ReEdXuRoNmABKVsj8ImdviwWVYFfY=; b=niyYm0qY8CzMDjQFR0wk09rUFovgBIJqmkwyaohlBE8Xuf8D7EO7pmDLYAO52Q4Yvf 82ZicSGjt6o0IgPJp09nq6DevXQ3+b0pAc6z3ZqEeQ0GHi8yBJqz7ty1e2sfPbG4sRz0 1cOaAbENqXkyChFeCj5oGwedqUrwkqIaA9N4iN672mYgSp7HTiftJKBg2bOrWNpBz5lk +nGWSc2U2T0NPgIVEdW7PNQfTxFEhRqbbQXWLZf9txYposExkV0K1+kTiiGfuaJoxMC1 eIkI2PvlQzLqzG2m5l2vTTq9uk9P+OGmAemu02kGvkUJyLwA/lOZsJ8GWC0Bf3jSpdGa AE5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OEG72fK9A86Aj1ReEdXuRoNmABKVsj8ImdviwWVYFfY=; b=Kv5EzBjkwec7Tf2qxOUiEXaoaWxCC4QThF336G53YrUhHLrz9YINBTAkz+D0pbS258 marF0pOUU0o5iSP6ANu/CaWUKSjDEkw+FC7D+wr7uBBdXqT69Lw5AVYn8QpvDpOU0vkM O9/ClKoULnbGE3OIw9HPeiuEvEuRdkkd6tAk7mVYIou1xWgRihATZI2nOfaVgl3U6kFf BbTCGXwf9mQsqH0Qtw0uAzEeABzrXDWmQChDZgX9tPIkAxAreVBwCNlfiNff/m0L8km8 FeeiflFMJoADtsj2y2DffNmMJqXkyOGb1qedLV6LYtJvUC5Eo1c7SqX+AJebRbkK+S6s LHGw== X-Gm-Message-State: AOAM531icA6K06ABDelkTYn07J08QXQlTYQzKKz8Yne1u2Wy+byaKc0w VMvIXtM/4cdOXpoYVHo/oKE3qvfKqsw0CrRhDgj/kA== X-Google-Smtp-Source: ABdhPJypb5pDbULIOedvBhhhhPVQ4Wd1RYf+aGclJw2Xgj+SjC3Hpi43QPbQ/asszFlJWnfh3RXkLp7IystdA99AI/E= X-Received: by 2002:a63:d456:: with SMTP id i22mr2896479pgj.440.1604075707465; Fri, 30 Oct 2020 09:35:07 -0700 (PDT) MIME-Version: 1.0 References: <6f87cb86aeeca9f4148d435ff01ad7d21af4bdfc.1603372719.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Fri, 30 Oct 2020 17:34:56 +0100 Message-ID: Subject: Re: [PATCH RFC v2 12/21] kasan: inline and rename kasan_unpoison_memory To: Dmitry Vyukov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201030_123513_608305_F17003BD X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marco Elver , Elena Petrova , Linux-MM , Catalin Marinas , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Kostya Serebryany , Alexander Potapenko , Linux ARM , Serban Constantinescu , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Peter Collingbourne , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 28, 2020 at 12:36 PM Dmitry Vyukov wrote: > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > > > Currently kasan_unpoison_memory() is used as both an external annotation > > and as internal memory poisoning helper. Rename external annotation to > > kasan_unpoison_data() and inline the internal helper for for hardware > > tag-based mode to avoid undeeded function calls. > > > > There's the external annotation kasan_unpoison_slab() that is currently > > defined as static inline and uses kasan_unpoison_memory(). With this > > change it's turned into a function call. Overall, this results in the > > same number of calls for hardware tag-based mode as > > kasan_unpoison_memory() is now inlined. > > Can't we leave kasan_unpoison_slab as is? Or there are other reasons > to uninline it? Just to have cleaner kasan.h callbacks definitions. > It seems that uninling it is orthogonal to the rest of this patch. I can split it out into a separate patch if you think this makes sense? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel