From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4FB8C2D0A3 for ; Thu, 29 Oct 2020 20:16:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19A9F206FA for ; Thu, 29 Oct 2020 20:16:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s0VbrO1P"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="ds1NXPTL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19A9F206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dsZ2p1UoOrgCcLVOb6Hd1G7EZWHCfsiad2zbu3b+Xt8=; b=s0VbrO1PiwjkLcP+2YyDXqRS3 zmxi5pERA/8ZSqLcHlRW1lglxjEtgCIuQOaJpZlGapoyfY6r0LdITjUmdl0YsXjrv7sSXA9YAVsvp Qc3BWVHh4fntP9TWTt9aCO4egoDt2xxG4BCugaXldgHhe2SBUX43ENSjlPa148dgIS6e2BrBV80NV 9GG6EuZhGndyxiThkFSmo+1p5om4Q3bfOEloYogC1Tps6zxplCo27RMExj8EEr89KP9VUTXA/VxdR syNQBQ0d+JjSr/CjvcOWQVshDu+jT/3FMjHEpWS3d7IV/Sio9HLoppKfqnjeD3DLABhxMF14ysIzR 8dNnU/ODA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYEJZ-0005VR-I2; Thu, 29 Oct 2020 20:14:29 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYEJV-0005Tr-Im for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 20:14:26 +0000 Received: by mail-pf1-x442.google.com with SMTP id e15so3295413pfh.6 for ; Thu, 29 Oct 2020 13:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l77n7oC/IyxQLfCBGbQpiCRFFdLcSomb1vOdKMROYRs=; b=ds1NXPTLGAXIZvjdJi8ugrSM70FcHWuCIwYhaH9mhI0HA2QijV79tt6Un83nE1oEtt r7Y+dzoiRxdMlrHyTfcqQgImddaXj3XlqhWWqsGwcu2xttvbypodQ1yJ26YGBEA+aWJP mQVxPDIZ7xqLXmW0cU4LeyBmE5rqJ3Qsjglgq/rJdcwLdvHOMRLoRB9p7k0aJqp8svWb OngF2h0IigTb1bVv+YWfkgUqjB+yFO3CJ20NB1RewecioLbCJiogpIK/WlBmbXLKzkS/ dtLY/IYCtE5jowS4o6YN5IOIJWOUNzK8/oVJfM8zhr8DkB6vxsF6wOITqqPRSAUzKKT3 3hsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l77n7oC/IyxQLfCBGbQpiCRFFdLcSomb1vOdKMROYRs=; b=sDh/1JRVGTHEjREtBcH7wIqsQRqDGgZ7pUKYS7amEtSBSCmitqXARymgSkl0/tBl3n 7lvhw0/oknLDNkH/jLgaBELNC2ZynZAekesjCZKq2lc/Nl4cJ48f6ovklbgFWGkcATQ+ c0j4nGRUmog+jHM2/RkPfa/Hf4TDvRfPsuSjr9YI6H5eeAGIz1dtFb/H35URTFjv7Wgg KdV3rxCyiKkXRdj2NMSFwJctEv8snEj6sscwSFwAU4nr8VBcBcdIMEMWQmtdspJhSSSg xFw3o93rpaX6kjbe0IpBcTvkjYDhsFKVSXEYKoiSEDW4deaTTzvZ3KwHNZHNKu171d7E ildQ== X-Gm-Message-State: AOAM530Shl5dbxu5whQbv+b62aohoRi/bBlwv0Fo4yKQXLc2pvmupgwP loN4uli8xAuFN4sTzb9lukvIzcdq0++UPfWxEKaFwQ== X-Google-Smtp-Source: ABdhPJx9GJFDbjQtalHbXpz4QpT9HD1QKsnubeBrC4C75nQUTCYmo2axiD2dLWceppBeCeuRufluBFF+z94cSUugzCc= X-Received: by 2002:a17:90a:cb92:: with SMTP id a18mr1508972pju.136.1604002463411; Thu, 29 Oct 2020 13:14:23 -0700 (PDT) MIME-Version: 1.0 References: <1d87f0d5a282d9e8d14d408ac6d63462129f524c.1603372719.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 29 Oct 2020 21:14:12 +0100 Message-ID: Subject: Re: [PATCH RFC v2 07/21] kasan, arm64: move initialization message To: Dmitry Vyukov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_161425_651025_6B66872C X-CRM114-Status: GOOD ( 25.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marco Elver , Elena Petrova , Linux-MM , Catalin Marinas , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Kostya Serebryany , Alexander Potapenko , Linux ARM , Serban Constantinescu , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Peter Collingbourne , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 28, 2020 at 11:56 AM Dmitry Vyukov wrote: > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > > > Tag-based KASAN modes are fully initialized with kasan_init_tags(), > > while the generic mode only requireds kasan_init(). Move the > > initialization message for tag-based modes into kasan_init_tags(). > > > > Also fix pr_fmt() usage for KASAN code: generic mode doesn't need it, > > Why doesn't it need it? What's the difference with tag modes? I need to reword the patch descriptions: it's not the mode that doesn't need it, it's the generic.c file, as it doesn't use any pr_*() functions. > > > tag-based modes should use "kasan:" instead of KBUILD_MODNAME. > > With generic KASAN I currently see: > > [ 0.571473][ T0] kasan: KernelAddressSanitizer initialized > > So KBUILD_MODNAME somehow works. Is there some difference between files? That code is printed from arch/xxx/mm/kasan_init*.c, which has its own pr_fmt defined. > > > Signed-off-by: Andrey Konovalov > > Link: https://linux-review.googlesource.com/id/Idfd1e50625ffdf42dfc3dbf7455b11bd200a0a49 > > --- > > arch/arm64/mm/kasan_init.c | 3 +++ > > mm/kasan/generic.c | 2 -- > > mm/kasan/hw_tags.c | 4 ++++ > > mm/kasan/sw_tags.c | 4 +++- > > 4 files changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > > index b6b9d55bb72e..8f17fa834b62 100644 > > --- a/arch/arm64/mm/kasan_init.c > > +++ b/arch/arm64/mm/kasan_init.c > > @@ -290,5 +290,8 @@ void __init kasan_init(void) > > { > > kasan_init_shadow(); > > kasan_init_depth(); > > +#if defined(CONFIG_KASAN_GENERIC) > > + /* CONFIG_KASAN_SW/HW_TAGS also requires kasan_init_tags(). */ > > A bit cleaner way may be to introduce kasan_init_early() and > kasan_init_late(). Late() will do tag init and always print the > message. It appears we'll also need kasan_init_even_later() for some MTE-related stuff. I'll try to figure out some sane naming scheme here and include it into the next version. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel