From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D696EC2D0E4 for ; Mon, 23 Nov 2020 18:21:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BF3820BED for ; Mon, 23 Nov 2020 18:21:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TO0UqOeI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="s+K6c+/1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BF3820BED Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JbgL/OoiSvDYl0omTPiWJry83A3MZHRWjRcxxyV4syo=; b=TO0UqOeIIWPdomp0fj3X1ahfW pHCWK8tAjacAVipcMTd+I6Ki4OHhwH0m+ZTOOoO45zKo4GwueSk8Q1MOfXxEB4BF8Tqqk5VPC2Ahw kmPf6+z1/lAHLRezfSDVVSoXFFefis+BpwZOdhYKC3IeDdp6vB78zPPy+evnuwYyX+sgPFwFxnRoc lHGPZylLiJr6gZFl2+hoAc5WdR52VY61qRabKvMEQCFcp8C/z5w7F27zcParP/bR6OzrIoGygNmfY RY1Okpx2NzKZSfgpp47NDSpVXn0DzyH86FesJk77qYpM+TnYvmVwTBVkKgj2CkNop2ps6cG7dPbRV khOnGSqnw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khGSY-0002eS-K6; Mon, 23 Nov 2020 18:21:06 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khGSU-0002dy-7W for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 18:21:05 +0000 Received: by mail-pf1-x443.google.com with SMTP id t8so15668417pfg.8 for ; Mon, 23 Nov 2020 10:21:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WXjQw/Ei2ozuIWUZyXPQXVN4Mqw8skdXF2+muz2N79E=; b=s+K6c+/1JMFv5v1GY5Rt4oHFUl3vsl5xKDRka4miXE/3AEPkByXvY2M3x8+WfDrIzJ WCTTmBXMSw0jdFXi4vPbaJjwNZRpK77r5EN2S35021v7Ev+DzPW9Sb2tDw5Nzj7Z0x77 N/B7RFCnbe3my9RJxaH3dtnI06yA9386agGRM7nLg02J9QfNI6INmQltHeFkGLXmOxRg 2l9me9tjj8fTwpir07h7iLmk/BK0gmX+9TBVqEthYuJOdBdiQh8+0kmQiJXBeaS7fHCp heqnPA/yAYJ5d/IlXFkdiYG6hAJ4JPy0L0c96jjmf8p1m3IAv87RGr8V0Ba/IinMjPzn nNEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WXjQw/Ei2ozuIWUZyXPQXVN4Mqw8skdXF2+muz2N79E=; b=HfsMprO6PKxWAMf9Eq8bOonn/sUSs5wLRGA6O1sddoVHvuhfCy8NISobFYDMXpbNPt dBrfgikocAEx9yhSCt/sgmIT3gReFOSYWJfX7cPRjencGnizv8xvi2CEfKc3p0/yw3Qh B32ACj/AJTSuLuNYoVOKrLoMgeUN1hXMBoX82w9AZxOZuBVluDTiqrnyonzU/teas/zI wNeJMtJ+Obs0CnrkMQl/eR4ETbEXfDP99jaoH+wAF65xjq9+xjm09W0guxTfQo6omUuh QL6yJIGHyojm1lWpcdOPjbWI7GCX0I1QbghXmvpzpLvfkdjH9kBZ6/qCmsSoOZS/RQm0 kmCg== X-Gm-Message-State: AOAM532GY4SkK9L6SwMZu/U+5/YmJjGba59D15IdF0ABUGLsdiVtnHLL 3FJQYXdDO0IqE5c+VxAsf01ssASo2zt5Uoexq/lvJg== X-Google-Smtp-Source: ABdhPJzRohL9fsaii/K1Xw/nq0y8iaZIigOAp8jNEBB2DO23+xsD1mUl5DscPIvbbiZz6YUhrmKf6/fSi6x+r7YOQXk= X-Received: by 2002:a17:90a:db03:: with SMTP id g3mr175751pjv.41.1606155658781; Mon, 23 Nov 2020 10:20:58 -0800 (PST) MIME-Version: 1.0 References: <20f64e26fc8a1309caa446fffcb1b4e2fe9e229f.1605952129.git.pcc@google.com> In-Reply-To: <20f64e26fc8a1309caa446fffcb1b4e2fe9e229f.1605952129.git.pcc@google.com> From: Andrey Konovalov Date: Mon, 23 Nov 2020 19:20:47 +0100 Message-ID: Subject: Re: [PATCH 1/2] kasan: arm64: set TCR_EL1.TBID1 when enabled To: Peter Collingbourne X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_132102_391250_8A74ED18 X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Kostya Serebryany , Linux ARM , linux-api@vger.kernel.org, Vincenzo Frascino , Will Deacon , Dave Martin , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 21, 2020 at 10:59 AM Peter Collingbourne wrote: > > On hardware supporting pointer authentication, we previously ended up > enabling TBI on instruction accesses when tag-based ASAN was enabled, > but this was costing us 8 bits of PAC entropy, which was unnecessary > since tag-based ASAN does not require TBI on instruction accesses. Get > them back by setting TCR_EL1.TBID1. > > Signed-off-by: Peter Collingbourne > Link: https://linux-review.googlesource.com/id/I3dded7824be2e70ea64df0aabab9598d5aebfcc4 > --- > arch/arm64/include/asm/pgtable-hwdef.h | 1 + > arch/arm64/mm/proc.S | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h > index 01a96d07ae74..42442a0ae2ab 100644 > --- a/arch/arm64/include/asm/pgtable-hwdef.h > +++ b/arch/arm64/include/asm/pgtable-hwdef.h > @@ -260,6 +260,7 @@ > #define TCR_TBI1 (UL(1) << 38) > #define TCR_HA (UL(1) << 39) > #define TCR_HD (UL(1) << 40) > +#define TCR_TBID1 (UL(1) << 52) > #define TCR_NFD0 (UL(1) << 53) > #define TCR_NFD1 (UL(1) << 54) > #define TCR_E0PD0 (UL(1) << 55) > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > index 23c326a06b2d..97a97a61a8dc 100644 > --- a/arch/arm64/mm/proc.S > +++ b/arch/arm64/mm/proc.S > @@ -40,7 +40,7 @@ > #define TCR_CACHE_FLAGS TCR_IRGN_WBWA | TCR_ORGN_WBWA > > #ifdef CONFIG_KASAN_SW_TAGS > -#define TCR_KASAN_FLAGS TCR_TBI1 > +#define TCR_KASAN_FLAGS TCR_TBI1 | TCR_TBID1 > #else > #define TCR_KASAN_FLAGS 0 > #endif > -- > 2.29.2.454.gaff20da3a2-goog > Reviewed-by: Andrey Konovalov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel