From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 575DAC433DB for ; Tue, 9 Feb 2021 17:28:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1243C64DF2 for ; Tue, 9 Feb 2021 17:28:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1243C64DF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gYBZC4RuD/wJL0zlgXPXggkXZfS+1PbXo22V4jRSXbk=; b=v87QbHegzhHhzyZz+Raj4zFv5 LUbuX40ugQ3/ijfd971GSMpWQ5Kz1URNeKNz+kA4XV4umCePJiogGEE5l6Gb9FHtV/7/5GcDLoYst P0CQxBjLY0PfRVwyYF0odNjQXDAI0EEs0LNBXW4dul6AxlaSzj/FhO4Kix7pOrNxsM3vrm4gFq44H 1cJqIfv5eaR86IrKDRjLvHaHHwGdvdcpzfYY/kOVmqmbkbI9Gy3pqbB3nPidKnYpPdR7dxsPPWe3f z3Uuy1OwQOvW9OkQuXCS+rOMW1n18DzwXGSkgvjcoC3JwRNNDvTNkbaccm3jywvI5hF3h0X7naLj1 EvhJE/ZrA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9Wmv-0007Ab-K3; Tue, 09 Feb 2021 17:26:57 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9Wmt-00079K-FD for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 17:26:56 +0000 Received: by mail-pg1-x52a.google.com with SMTP id t25so12913536pga.2 for ; Tue, 09 Feb 2021 09:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ukuRLDcQbuu9Wej1M0AS5B/9jDoZ1QokOXA2WrrNxEY=; b=YoIMbsWIFWv8KpmtLg8QTcpbt/fUVhBHACu3czCeX0tEmzVDiLrY0Hiw+9Bsv5ukzZ ZT6haRQBAUQ2Nlmj2SdCE08HXNG/8jIMjAA3MV1zMqEq4QN3nFDdXkqvK6zYMZ4JIUl5 fOqqzVqV689MBNMj2xWu7x/kwzRFHmUvnzbHk7frhsyHd/J7BvCjhpp1WTPqsGc7g9Tc TXJQe9rsn7m31GtYMvwHCWSbcrNBlDzloWQTRJ5fZ55EOaDghvUu79jpxlXwAHvbuJlQ hfB5JWR0pNLKMzu6stN0ZgEMG1uEPZ/LFDgcfZp7C9T1F2sKjdAirJC8a6Y78D65VAvl DqSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ukuRLDcQbuu9Wej1M0AS5B/9jDoZ1QokOXA2WrrNxEY=; b=aAwdBJMsCqQ5tq/lxqW7v64Pe+i5SgRhZONYn94LsuVrOisuA42rShTPLZ+9ceexbW 0UmuyzV1kFsi5zwX5HETiFev8G1UPX0k2vZVcUWIe7ZdjmvANV0NdndMgnlfxyihKs4B nkv+SXvk6pkcPWMwQ0bNXgh1xIOwb3ZmUp+wJwb27qHFYxdn4VR1sU8JdRj0567y5s2F 73IMdgl+LJUhvZc0t/OsKa/9KLgEDJ9SOCWmwsA5EP5xcizgL6OcXI/3gYy0ucRxk54u 14fNBBvarAT98NG8AReJ4Rpl8dAVj2bHfFp0B5SCfH92oyf4Op75yPgrTvhHKkFwTkOz QDig== X-Gm-Message-State: AOAM530Bg6pJS4DbBIb6I/+/yCIZRlqZfXqX76pEsFiNNqS7sjxpKi9/ mfxfYW29PVgmPK/y60c3npac5Mc40V5Eon/wBNwfvg== X-Google-Smtp-Source: ABdhPJz6N+eKvhfv1cZSCC1ZthfavGY4wG1OcdH37S0B5a2XLNoJJaJ3NNyMnTmrR4e3lawZLx9/koEkfFbBVOL1qTg= X-Received: by 2002:a62:8cd7:0:b029:1d9:447c:e21a with SMTP id m206-20020a628cd70000b02901d9447ce21amr19146610pfd.2.1612891613122; Tue, 09 Feb 2021 09:26:53 -0800 (PST) MIME-Version: 1.0 References: <20210208165617.9977-1-vincenzo.frascino@arm.com> <20210208165617.9977-8-vincenzo.frascino@arm.com> <20210209120241.GF1435@arm.com> <0e373526-0fa8-c5c0-fb41-5c17aa47f07c@arm.com> <20210209170654.GH1435@arm.com> In-Reply-To: <20210209170654.GH1435@arm.com> From: Andrey Konovalov Date: Tue, 9 Feb 2021 18:26:41 +0100 Message-ID: Subject: Re: [PATCH v12 7/7] kasan: don't run tests in async mode To: Catalin Marinas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_122655_596677_9B1B313B X-CRM114-Status: GOOD ( 27.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Marco Elver , Lorenzo Pieralisi , Evgenii Stepanov , LKML , kasan-dev , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 9, 2021 at 6:07 PM Catalin Marinas wrote: > > On Tue, Feb 09, 2021 at 04:02:25PM +0100, Andrey Konovalov wrote: > > On Tue, Feb 9, 2021 at 1:16 PM Vincenzo Frascino > > wrote: > > > On 2/9/21 12:02 PM, Catalin Marinas wrote: > > > > On Mon, Feb 08, 2021 at 04:56:17PM +0000, Vincenzo Frascino wrote: > > > >> diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > > >> index 7285dcf9fcc1..f82d9630cae1 100644 > > > >> --- a/lib/test_kasan.c > > > >> +++ b/lib/test_kasan.c > > > >> @@ -51,6 +51,10 @@ static int kasan_test_init(struct kunit *test) > > > >> kunit_err(test, "can't run KASAN tests with KASAN disabled"); > > > >> return -1; > > > >> } > > > >> + if (kasan_flag_async) { > > > >> + kunit_err(test, "can't run KASAN tests in async mode"); > > > >> + return -1; > > > >> + } > > > >> > > > >> multishot = kasan_save_enable_multi_shot(); > > > >> hw_set_tagging_report_once(false); > > > > > > > > I think we can still run the kasan tests in async mode if we check the > > > > TFSR_EL1 at the end of each test by calling mte_check_tfsr_exit(). > > > > > > > > > > IIUC this was the plan for the future. But I let Andrey comment for more details. > > > > If it's possible to implement, then it would be good to have. Doesn't > > have to be a part of this series though. > > I think it can be part of this series but after the 5.12 merging window > (we are a few days away from final 5.11 and I don't think we should > rush the MTE kernel async support in). > > It would be nice to have the kasan tests running with async by the time > we merge the patches (at a quick look, I think it's possible but, of > course, we may hit some blockers when implementing it). OK, sounds good. If it's possible to put an explicit check for tag faults at the end of each test, then adding async support shouldn't be hard. Note, that some of the tests trigger bugs that are detected via explicit checks within KASAN. For example, KASAN checks that a pointer that's being freed points to a start of a slab object, or that the object is accessible when it gets freed, etc. I don't see this being a problem, so just FYI. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel