From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9951C43463 for ; Fri, 18 Sep 2020 10:41:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48FFE2068E for ; Fri, 18 Sep 2020 10:41:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bp98VSjt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="bZzEE8ST" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48FFE2068E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yMtVezoHUZHvrMvAAjLf5uTWE8Heh1MKUWvwlFBgF1A=; b=bp98VSjttbnPKZjj9+RX30R7t np5Fu9FbDAcbCkWJfFLMfkfytnbUp1mBuZcDOZB0wBY6vLwnGL4azMNzlTNVWBWYNb+77gMnzm3c8 unkU3eIswALF2uIsU/iH7SBkAj5eb2jj7Q1/MQU12wkvQW5G8spRiQtOBAg2Qmr65WgGXjjyYSRHD ej745kzAOgOS9jSFwOGURf9NMw1aOaPOuT3fiWJdpguY2fUoPUd02kMBUB8hzhm7qqsp6vvUz1gnD YV+2BVE4ye0H/lr++rFmXyctF1eENK0wSL4q8tRcxch3hpw/c0/C82EwmwriuruGsWWeM491GkfP8 WWGkjl5Vg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJDo5-0003qh-Te; Fri, 18 Sep 2020 10:39:57 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJDo2-0003no-VX for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 10:39:55 +0000 Received: by mail-pg1-x543.google.com with SMTP id 7so3213928pgm.11 for ; Fri, 18 Sep 2020 03:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0BA74pq9Zk+EY0B+5KtILBM++vfiF9LClb1TtG0VGMg=; b=bZzEE8ST+6WycOr5Rst39I67wilv5k5SvyGkHPsn3mRhe7ruYp7AzIfSmSL5YMy4+J r+dGj4oYaHC1ALs8NiHp/twhAU0qUWSNOATnubN3m21ylxDXxcTqxofc3KPTdKZad1WQ IEHIsCsDpbojqgbChTdgpPxyX+MWPJEX92ERMR2ZEIEyGhcMVmzM4smWPMNyiYGGdwkj ly6cdPI8/Wsd16ztLensD3N8jRUmelx6HviINExWraokAC0MFiMos0HLdnF9XbWcMUjN RXQqO8k2yiR1wbncuo2s7NM5dEqmzgEaMXaZ1YFX+WAUrMd96adcYIW9Sj0ekeZZli91 q2ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0BA74pq9Zk+EY0B+5KtILBM++vfiF9LClb1TtG0VGMg=; b=MCTT5NGpLf907ZNuL4d5Gd78tPio7sPWuzARVm5tb6XVQtyyXoMFgxdlwHTzlYFUTz Hnswk8IgbgMYD95qcyFh6XGXbAIqSvjJZuGbpI2+13CsKC5dxEuEEVYagKijijhqAbPb fWnVgjXgMKhAYpfoVSY1dsl+0/5CY6Uh81F5zTCMs9+J1Eqrw0mdXVej4dR6f+aV9Q3C j5oKeZoWfkzBQlgxuEH7LQg+7jTbCfjInXmA7nBZodBI5YJQejlUYMv8LH9v+jtIABq8 QMzOL6SaX5sw9jlPtklXxzEhEAImE5LQHBkiDquazruvn6vqjbSfsCQ5ebOn9zfzJpY4 ek9A== X-Gm-Message-State: AOAM530tPMqp5OiUG0xw7UG/UKOUmNARBrf5qtm1WrjtBhGAI7NQ/w6A oneIOjXC9I3hTEDW+3p0JF0CVUBMck4b7aGNnPXD0Q== X-Google-Smtp-Source: ABdhPJxsNJ1/ALFvU9Viq7TgmQqLSQxHS+99JGvGaazSkYkpuVJz6AGEjcS6JGjChCrWVe3VKznLhUu3jPZIQtmbWro= X-Received: by 2002:a62:ee10:0:b029:142:2501:3972 with SMTP id e16-20020a62ee100000b029014225013972mr14985432pfi.55.1600425590587; Fri, 18 Sep 2020 03:39:50 -0700 (PDT) MIME-Version: 1.0 References: <88c275dc4eef13c8bcbe74ecec661733dcbc67b8.1600204505.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Fri, 18 Sep 2020 12:39:39 +0200 Message-ID: Subject: Re: [PATCH v2 07/37] kasan: split out shadow.c from common.c To: Alexander Potapenko X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_063955_026135_A1CA51EF X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Marco Elver , Elena Petrova , Catalin Marinas , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Linux Memory Management List , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 18, 2020 at 10:17 AM Alexander Potapenko wrote: > > > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > > new file mode 100644 > > index 000000000000..4888084ecdfc > > --- /dev/null > > +++ b/mm/kasan/shadow.c > > @@ -0,0 +1,509 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * This file contains KASAN shadow runtime code. > > I think it will be nice to mention here which KASAN modes are going to > use this file. Will do in v3. > > +#undef memset > > +void *memset(void *addr, int c, size_t len) > > +{ > > + if (!check_memory_region((unsigned long)addr, len, true, _RET_IP_)) > > + return NULL; > > + > > + return __memset(addr, c, len); > > +} > > + > > OOC, don't we need memset and memmove implementations in the > hardware-based mode as well? Hardware mode uses native memset implementation as all memory access instructions are checked by the hardware anyway. > > + region_start = ALIGN(start, PAGE_SIZE * KASAN_GRANULE_SIZE); > > + region_end = ALIGN_DOWN(end, PAGE_SIZE * KASAN_GRANULE_SIZE); > > "PAGE_SIZE * KASAN_GRANULE_SIZE" seems to be a common thing, can we > give it a name? This patch just moves the already existing code, but I can fix this in a separate patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel