From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D29C4363D for ; Fri, 25 Sep 2020 11:54:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB29621775 for ; Fri, 25 Sep 2020 11:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L0B0pFuk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="VNgZuBxU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB29621775 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NIPUU0EkwGCT+ZNIrH8jykJcktEvN2qmOftQM0v7/ec=; b=L0B0pFukZ8maG2AkvH81M8p5x 2QoNkvSExytbngGspnrM3Pg7VZTlQ2W15RxjpmUk6aAGYh5miWa3P84b6SmZBnRCri+ve5HNBGCmT pCyOm/iEeSB2U3XEVuQXKHZGY88+9N4S3yJ7IFzjaJ6L+yUI07jpohSeJGqKpF7Z4EgtgOefekLIo QcWSVzOBxZt5x4j8ukXL3hLKAeRJLrhwpoMQRlXF0s9QIlsYF+o/6kwsQxFkA8QUT3CRgW/Nrqiup eiObCOKJeaWKrGO0OvuBrfuRPVr5ezp2fZh6utgDiiAoZtW5ICKAhT5+Fu0CSX6GZy/sGu7x/dY4a KCXyr0t+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLmHo-00038S-Pj; Fri, 25 Sep 2020 11:53:12 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLmHl-000373-OF for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2020 11:53:10 +0000 Received: by mail-pg1-x542.google.com with SMTP id l71so2359308pge.4 for ; Fri, 25 Sep 2020 04:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A1oOkyfsqFH1LfQrqPkW7aNFfIeXKev/R5cazxL0aFM=; b=VNgZuBxUpAgJ8TImvaNn2mHkfg9QdQXl830VbRYRx2TXZC7HlzA0A11WFHU3nH9AYz Cc3KAsNx7MblsfZCJ+9RFgyH70bkLziaw2lR6NWTlmwozfDYdjaeNUEUuZyIE03fWCqL F9JjA5ryhGFZPYkXihGXzaKj4V1T2+Y1T8x2uZrBAm/SkvIVkUDUiRWOkOBSfCT8f0hU H/+Kr/rWddToxWq705+hpL4PrXmXFwpIcx+bZJ4xlYWWAv6eV7UR8xg7h/OV3I9GRNQa zVnpLvCcENqK5uXej0r63VuhHMzJH5wI6CKS+QceAoxK+raeyg9olUJUF1HPGKpkwH77 7x4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A1oOkyfsqFH1LfQrqPkW7aNFfIeXKev/R5cazxL0aFM=; b=mSzDZND9yFLLq48hb7wNOgbVHbH0bS5QzHwWIE3dIs7kuuTuLGJxViqlbntXd2r5rz fUurFeG7niYBhrVpI3/U/SP+uSaE8jaEb45Uw0P//Qikr/AUi/9iq78F1OLDgWeU5eyE cEKKgqg7BYeARLQpVtsCJ2Ig/iyYeIK74BCILulVr9noSmMra1GUoI4tZ0GPUDOaCY4D APGdAv5LiwDzFcaLZuKS9eCIapi6tF/wbjCaEfYXGQuZaf77PKVXn8tW5pqvWTeAPnzS AFvKKNoV5D6iECZtgfyzmuwO9PYq6Fn8CZkVnBKNIGqFG6hkotqSztYbnE7zT8uK/Gov 7oVg== X-Gm-Message-State: AOAM530b7gkYla2KLfNRGfj/ES8LTHDQG7603X8iyLW+MX2FOi4LUFqz PErfmTqB+I3M+KwsRZIp3CJln+FKN03Lgre6mSt4WQ== X-Google-Smtp-Source: ABdhPJx0QjhXx2O6yAB1JFuqfI8C4Gskzovi86WJ/DlXN39Y17g2CJxltdIp9/zADsheICMyr2n9j8vzcXCPG7woAGM= X-Received: by 2002:a17:902:b117:b029:d1:e5e7:bdf5 with SMTP id q23-20020a170902b117b02900d1e5e7bdf5mr3803333plr.85.1601034787254; Fri, 25 Sep 2020 04:53:07 -0700 (PDT) MIME-Version: 1.0 References: <17ec8af55dc0a4d3ade679feb0858f0df4c80d27.1600987622.git.andreyknvl@google.com> <20200925104933.GD4846@gaia> <20200925114703.GI4846@gaia> In-Reply-To: <20200925114703.GI4846@gaia> From: Andrey Konovalov Date: Fri, 25 Sep 2020 13:52:56 +0200 Message-ID: Subject: Re: [PATCH v3 26/39] arm64: mte: Add in-kernel tag fault handler To: Catalin Marinas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_075309_855048_3089A869 X-CRM114-Status: GOOD ( 26.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Marco Elver , Elena Petrova , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Linux Memory Management List , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 25, 2020 at 1:47 PM Catalin Marinas wrote: > > On Fri, Sep 25, 2020 at 01:26:02PM +0200, Andrey Konovalov wrote: > > On Fri, Sep 25, 2020 at 12:49 PM Catalin Marinas > > wrote: > > > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > > > > index a3bd189602df..d110f382dacf 100644 > > > > --- a/arch/arm64/mm/fault.c > > > > +++ b/arch/arm64/mm/fault.c > > > > @@ -33,6 +33,7 @@ > > > > #include > > > > #include > > > > #include > > > > +#include > > > > #include > > > > #include > > > > #include > > > > @@ -294,6 +295,11 @@ static void die_kernel_fault(const char *msg, unsigned long addr, > > > > do_exit(SIGKILL); > > > > } > > > > > > > > +static void report_tag_fault(unsigned long addr, unsigned int esr, > > > > + struct pt_regs *regs) > > > > +{ > > > > +} > > > > > > Do we need to introduce report_tag_fault() in this patch? It's fine but > > > add a note in the commit log that it will be populated in a subsequent > > > patch. > > > > I did, see the last line of the commit description. > > Sorry, I missed that. No problem! > > > > + > > > > static void __do_kernel_fault(unsigned long addr, unsigned int esr, > > > > struct pt_regs *regs) > > > > { > > > > @@ -641,10 +647,40 @@ static int do_sea(unsigned long addr, unsigned int esr, struct pt_regs *regs) > > > > return 0; > > > > } > > > > > > > > +static void do_tag_recovery(unsigned long addr, unsigned int esr, > > > > + struct pt_regs *regs) > > > > +{ > > > > + static bool reported = false; > > > > + > > > > + if (!READ_ONCE(reported)) { > > > > + report_tag_fault(addr, esr, regs); > > > > + WRITE_ONCE(reported, true); > > > > + } > > > > > > I don't mind the READ_ONCE/WRITE_ONCE here but not sure what they help > > > with. > > > > The fault can happen on multiple cores at the same time, right? In > > that case without READ/WRITE_ONCE() we'll have a data-race here. > > READ/WRITE_ONCE won't magically solve such races. If two CPUs enter > simultaneously in do_tag_recovery(), they'd both read 'reported' as > false and both print the fault info. They won't solve the race condition, but they will solve the data race. I guess here we don't really care about the race condition, as printing a tag fault twice is OK. But having a data race here will lead to KCSAN reports, although won't probably break anything in practice. > If you really care about this race, you need to atomically both read and > update the variable with an xchg() or cmpxchg(). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel