From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3621C433DB for ; Thu, 7 Jan 2021 16:32:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47DD52339E for ; Thu, 7 Jan 2021 16:32:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47DD52339E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/uGvxMIpgfQISkLlUfqieXpIDRaCmE0bxhh5Nnr8TPw=; b=EExJ1LXwj0Pday08yKhG6Ospk 5QXzXhwrz09kf8sGjNh++i2ocxrOYlYfFopLcly6OKG166MDS8dIE3LJlJ3PlMIFamo4N/qbT8jlk PfmoliTWSCJi1UAjYkBwrhUmsERDWB+aJvQeki8TCJb08ROG3/rxAuOX+e3/GSHOlvwCp2oEYj2f8 tcGIhiF2ZJxQ7qgJmqrCgNboJb8CMgHF1YYddTxthu+Gz2mSe3T9MMo7/pmrKWB9AT6tLVTkHn1cu HcMrtBwbbOm6JvvOxs1S5mfMjXWly1VB+Edgx56xxjEsYejqA+q4TqzVf1LDJay+djiBLlrdHizUu v4e9qPJnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxYAe-0006Xg-7j; Thu, 07 Jan 2021 16:29:56 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxYAa-0006Wd-Em for linux-arm-kernel@lists.infradead.org; Thu, 07 Jan 2021 16:29:54 +0000 Received: by mail-pf1-x434.google.com with SMTP id c13so1488016pfi.12 for ; Thu, 07 Jan 2021 08:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FpXEjxjV8OA24pUWXj8gzsn1GWb+lIIbFcLAwI2yW6M=; b=MNQpruws9fgcWh82xa59SNVkyYGer9g6kYEfTTvrC7dc3BQeHcFsslYr/ygeNcnpvk 6UfHt1riKnkjWLnR9AXJhsOwVCPswgIi+7AQr9gh+goe40zE2+p+NtKiefZsSnCbhDTq CS5vzG+aJuoTkX162eOQQYDKOoyACBh+OiPk7DN970+SsbTahoP4+Sd23qyW/MpsD++E 89xUcRPdjnD3MsLgdnNxwIGtT54vmN9UAAxUUdAdJcCs2eeaTIYFCBIwuDjz6sRKU871 z9PRUQlIpC2yLQQKRKBigTVsRU7zpDc6d9iKbyl4C9y0VeihB5OtcC+ExgLuqVPwCnHK bOrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FpXEjxjV8OA24pUWXj8gzsn1GWb+lIIbFcLAwI2yW6M=; b=cfh9hvorWj5QutaHe/90KsZwGMHrM2SN6ni1aVTh5fgXMf+FUYasRvu1PCn+L6B9Z0 25TnErToDBUTnWNZdPyKc2ajDj2OwgR+G8XYzrTi2qVTA/PJQAK39cT3hxLTuIjkOObv tFp9XyAINrRXTgUrtPEO3AGoyhlb4xRCoT7KYCaOda4Nsu+ArKpSirm1sq58w4V/5GID HuFQkcsxH8KIEkaB+Jw8LO6M+QRjwH/DA0h2k09eAB+DnpjJAziRE5y7GSO/y1bJBqvi UUdCYivazUPev90G8lBNDH9vEHz9q7L7kzAVhMS3qwwnlEm6ueKemtLgIjEYdSG9fxp9 lYSQ== X-Gm-Message-State: AOAM5302679Hm1w/XFV4KgDzIU9+RaipCMOqtH2onnfKvmPng4nDh2lU sJGi7QfRdzT6gUzWk6JHVTnywAtg4UcomAVQDXybgA== X-Google-Smtp-Source: ABdhPJyXIT2I6ZawKyhg4hXllpWgbIJy6aKDJ16wqxqjtn+GXKKMmwiYCZdBOmMbZmK2t8UUxQsfvqzNcDp73LRLE3k= X-Received: by 2002:a62:2585:0:b029:1ab:7fb7:b965 with SMTP id l127-20020a6225850000b02901ab7fb7b965mr9501125pfl.2.1610036989989; Thu, 07 Jan 2021 08:29:49 -0800 (PST) MIME-Version: 1.0 References: <20210106115519.32222-1-vincenzo.frascino@arm.com> <20210106115519.32222-3-vincenzo.frascino@arm.com> In-Reply-To: <20210106115519.32222-3-vincenzo.frascino@arm.com> From: Andrey Konovalov Date: Thu, 7 Jan 2021 17:29:39 +0100 Message-ID: Subject: Re: [PATCH 2/4] arm64: mte: Add asynchronous mode support To: Vincenzo Frascino X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_112953_783010_769691A3 X-CRM114-Status: GOOD ( 24.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Marco Elver , Catalin Marinas , Evgenii Stepanov , Will Deacon , LKML , kasan-dev , Alexander Potapenko , Linux ARM , Andrey Ryabinin , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 6, 2021 at 12:56 PM Vincenzo Frascino wrote: > > MTE provides an asynchronous mode for detecting tag exceptions. In > particular instead of triggering a fault the arm64 core updates a > register which is checked by the kernel at the first entry after the tag > exception has occurred. > > Add support for MTE asynchronous mode. > > The exception handling mechanism will be added with a future patch. > > Note: KASAN HW activates async mode via kasan.mode kernel parameter. > The default mode is set to synchronous. > > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Vincenzo Frascino > --- > arch/arm64/kernel/mte.c | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index 24a273d47df1..5d992e16b420 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -153,8 +153,35 @@ void mte_init_tags(u64 max_tag) > > void mte_enable_kernel(enum kasan_arg_mode mode) > { > - /* Enable MTE Sync Mode for EL1. */ > - sysreg_clear_set(sctlr_el1, SCTLR_ELx_TCF_MASK, SCTLR_ELx_TCF_SYNC); > + const char *m; > + > + /* Preset parameter values based on the mode. */ > + switch (mode) { > + case KASAN_ARG_MODE_OFF: > + return; > + case KASAN_ARG_MODE_LIGHT: > + /* Enable MTE Async Mode for EL1. */ > + sysreg_clear_set(sctlr_el1, SCTLR_ELx_TCF_MASK, SCTLR_ELx_TCF_ASYNC); > + m = "asynchronous"; > + break; > + case KASAN_ARG_MODE_DEFAULT: > + case KASAN_ARG_MODE_PROD: > + case KASAN_ARG_MODE_FULL: > + /* Enable MTE Sync Mode for EL1. */ > + sysreg_clear_set(sctlr_el1, SCTLR_ELx_TCF_MASK, SCTLR_ELx_TCF_SYNC); > + m = "synchronous"; > + break; > + default: > + /* > + * kasan mode should be always set hence we should > + * not reach this condition. > + */ > + WARN_ON_ONCE(1); > + return; > + } > + > + pr_info_once("MTE: enabled in %s mode at EL1\n", m); > + > isb(); > } > > -- > 2.29.2 > Hi Vincenzo, It would be cleaner to pass a bool to mte_enable_kernel() and have it indicate sync/async mode. This way you don't have to pull all these KASAN constants into the arm64 code. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel