From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 633ECC433E0 for ; Mon, 11 Jan 2021 19:05:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2A5022A84 for ; Mon, 11 Jan 2021 19:05:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2A5022A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=umc8aW+S61KvGIeo+qHqk0Kyjc1Ynb+iNSAACi2On0Y=; b=N3qaH8RWS4ZAaYYU51kqJ2QGK RAjwjmPdm2ZyySuxRMjgbIkITjZ2detEOfHpbPycDKCGsFXyotYtDFY0I9j0Q2kcF8Rup5/dwUHtn Zi3s1jotgXrXHsKmWdUyWqAKNqWdXmieySA6VatIrRWyz7cjERjVfH7+d0R20ZlzmimarmMTmLZHB A4uRzXtuuU70MdL2GOrKw9LALPUK5TidQ94/t/1Id0k6tqnr7ZYF1f2PDb6icKGL3J2Jn4CSIJhXs HarLlg7pHZz9Bx1NOkl2F+ufBg0QKHCPoCikmSOOKiAZklcueEH1VjBk4YBaWksfze23Vgi4XxEJ8 BYrX2mr3w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz2Ti-0002EN-6W; Mon, 11 Jan 2021 19:03:46 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz2Tf-0002CN-1D for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 19:03:44 +0000 Received: by mail-pf1-x42e.google.com with SMTP id w2so479935pfc.13 for ; Mon, 11 Jan 2021 11:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0M90n7WjWo+X1yIVKHdOTyfvfwcWqL9tkBr22HLMVsY=; b=mQxWWfxrpoJqQpQ0teH0JWLWjRlCD6LzwnF9DaADN1VituMO7/JZhJSc19maKjmKa0 XAhLsG6GziZLcTS2nrs4aZgJyR1MwzUKmkGihnYT4kRyKGczg0UL7kcyLDEfJM67gV4o C6Qe1DfX/qHHCoZSiQr1IC3yt5haB46iMoLbiVigq5Z4Wk9LZWV1EsqDj7jVKI0Idjm+ 9FgiQytvEQ6ZkCGZeiYITKvdh+L8AFRXr2eHwaMMEDY3+zyb7fJvMawbCCycvQOicRPY 459LZinhBEH0OuPe0NVfJ99MWMN4iZoQOUkf3GKueztCB5U3p47j+G6zeNylLPU3TE3A l7/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0M90n7WjWo+X1yIVKHdOTyfvfwcWqL9tkBr22HLMVsY=; b=KGauAM8QydpXUhrc2BsXCJWmsX53d/maK2IbOBefiVZQrh3h4bYcn9zz8RQabcqSo5 QA8Qh8dM0cb0JdFJTGsQjjQpkaetkSqR8wEYR5wX2GjcNQVLy3Kku1ix2ArMr5l3HZmh 03iZxXpwuM8gjhH+HrNzR/cSQJAheoSe9ymGgwXT/1TNr1oI8R9vUzn9nT7TQPsFo5CL l5H9Q4jRdZ3ibrlyAUGhCkNF0i+Tacl/pq9Md/kYZM2PXDSEko7qq0T0V5YI1dueI3Ib uKcwV98sVRUDs2JHjgwPqRGyy/gDDQ6UC7EAswwsa5RvX8Ix3Zw/PNIwk7hbcYFcp9FS EyFQ== X-Gm-Message-State: AOAM533ZWA9Rp9Ah4Zem6cYQFvgcOML3ivbE3ZeGzBHgiO8HgtxqNVYI zysNZbcPf7KCyMC+W1ZzVtDMbYtX6D5G5wcOKm8Zmg== X-Google-Smtp-Source: ABdhPJwE4imAaZmMhSvygLJ7bWjPPKzRbOvPeN2tNIIdl6OeQBhwMi9C6hF05YOIW4ESl/Tn4KeOeJ11tsXFRkISwUg= X-Received: by 2002:a62:14c4:0:b029:19d:d3f5:c304 with SMTP id 187-20020a6214c40000b029019dd3f5c304mr991822pfu.55.1610391820883; Mon, 11 Jan 2021 11:03:40 -0800 (PST) MIME-Version: 1.0 References: <20210108040940.1138-1-walter-zh.wu@mediatek.com> <20210111185902.GA2112090@ubuntu-m3-large-x86> In-Reply-To: <20210111185902.GA2112090@ubuntu-m3-large-x86> From: Andrey Konovalov Date: Mon, 11 Jan 2021 20:03:29 +0100 Message-ID: Subject: Re: [PATCH v3] kasan: remove redundant config option To: Nathan Chancellor X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_140343_165154_E730C89D X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Walter Wu , wsd_upstream , "moderated list:ARM/Mediatek SoC..." , LKML , kasan-dev , Linux Memory Management List , Alexander Potapenko , Linux ARM , Andrey Ryabinin , Andrew Morton , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 11, 2021 at 7:59 PM Nathan Chancellor wrote: > > > > -config KASAN_STACK_ENABLE > > > +config KASAN_STACK > > > bool "Enable stack instrumentation (unsafe)" if CC_IS_CLANG && !COMPILE_TEST > > > > Does this syntax mean that KASAN_STACK is only present for > > CC_IS_CLANG? Or that it can only be disabled for CC_IS_CLANG? > > It means that the option can only be disabled for clang. OK, got it. > > Anyway, I think it's better to 1. allow to control KASAN_STACK > > regardless of the compiler (as it was possible before), and 2. avoid > > It has never been possible to control KASAN_STACK for GCC because of the > bool ... if ... syntax. This patch does not change that logic. Making it > possible to control KASAN_STACK with GCC seems fine but that is going to > be a new change that would probably be suited for a new patch on top of > this one. The if syntax was never applied to KASAN_STACK, only to KASAN_STACK_ENABLE, so it should have been possible (although I've never specifically tried it). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel