From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 003BEC31E49 for ; Wed, 19 Jun 2019 14:42:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9BBB214AF for ; Wed, 19 Jun 2019 14:42:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CGaIdymc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="jbRaxdb+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9BBB214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FZNsFx4TS8uNUrfZO59tDewuJAd6n8oHHF+l0qnNUsI=; b=CGaIdymcnDJVXB I7ylxXpbMxhwP69pVs8DCFB/YlWHjmJ2fwpcmJuQYH0w6sR9egprTWUkf5cvZTw2T6HzNsl/RbvCx Bd8xrAssJ4tVai4Cyi5f3eGQ1kys2qcr9tRlV2w/tE+WJtMvsnPyE9pALoNwLFiJWwZuSAZ0rJS8S JFPoivzyPANtE1LRlNQZIdjHwRFxdh7czxApF+rxm01NOu7+l6+6eVxyW05kYC+HzMVO+8MGt/u7V 2qdDX0zfudyi91Mm70m91n4mQLNh3ZITz1XjXiTx+PjiOJWi2tpmXONwPe48wrYXM7/4Tm433DMZx NvQe6moEvXdeyXLdFrug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdbnR-0008F4-VV; Wed, 19 Jun 2019 14:42:46 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdbnB-00081b-UC for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 14:42:31 +0000 Received: by mail-pl1-x641.google.com with SMTP id b7so7332520pls.6 for ; Wed, 19 Jun 2019 07:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZUb5QTtqm4gVcMQkDqa/NfcfqCV/fqPlPHdvScpz0wo=; b=jbRaxdb+WWdzPQKppmuoBauA7dvRkdybKRNWtDi8BmVPL/duOwFKyfvGY1RtILXxC+ E8fMNzdn99xzzaV1RU67k5BSaIeAySJVjGFam1tncgt0b1c3N/H+rn9Q1Ce9beAuIxY9 4KU4S5Y6wyOdt8eRLq9iK/DasXwgpWgTB7OZoLagsJt17dKKFAk9z5/knt/SGGUXD1Pm OoCcVKVcumlyUAfwODg+GBNNkPYKXfWaLZhXGdXetH+hDPabh+cOTFmJx9VZ0MK9R5nx t58AUdQKa58pKb0SOzR1wBFV6nXGOJqmSpABaHdX/di+h0+s+ytlFiUVqPji7K9x3yTy 3m5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZUb5QTtqm4gVcMQkDqa/NfcfqCV/fqPlPHdvScpz0wo=; b=JjBUbIY5xahfBO21+4L2D220dGaXxG2nZbNPXo66ubZEeJxyhpMCpIaKBg/NUKoHeF UB/YL0jcFPt1NuSbJSmao5RNqaFOeWXk/AfK6NN3UFRX1ofoelRGDKillGYNGkadryKU YiB+jclO8wOmbAxlDRp6CI868ddqxaZQYoxQO4ptlBac49PJC4NrNP7CVNMpRBeOWISV CG0fSj7LLtiTo/iZ2ctdJMZd+teBC3HtzJjvFk8R34bSmKfdy/PYY+jxXBwC4VYMmi/y vaUAI6p9xh9NDBkfQox0uMHrqwTlrGU9lRjH1mBA4kIvjyChlq4pyPDztxuGxND7CQtm kHwQ== X-Gm-Message-State: APjAAAURhi2IbNEPJbkzBNOK2EIXVi8mjHvJHxv+rFQgWvmboVvXV0lt Ja387IB/u4nhhK++SiPaWrUz/LOwk1rErvupaL7kVA== X-Google-Smtp-Source: APXvYqz/8xJBvM5YApkc8q1BMr1dT5VicIPSZVfioxxqqY6SMtW097rTx7U+hky1E4IR1FcJP1uIwN60haaDiBmSyao= X-Received: by 2002:a17:902:4183:: with SMTP id f3mr3975974pld.336.1560955346243; Wed, 19 Jun 2019 07:42:26 -0700 (PDT) MIME-Version: 1.0 References: <7cd942c0-d4c1-0cf4-623a-bce6ef14d992@arm.com> <20190612150040.GH28951@C02TF0J2HF1T.local> In-Reply-To: <20190612150040.GH28951@C02TF0J2HF1T.local> From: Andrey Konovalov Date: Wed, 19 Jun 2019 16:42:15 +0200 Message-ID: Subject: Re: [PATCH v17 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel To: Catalin Marinas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_074230_044400_B10B4F07 X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "kvm@vger.kernel.org" , Szabolcs Nagy , Will Deacon , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , Khalid Aziz , "linux-kselftest@vger.kernel.org" , Felix Kuehling , Vincenzo Frascino , Mauro Carvalho Chehab , Jacob Bramley , Leon Romanovsky , "linux-rdma@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Jason Gunthorpe , Dmitry Vyukov , Dave P Martin , Evgeniy Stepanov , "linux-media@vger.kernel.org" , Kevin Brodsky , Kees Cook , Ruben Ayrapetyan , Ramana Radhakrishnan , Alex Williamson , nd , "linux-arm-kernel@lists.infradead.org" , Kostya Serebryany , Greg Kroah-Hartman , Yishai Hadas , "linux-kernel@vger.kernel.org" , Jens Wiklander , Lee Smith , Alexander Deucher , Andrew Morton , enh , Robin Murphy , Christian Koenig , Luc Van Oostenryck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 12, 2019 at 5:01 PM Catalin Marinas wrote: > > On Wed, Jun 12, 2019 at 01:30:36PM +0100, Szabolcs Nagy wrote: > > On 12/06/2019 12:43, Andrey Konovalov wrote: > > > --- /dev/null > > > +++ b/tools/testing/selftests/arm64/tags_lib.c > > > @@ -0,0 +1,62 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > + > > > +#include > > > +#include > > > + > > > +#define TAG_SHIFT (56) > > > +#define TAG_MASK (0xffUL << TAG_SHIFT) > > > + > > > +#define PR_SET_TAGGED_ADDR_CTRL 55 > > > +#define PR_GET_TAGGED_ADDR_CTRL 56 > > > +#define PR_TAGGED_ADDR_ENABLE (1UL << 0) > > > + > > > +void *__libc_malloc(size_t size); > > > +void __libc_free(void *ptr); > > > +void *__libc_realloc(void *ptr, size_t size); > > > +void *__libc_calloc(size_t nmemb, size_t size); > > > > this does not work on at least musl. > > > > the most robust solution would be to implement > > the malloc apis with mmap/munmap/mremap, if that's > > too cumbersome then use dlsym RTLD_NEXT (although > > that has the slight wart that in glibc it may call > > calloc so wrapping calloc that way is tricky). > > > > in simple linux tests i'd just use static or > > stack allocations or mmap. > > > > if a generic preloadable lib solution is needed > > then do it properly with pthread_once to avoid > > races etc. > > Thanks for the feedback Szabolcs. I guess we can go back to the initial > simple test that Andrey had and drop the whole LD_PRELOAD hack (I'll > just use it for my internal testing). OK, will do in v18. > > BTW, when you get some time, please review Vincenzo's ABI documentation > patches from a user/libc perspective. Once agreed, they should become > part of this series. > > -- > Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel