From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3739C43465 for ; Fri, 18 Sep 2020 12:28:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 816FC20874 for ; Fri, 18 Sep 2020 12:28:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tz1o4ACt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="AJCCnnw6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 816FC20874 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EWVGBFrhKMT/zq7ZK2SA4fGZKff43cT4/FLoVR/jyVs=; b=tz1o4ACtpKNsUXOSE8KP3dRev yM0+7OooPsNokh2FtVoIUo7cilufTHVDt/lTVujQEERrR3x26fSTWLrD4GlFbjlnzReP08aVoUARr JaPWWtNG2ZbSeJiFMowB8t1y6OJVX7bUmGsmwATmLewbc9tLRr/kMknol423aI0NFmlxZr/tlmmGo RHcTeQugPm7cA5/TnQThS0Hf8cCK/P9V70Hpzlmn3nZrZA7IngGliZfZoh9WpTDMhkxYi93iDVo6E sqGed+bdcvjRinQ0nizlVPQFu8mzQvnmRxdZQIkhZLWGaCdusfmC3tUjfJ59On39WR8KyRoXHqvnZ EcCrTPTgQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJFTf-0002vs-9o; Fri, 18 Sep 2020 12:26:59 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJFTc-0002ui-VU for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 12:26:57 +0000 Received: by mail-pj1-x1043.google.com with SMTP id kk9so2946701pjb.2 for ; Fri, 18 Sep 2020 05:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VtDuINtc2G9zXnT6yMkHKsVlqkwJ9oqFqRt0wDdeL5k=; b=AJCCnnw6tN19AAXWg3y1FLDWhgP3sqtVLj3UtkH7f5Gj5EBbXqJiaR76bYfgB5yW1j tWEk0FgH5vpUtFcFOesKYhV682HXzfo3Z0A34PgGF44tY5nNk+Px0apQRU6glvov9LQu p4bZD6g1GqqgtBaAeUOpeUpEu0TRyx8Ke+6r1FXgxr2zQkx5HE+F2ZpbboqjDAGSYRe+ viX6grNfng/GGxSAU9lPI/k/MAP6An+7vvjI3w52E+XJZsxRqr9yPl1eITgCQ5i4DtT/ LyXqyF4EL75ZLLTfnE5RhxhV80diK25ZXt7GBISXN8ampQT416w9K6nu8SY+RVhhmlsd BAYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VtDuINtc2G9zXnT6yMkHKsVlqkwJ9oqFqRt0wDdeL5k=; b=hMrSSjFsmwNalA7jnF5KKV4TLLGD88aE1GCglviFj4HrPAH/Qv4kRENuMpGY8BxLiS YIY0onVeCpIBgTwb6elQt9fkib9D8Wf+D7TLq1aoHhf02ubXvguwqJeMqGESosc65L95 SnYMNrzGi0ptgvdskqPs3bzCeOqRuFWSsWQyasdBOy7oy4sXb2UggzGjloqOo3xbZs4z 8LyR8YX7DzsaLGJAvwYVKNS0oG5R7QTYaM9BVD2rOJB/GMQv9ikoTCE2Hj0cPYlWBDS3 8ctrI8m/LBTyVopotjhXS63CPTHi5yw7SZZKdRGNDcmxe7JndnFvjPhLTXkfaJdF8JLY NstA== X-Gm-Message-State: AOAM532eN2i+ylzXI9t8tl9T5iwoTC/7gu7ByAYQ5GJD2/1SU9e+y3Bd S6TN1A9RIYBUfTjF6gmQ+/5PZ95KFrBUO+jx4uZhrQ== X-Google-Smtp-Source: ABdhPJyYLEBC1Xln3czd1Uy/zFGyusoJcCgkY1nP7tWnG45muc49K7pFb6HuBunJOrmB5mw4FOQtyVhIyRqFtb7C9Gk= X-Received: by 2002:a17:902:d888:b029:d0:cb2d:f274 with SMTP id b8-20020a170902d888b02900d0cb2df274mr32829839plz.13.1600432014609; Fri, 18 Sep 2020 05:26:54 -0700 (PDT) MIME-Version: 1.0 References: <20200917170418.GI10662@gaia> In-Reply-To: <20200917170418.GI10662@gaia> From: Andrey Konovalov Date: Fri, 18 Sep 2020 14:26:43 +0200 Message-ID: Subject: Re: [PATCH v2 34/37] kasan, arm64: print report from tag fault handler To: Catalin Marinas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_082657_046513_CD539E85 X-CRM114-Status: GOOD ( 20.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Marco Elver , Elena Petrova , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Linux Memory Management List , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 17, 2020 at 7:04 PM Catalin Marinas wrote: > > On Tue, Sep 15, 2020 at 11:16:16PM +0200, Andrey Konovalov wrote: > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > > index cdc23662691c..ac79819317f2 100644 > > --- a/arch/arm64/mm/fault.c > > +++ b/arch/arm64/mm/fault.c > > @@ -14,6 +14,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -295,17 +296,23 @@ static void die_kernel_fault(const char *msg, unsigned long addr, > > do_exit(SIGKILL); > > } > > > > +#ifdef CONFIG_KASAN_HW_TAGS > > static void report_tag_fault(unsigned long addr, unsigned int esr, > > struct pt_regs *regs) > > { > > - bool is_write = ((esr & ESR_ELx_WNR) >> ESR_ELx_WNR_SHIFT) != 0; > > + bool is_write = ((esr & ESR_ELx_WNR) >> ESR_ELx_WNR_SHIFT) != 0; > > > > - pr_alert("Memory Tagging Extension Fault in %pS\n", (void *)regs->pc); > > - pr_alert(" %s at address %lx\n", is_write ? "Write" : "Read", addr); > > - pr_alert(" Pointer tag: [%02x], memory tag: [%02x]\n", > > - mte_get_ptr_tag(addr), > > - mte_get_mem_tag((void *)addr)); > > + /* > > + * SAS bits aren't set for all faults reported in EL1, so we can't > > + * find out access size. > > + */ > > + kasan_report(addr, 0, is_write, regs->pc); > > } > > +#else > > +/* Tag faults aren't enabled without CONFIG_KASAN_HW_TAGS. */ > > +static inline void report_tag_fault(unsigned long addr, unsigned int esr, > > + struct pt_regs *regs) { } > > +#endif > > So is there a point in introducing this function in an earlier patch, > just to remove its content here? I added it to make the first patch somewhat self-consistent. But we can drop it in v3 if you think it's not needed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel