From: Chunyan Zhang <zhang.lyra@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Jiri Slaby <jslaby@suse.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Orson Zhai <orsonzhai@gmail.com>, Will Deacon <will@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD
Date: Mon, 9 Mar 2020 09:17:40 +0800 [thread overview]
Message-ID: <CAAfSe-sonfA=6x9uvQXaHniQaXR8hWZa4uOcWxoo+Z_XT9QNhw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdU-gAhupHotQTHAZfopkGF_jQc-VrVxb24caw_BfzWd6g@mail.gmail.com>
Hi Geert,
On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Chunyan,
>
> On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> > From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> >
> > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s,
> > since we want them can be built-in when ARCH_SPRD is set as 'm'.
>
> Why would you want a serial driver for a specific platform to be builtin,
> while all other platform support is modular?
Oh, that's not this patch means.
We just want serial driver can be builtin for any platform, so it
should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD)
, otherwise if the config was set as 'm', the serial driver can't be
selected as 'y' then.
That's what I mean.
Cheers,
Chunyan
>
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > ---
> > drivers/tty/serial/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index 52eaac21ff9f..2b9addc0afb5 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135
> >
> > config SERIAL_SPRD
> > tristate "Support for Spreadtrum serial"
> > - depends on ARCH_SPRD
> > select SERIAL_CORE
> > help
> > This enables the driver for the Spreadtrum's serial.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-09 1:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 10:32 [PATCH 1/2] arm64: change ARCH_SPRD Kconfig to tristate Chunyan Zhang
2020-03-05 10:32 ` [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD Chunyan Zhang
2020-03-06 12:41 ` Geert Uytterhoeven
2020-03-09 1:17 ` Chunyan Zhang [this message]
2020-03-09 8:01 ` Geert Uytterhoeven
2020-03-09 8:42 ` Chunyan Zhang
2020-03-09 10:32 ` Geert Uytterhoeven
2020-03-09 11:15 ` Chunyan Zhang
2020-03-09 14:10 ` Orson Zhai
2020-03-09 8:03 ` [PATCH 1/2] arm64: change ARCH_SPRD Kconfig to tristate Geert Uytterhoeven
2020-03-09 8:32 ` Chunyan Zhang
2020-03-09 10:32 ` Geert Uytterhoeven
2020-03-10 4:19 ` Sandeep Patil
2020-03-10 4:27 ` Sandeep Patil
2020-03-10 8:47 ` Geert Uytterhoeven
2020-03-10 9:41 ` Orson Zhai
2020-03-10 9:52 ` Geert Uytterhoeven
2020-03-10 10:13 ` Orson Zhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAfSe-sonfA=6x9uvQXaHniQaXR8hWZa4uOcWxoo+Z_XT9QNhw@mail.gmail.com' \
--to=zhang.lyra@gmail.com \
--cc=baolin.wang7@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=chunyan.zhang@unisoc.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).