From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 236B9C433FF for ; Tue, 30 Jul 2019 07:19:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9900205F4 for ; Tue, 30 Jul 2019 07:19:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MgYED7Rs"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FsYufJjw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9900205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DP/rf3x1EpudZBPLbCtUzL4HWAIVdubivewv1aleTbQ=; b=MgYED7RsgJzGgL M5LyOwcxchd2+qB/kAUJKpmH0pyRYIjUkPJAWTbMhCf2iWJhXVLqRPrRJBe34ZeE/LFsIz3yL4bjn KmOv2q2ykRQfNcxAVfyac/pKix2KL1jTVNmFf+jCwXHZOunz5ChhCdgboG/00mZ3EYoZ4y5sHqWDn H9KtlFU5hccyx5t1Zz78oNDiUuMgaX0DoIQE6trgEJy6XW/oN/dx78Rq/mmK+9GHFegAQ74gciOn+ SXQxInLtI61TCSaS1+UkbksQ28h3uhY9kaTEkZ6HctTB6ln07KpGOtYmPqSZ7/SHG+Qz1qSFPHjha g8FcDvCG6empn56G2G1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsMPj-0001tF-Ms; Tue, 30 Jul 2019 07:19:15 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsMPd-0001su-FO for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2019 07:19:11 +0000 Received: by mail-wm1-x344.google.com with SMTP id s3so56006399wms.2 for ; Tue, 30 Jul 2019 00:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DZt6vkvXDTCmaHGGjiNswfodyAXn9IWa9yBxuOiSg1E=; b=FsYufJjwqp5VVH/4FN9Vk3nxH0jNCRjcDIlpadgiX4rTPO6+sk8keBlw/LFdyAcjp5 NDvCAVT3mzGk58TuXvRvIZ6CMU0VEq7LqOIDeve6Enk46ld+tcmETsr9j/JZJm7Jq+FV ygvQGhKpT6oAfQNv4FnR3hNx5i+KUYUy2CIhJIo8X06pp6L2lOLIH/BHAjVrcRzYzK3e Msy9r8B+PoEoGZyD/082UTR/9FckdXu3oAjDYka6KgzdV5mndvvYsSHwDaLFX9eQkU0G rs40dOuvUIl11Lm6ifPyuqmFU3fq5ENRCCIwACRr/t4KmINhB/oLr8P0DWgGQ1O2Mozh Y2/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DZt6vkvXDTCmaHGGjiNswfodyAXn9IWa9yBxuOiSg1E=; b=LD9bBB0Nbqr1DKapGfvl8l86ZiCJ00F7DyBw6SThhPxK86jegh+H0sc5vdEHUldC3e 5ermfkQ5TjQUschpF1WN4TQlW4s3bHUsQyA6RxYxOhonhJtB1964xJ/x3/AMgdgl1qQh Gogd3orX8khdsazgp/Bje5phvZ9zxeb1LU5yAmNlCD1kXKpJF9hz4SkuxcuirMZOGvXq xUAXCOyEFVy4cTM+vAQpYAhyBhpUv0FiN3XrMmMD7RNMCnnYj537y1h3EKAf6ZIBb1Eg W4dt8sGJTJ5BtIozHRnrke6BF0Ol1sXXwVNBHeHZLU/MplMUKOO8BFNuFv1Ti/d/Jy5X JLNw== X-Gm-Message-State: APjAAAVTY68QvbLOhsApyeaqjBjBzQqltQrR/7jMg28+HEmmecMOq7OQ FToesiYhrmcRbh684IXl4xeJn87GkevhwtuSOW8= X-Google-Smtp-Source: APXvYqy7X+m5nMBdYWJvObDm1/TffZatcBrS6OcX+i57wYVXzbjHVSZEO5NsRhWXZuMJ+wNmsJ3vWnw8+4uEdeTAPNw= X-Received: by 2002:a1c:9c8a:: with SMTP id f132mr103653071wme.29.1564471147596; Tue, 30 Jul 2019 00:19:07 -0700 (PDT) MIME-Version: 1.0 References: <20190722071122.22434-1-zhang.lyra@gmail.com> <20190722071419.22535-1-zhang.lyra@gmail.com> In-Reply-To: <20190722071419.22535-1-zhang.lyra@gmail.com> From: Chunyan Zhang Date: Tue, 30 Jul 2019 15:18:31 +0800 Message-ID: Subject: Re: [PATCH] ARM: check stmfd instruction using right shift To: Russell King , Linux ARM , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190730_001909_543874_1B7DF79D X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lvqiang Huang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Gentle ping probably this patch was missed or entered into spam? On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang wrote: > > From: Lvqiang Huang > > In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"), > - .word 0xe92d0000 >> 10 @ stmfd sp!, {} > + .word 0xe92d0000 >> 11 @ stmfd sp!, {} > then the shift need to change to 11. > > Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read") > Signed-off-by: Lvqiang Huang > Signed-off-by: Chunyan Zhang > --- > arch/arm/lib/backtrace.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S > index 7d7952e..926851b 100644 > --- a/arch/arm/lib/backtrace.S > +++ b/arch/arm/lib/backtrace.S > @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions > > 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists, > ldr r3, .Ldsi+4 @ adjust saved 'pc' back one > - teq r3, r2, lsr #10 @ instruction > + teq r3, r2, lsr #11 @ instruction > subne r0, sv_pc, #4 @ allow for mov > subeq r0, sv_pc, #8 @ allow for mov + stmia > > -- > 1.7.9.5 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel