From: Chunyan Zhang <zhang.lyra@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Chunyan Zhang <chunyan.zhang@unisoc.com>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, soc@kernel.org,
devicetree@vger.kernel.org,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Orson Zhai <orsonzhai@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: Add support for Unisoc's UMS512
Date: Tue, 7 Feb 2023 10:19:48 +0800 [thread overview]
Message-ID: <CAAfSe-v3VW_sE4FwjURoOapMXrGavOK0hzeU-84-U_6xfhYbQQ@mail.gmail.com> (raw)
In-Reply-To: <41fd5c2a-9fc5-8af8-b66e-45bb83b24179@linaro.org>
On Thu, 19 Jan 2023 at 19:40, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 18/01/2023 09:40, Chunyan Zhang wrote:
> > Add basic support for Unisoc's UMS512, with this patch,
> > the board ums512-1h10 can run into console.
> >
[snip]
> > + ap-apb {
>
> Non-unit-address nodes cannot be mixed with unit address ones. Something
> is wrong here.
To make sure I understand correctly, did you mean non-unit-address
nodes shouldn't be the parent of unit-address nodes?
Does that mean the bus node should have a unique base address like:
ap-apb@70000000 {
...
Thanks,
Chunyan
>
> > + compatible = "simple-bus";
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > +
> > + sdio0: sdio@71100000 {
> > + compatible = "sprd,sdhci-r11";
> > + reg = <0 0x71100000 0 0x1000>;
> > + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> > + clock-names = "sdio", "enable";
> > + clocks = <&ap_clk CLK_SDIO0_2X>,
> > + <&apapb_gate CLK_SDIO0_EB>;
> > + assigned-clocks = <&ap_clk CLK_SDIO0_2X>;
> > + assigned-clock-parents = <&pll1 CLK_RPLL>;
> > + status = "disabled";
> > + };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-07 2:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 8:40 [PATCH] arm64: dts: Add support for Unisoc's UMS512 Chunyan Zhang
2023-01-19 11:40 ` Krzysztof Kozlowski
2023-02-06 9:28 ` Chunyan Zhang
2023-02-06 10:34 ` Krzysztof Kozlowski
2023-02-07 2:19 ` Chunyan Zhang [this message]
2023-02-07 7:59 ` Krzysztof Kozlowski
2023-02-07 8:21 ` Chunyan Zhang
2023-02-07 8:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAfSe-v3VW_sE4FwjURoOapMXrGavOK0hzeU-84-U_6xfhYbQQ@mail.gmail.com \
--to=zhang.lyra@gmail.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).