From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7833C47095 for ; Wed, 9 Jun 2021 08:57:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79ECF610F8 for ; Wed, 9 Jun 2021 08:57:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79ECF610F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OR98J9LIPZTeq1wRE8hxhca2qXmjv14OxYqdKhIBCVk=; b=PJslu6CRxCHZst Jq+2DxmKgLAAsmSIPWbY3sSRUnXJaxRGWHhnnBQefXR5tXS02oRMvPnAJ5Dgp4YlOZHzUOOz/81OI 6TsIUG3+4CFFILUa8KVZvxZ6smd2t0iN0nWZQhG0KQpHh5eQU7pwQc/WlSvdMGFmffCjdg7Zup+T0 2M97Kg2iDkEftuaCf6GilI0ve2yyhlTaRymEWHYAYAXf7r/waQN5KdpbSOrUxjPRBW7QfOPBav1gK R5Ekl1nXejxeaMh2OfD9l2NIxM0UOynZZfDiwK7Voas7IVIEodsAdfoasXkkszXQv9PQ/v99AxyMD YE/ujn0iP6WdmrC52gTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqtxp-00CV2U-Fl; Wed, 09 Jun 2021 08:53:31 +0000 Received: from mail-wm1-f45.google.com ([209.85.128.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqtAw-00CFyH-8r for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 08:02:59 +0000 Received: by mail-wm1-f45.google.com with SMTP id t4-20020a1c77040000b029019d22d84ebdso3618292wmi.3 for ; Wed, 09 Jun 2021 01:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ju48vJplC/eqeHsAD3uNcfdCHg6qYZAOA8GhsxxsbGo=; b=RoJROVGx6pF3QoOuy/LW0b+B8pW4z/Gu8UsSrljkaodrIneT6aJ5VDM0xOo4QyIIzv Gj2yhqG8i/swO3l9mOI7UPStpX1mkoZb+9ZtFCrLBtHfdInHXO9DQzrqz6EnoBSCsDbJ CQyY7YdW8oig7+dPjOpzWmgH7zhMtk+yZskpmYk3+dOlc4KOXd1RxbP+Umt+54CUVZRm azXxGHY98MXetAA5dphBGr6CRGTv5bFOtfhkbMHOjIHtgKGknZuZd1qGV9narPBcUBvS wo8IGBL6tczovK1vv5CFCBG+VcQXdNaQ1n3muF+jV116E+phUJQoQ0NfkYF+TlXToFlL njGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ju48vJplC/eqeHsAD3uNcfdCHg6qYZAOA8GhsxxsbGo=; b=hBfoxUKgkeGyAuQpuS2CTBjl2FFtH5qGTwaZgdlP1tr2sR9XawCikNTlbBpGyyddRO FfuPJ7qthOdfNBir0W3V7CFxPEq9rq2a/FBduJ5SUHsZPaLrmocBjWLOzkx3U2fDpoaT iF08d8N6P7kdhNrpazHHNPcKzRK0v+VNEEyz4ZxqduUqzuXmnRGhfV0/P/j+5X5hqEyc HWdviY13PlYYJQwqRtoAakh4wa2/aISWLn7+NRI+l7EII3zN3HEbGHPZE9dh//kDAoqj Ss0DJs3AlfKcIsOTvtUuWO5tSEuXM5gpAtgNp6W9NrPbkPQ6AWcvlv8NBEsAQx3O8Z5y f13Q== X-Gm-Message-State: AOAM530rBk1wtEh1yxw7awGTyx7TCWLaseBT779EXJOrHAv7NcBaU8kS QcOuF1hHo6mvT8BaR7jpEMbGezAyuiB5Ryu7qcUqOg== X-Google-Smtp-Source: ABdhPJwCl3qJZm5Z606JSaosHKIbg85Mj+Z7FrvUrA4ecB82gMzqX8XkomV2Nv0hp9Jl1/jpfn0HzS95ejA1SCogr7s= X-Received: by 2002:a7b:c1c5:: with SMTP id a5mr26760837wmj.134.1623225715467; Wed, 09 Jun 2021 01:01:55 -0700 (PDT) MIME-Version: 1.0 References: <20210602112321.2241566-1-anup.patel@wdc.com> <20210602112321.2241566-6-anup.patel@wdc.com> <82217630-5f89-50dc-bbca-e591bee90950@sholland.org> In-Reply-To: <82217630-5f89-50dc-bbca-e591bee90950@sholland.org> From: Anup Patel Date: Wed, 9 Jun 2021 13:31:44 +0530 Message-ID: Subject: Re: [PATCH v5 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Samuel Holland Cc: Anup Patel , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , DTML , linux-riscv , "linux-kernel@vger.kernel.org List" , "open list:THERMAL" , linux-arm-kernel , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , Ulf Hansson , "Rafael J . Wysocki" , Pavel Machek , Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_010258_337036_6818F519 X-CRM114-Status: GOOD ( 23.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 7, 2021 at 12:04 AM Samuel Holland wrote: > > On 6/2/21 6:23 AM, Anup Patel wrote: > > The generic power domain related code in PSCI domain driver is largely > > independent of PSCI and can be shared with RISC-V SBI domain driver > > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > > > Signed-off-by: Anup Patel > > Reviewed-by: Ulf Hansson > > --- > > MAINTAINERS | 7 + > > drivers/cpuidle/Kconfig | 4 + > > drivers/cpuidle/Kconfig.arm | 1 + > > drivers/cpuidle/Makefile | 1 + > > drivers/cpuidle/cpuidle-psci-domain.c | 138 +------------------ > > drivers/cpuidle/cpuidle-psci.h | 15 ++- > > drivers/cpuidle/dt_idle_genpd.c | 182 ++++++++++++++++++++++++++ > > drivers/cpuidle/dt_idle_genpd.h | 50 +++++++ > > 8 files changed, 263 insertions(+), 135 deletions(-) > > create mode 100644 drivers/cpuidle/dt_idle_genpd.c > > create mode 100644 drivers/cpuidle/dt_idle_genpd.h > > > ... > > diff --git a/drivers/cpuidle/dt_idle_genpd.h b/drivers/cpuidle/dt_idle_genpd.h > > new file mode 100644 > > index 000000000000..a8a3bad3cb7f > > --- /dev/null > > +++ b/drivers/cpuidle/dt_idle_genpd.h > > @@ -0,0 +1,50 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef __DT_IDLE_GENPD > > +#define __DT_IDLE_GENPD > > + > > +struct device_node; > > +struct generic_pm_domain; > > + > > +#ifdef CONFIG_DT_IDLE_GENPD > > + > > +void dt_idle_pd_free(struct generic_pm_domain *pd); > > + > > +struct generic_pm_domain *dt_idle_pd_alloc(struct device_node *np, > > + int (*parse_state)(struct device_node *, u32 *)); > > + > > +int dt_idle_pd_init_topology(struct device_node *np); > > + > > +struct device *dt_idle_attach_cpu(int cpu, const char *name); > > + > > +void dt_idle_detach_cpu(struct device *dev); > > + > > +#else > > + > > +static inline void dt_idle_pd_free(struct generic_pm_domain *pd) > > +{ > > +} > > + > > +static inline struct generic_pm_domain *dt_idle_pd_alloc( > > + struct device_node *np, > > + int (*parse_state)(struct device_node *, u32 *)); > > In file included from drivers/cpuidle/cpuidle-sbi.c:27: > drivers/cpuidle/dt_idle_genpd.h:29:1: error: expected identifier or '(' > before '{' token > 29 | { > | ^ > > Looks like you have a stray semicolon here. Okay, I will fix this in the next revision. Regards, Anup > > > +{ > > + return NULL; > > +} > > + > > +static inline int dt_idle_pd_init_topology(struct device_node *np) > > +{ > > + return 0; > > +} > > + > > +static inline struct device *dt_idle_attach_cpu(int cpu, const char *name) > > +{ > > + return NULL; > > +} > > + > > +static inline void dt_idle_detach_cpu(struct device *dev) > > +{ > > +} > > + > > +#endif > > + > > +#endif > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel