From: 胡海 <hhtracer@gmail.com> To: "huanglingyan (A)" <huanglingyan2@huawei.com> Cc: Zhangshaokun <zhangshaokun@hisilicon.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, linux-arm-kernel@lists.infradead.org, ard.biesheuvel@linaro.org Subject: Re: [PATCH v3] arm64: lib: accelerate do_csum with NEON instruction Date: Thu, 10 Jan 2019 12:08:46 +0800 Message-ID: <CAAq-RfT_Kjd8hbm=BaRg5a6uvTGLzZipt91wpSPXCW51hGTnNQ@mail.gmail.com> (raw) In-Reply-To: <cd5bb83e-bb0e-b348-5365-095c5fcd9648@huawei.com> hi, huanglingyan Have you verified the correctness of do_csum? I validated it on FT2000+ and do_csum got the wrong result. You can test it by increasing the input length to more than 60000 and setting all buffs to 0xff. I think it's possible that vpadalq_u16 will overflow, and the code doesn't take this into account. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-06 1:55 Lingyan Huang 2019-01-06 8:26 ` Ard Biesheuvel [not found] ` <9129b882-60f3-8046-0cb9-e0b2452a118d@huawei.com> 2019-01-08 13:54 ` Will Deacon 2019-01-09 2:03 ` huanglingyan (A) 2019-01-10 4:08 ` 胡海 [this message] 2019-01-10 8:14 ` huanglingyan (A) 2019-01-16 16:46 ` Will Deacon 2019-01-18 1:07 ` huanglingyan (A) 2019-01-18 11:14 ` Ard Biesheuvel 2019-02-12 2:26 ` huanglingyan (A) 2019-02-12 7:07 ` Ard Biesheuvel 2019-02-13 8:42 ` huanglingyan (A) 2019-02-13 9:15 ` Ard Biesheuvel 2019-02-13 17:55 ` Ard Biesheuvel 2019-02-14 9:57 ` huanglingyan (A) 2019-02-18 8:49 ` huanglingyan (A) 2019-02-18 9:03 ` Ard Biesheuvel 2019-01-09 14:58 ` Dave Martin 2019-01-10 8:03 ` huanglingyan (A) 2019-01-10 13:53 ` Dave Martin [not found] <1f065749-6676-6489-14ae-fdcfeeb3389c@huawei.com> 2019-01-07 6:11 ` huanglingyan (A)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAAq-RfT_Kjd8hbm=BaRg5a6uvTGLzZipt91wpSPXCW51hGTnNQ@mail.gmail.com' \ --to=hhtracer@gmail.com \ --cc=ard.biesheuvel@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=huanglingyan2@huawei.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=will.deacon@arm.com \ --cc=zhangshaokun@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git