From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49EE7CA9EC9 for ; Mon, 4 Nov 2019 21:38:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E78F20869 for ; Mon, 4 Nov 2019 21:38:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pDGLaHlH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="AMgSst2h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E78F20869 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TVw/YkDOzzQcfshCFn5NwyVvqpyhuFDNHQggkXgg74o=; b=pDGLaHlHUXBC/V 7W3EgUbmAW8V3Z7AX8PCzCz5JGK8MeOGA6yfEQ4io6fIsbRX5yoP8a3wo3escMX1Bd6pMRBfIHaZz THhaKRBiViSCulHv/mXeambVVoExPcCKFeUjIZbj1waYnUQVx8+tDf0TWSMiePhM9noIWwbtT853w GQ9eMOlyhSKnlmTJ4FivT0CP74xXf5TdzdmK5Lc8A7GzIbtWnLLgiZwQ0CTTrRNXpIVwgT5L0hH1v Lv3Woq93LfPX8LmoanUbUHhnECNmy9SJFtiS/aICgWdkPCt6iRvmH+2x/AzLDA6nM4MoBcobTUouu VEFpgnzeiO4hOWUaAbRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRk3h-0007fX-OS; Mon, 04 Nov 2019 21:38:45 +0000 Received: from mail-vk1-xa41.google.com ([2607:f8b0:4864:20::a41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRk3f-0007ex-OH for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 21:38:44 +0000 Received: by mail-vk1-xa41.google.com with SMTP id o82so2270122vka.5 for ; Mon, 04 Nov 2019 13:38:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=erA0+CgO32nkALAW/U97P1GwaRL1ou+VA5YnrGmuWIY=; b=AMgSst2hoIv0GZSG/6Hv3sj7G4QTMHoXZaK+uecCN92VkYk2ZpXGLlGKNE7LaQkMOV GALbiSTH4QXZuxCs4vXVQ+PvBEvuBmB7k5aqf+G9gnmvHWB5/Y+uNebLr8WkNd+bS+Ov /XXES1wI9li/uMeZkpl2e89se5snh4JkYGrWHWMFeboxhZVboLE1Ab4qQKsBrgjgaJ0Z TPALZl6SFGfHwCWeRXmzVYpIwJ+aRCFQbHaYCGtjIRAIEY7ObGDK19pVPN3DP2bzseFq kO3Sq+THrsVH8U3L8DmX49sKk84SksyJMDaTiPQHmYPUwA9Od1QsJS2NmYqwVYjSpzCB i+5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=erA0+CgO32nkALAW/U97P1GwaRL1ou+VA5YnrGmuWIY=; b=R4QynmidqzoeAznz4QdU8kF32AMxICuySOozetsrv1MbvOtCma5Xu026r6DTgEQn0K y9ZqwlICZ7s43shkEMrlZYRyoaHPqZkG3ivwhu4dmKmKW1l6B8p/e+bOiTITkE6xEiJD Xt6HSTSGxZ0UemrCHL7Zx6Ph0RO1zcM5itkIXty7CskPqXSVVGnW5GdJi6fK4WMDgE7p qfPYodBJByJgi8DO0YiOtdB1AYLgqxqhGuj59UaWw0JyshcGBdZ3CBRZUVGacBcSjnnd N7hYVzj8Tm/slOjP76M9yiEw8mLlKcIZ2NPMSN2T9V4+bcshc8YgqiGtdEiqPEoC4RcD w9mw== X-Gm-Message-State: APjAAAW5N/ANmClBrcmukNJ2/s1UmkAIL02JAKBmQSGfrRT4KsIUOpwi Udsajp9McqThqoKmwY2OiXd61nqCCFwHAkPLSf+ZyA== X-Google-Smtp-Source: APXvYqwHIA8tjMB/idsGTHUTWfDb2R4/Q6AYLqiE/ovPTmnmanOsh2FI1AtdGkwKNIfH3EsSyXxnypTSqw/H2MHfj8Y= X-Received: by 2002:a1f:7d88:: with SMTP id y130mr12696794vkc.71.1572903521740; Mon, 04 Nov 2019 13:38:41 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-14-samitolvanen@google.com> <02c56a5273f94e9d832182f1b3cb5097@www.loen.fr> In-Reply-To: <02c56a5273f94e9d832182f1b3cb5097@www.loen.fr> From: Sami Tolvanen Date: Mon, 4 Nov 2019 13:38:30 -0800 Message-ID: Subject: Re: [PATCH v4 13/17] arm64: preserve x18 when CPU is suspended To: Marc Zyngier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_133843_814443_D2DDF181 X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , Masami Hiramatsu , clang-built-linux , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 4, 2019 at 5:20 AM Marc Zyngier wrote: > > ENTRY(cpu_do_suspend) > > mrs x2, tpidr_el0 > > @@ -73,6 +75,9 @@ alternative_endif > > stp x8, x9, [x0, #48] > > stp x10, x11, [x0, #64] > > stp x12, x13, [x0, #80] > > +#ifdef CONFIG_SHADOW_CALL_STACK > > + str x18, [x0, #96] > > +#endif > > Do we need the #ifdefery here? We didn't add that to the KVM path, > and I'd feel better having a single behaviour, specially when > NR_CTX_REGS is unconditionally sized to hold 13 regs. I'm fine with dropping the ifdefs here in v5 unless someone objects to this. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel