From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A302CA9EA9 for ; Fri, 18 Oct 2019 17:05:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D37E2064A for ; Fri, 18 Oct 2019 17:05:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lDa/8lAw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="pru8Y7xs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D37E2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H6++HtvWSqB/to6rFAz6S75ArjbN5L+tMgJPrMS0Sv4=; b=lDa/8lAw8Tow68 lVeQievXfFjnZeJXb6BdfZt/bf2kPHTHz4pSRTcJ7m+uTUh/e6TVtFrf4HPy42o1cPCT706bvEKGJ Mu2NgO0MJ+V1BmTBKbnx011LQfqsarxaAM5C8OW/d2CQl9T6oDNZ2GfOfi0B+DuEeJ4rnDfJUUyna rzEo2yV8smf/STZGD6Voo9Q6jfd8/Isy9VWuAUuVYQC+Tv0gNNhwnh18T2Od3g7Ni3j6zfoYlyOiZ 3uwdLYUbdYujdgKre+WDziqZ8QSOdrqsrT4h9FwttPbitr2Wp+SQdnXabF81fYHYBqvfbCRhMXFt3 iUrK5l809zMJhPfGTHvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLVh2-0001tG-Qr; Fri, 18 Oct 2019 17:05:36 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLVh0-0001sF-P2 for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2019 17:05:36 +0000 Received: by mail-vs1-xe44.google.com with SMTP id z14so4470856vsz.13 for ; Fri, 18 Oct 2019 10:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x6GpsgHPaenSyC5p+IrYQknWia4lKY0B5Vf4l4gdQSw=; b=pru8Y7xsWSIdqZR1UXLglz64NrdFImykv1hpXma1k378qh9GF0SPliCcyZB8vMX7gE X3PfTswubuOthM8DCa4MKuMqqB1ZfOPHIhuEN9TMHd7OTZoscSb0DkIwcKzx/zVRsRzZ QpVsX696Og4ZxdvD3yeFj/AnBmqkJaxHpcBabDgxa1/06jnOKR4SPg62RTTmmQ52t+8S vOzXu4T6IK5JJ+sLrpw1VPCRku6gZS08n7Kckhw2KqDpdWTQICKrAUvwcmSbe2WDexT6 KcVKUWL1M2hSYKLv2USJ9PsVEnaLnEqc22VydBFXRMPGh4AiAOA8mz7cgBZHgxDEDolP r6Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x6GpsgHPaenSyC5p+IrYQknWia4lKY0B5Vf4l4gdQSw=; b=S6h2azcH0TuL+i6a3GKp8zrSDXQueFUH6Xrtxvh0cTO0ArXzY7CmXyfO8wUuwa83+N CQckCvg+4j41P86WqNnKn7bpeq15P3JimYW3JW+vRnjfl59OxQuHWN2hCFvE4a8rrV1h gKsRLEU46zrUrWrQ9+c1yqci65IeWOO7yCAjB0KN/DDlmD+lCCr9G5mnx48tUtVVNYbe PzdTBHEuHvhi0chjwEEUHUnkMSbvhHpjZjSiRYmMy8TPtgh91g02s5TuJfJvvU9yn9ov x9lkL6CKck2WI7ci5pFGsG7+uLanQbBWFiQY/JbF8pPTbgkMdpVvE9o8cAAmPcEldf+U LcVg== X-Gm-Message-State: APjAAAVYH+C1eLzAtnUJzQoYJRZXnoDC1J6B1eziGZCOeirS2dogKaoX f1KEFG/iGUGJoQhdg5nxjExAR0d2MInBer8YvnSSvg== X-Google-Smtp-Source: APXvYqwYzSrQhNESR2odZjGb7CA2wtjkk8PIj6W3+g28TbncpOPsZUdRhuZ5AejLhrFJsW3Q8+X1IzSvMoqY0M2m7JA= X-Received: by 2002:a67:ffc7:: with SMTP id w7mr6159173vsq.15.1571418330160; Fri, 18 Oct 2019 10:05:30 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-14-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Fri, 18 Oct 2019 10:05:18 -0700 Message-ID: Subject: Re: [PATCH 13/18] arm64: preserve x18 when CPU is suspended To: Nick Desaulniers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191018_100534_843291_41AFF7B1 X-CRM114-Status: GOOD ( 10.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Catalin Marinas , Kernel Hardening , LKML , Steven Rostedt , clang-built-linux , Laura Abbott , Will Deacon , Dave Martin , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 18, 2019 at 9:49 AM Nick Desaulniers wrote: > > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > > index fdabf40a83c8..9a8bd4bc8549 100644 > > --- a/arch/arm64/mm/proc.S > > +++ b/arch/arm64/mm/proc.S > > @@ -73,6 +73,9 @@ alternative_endif > > stp x8, x9, [x0, #48] > > stp x10, x11, [x0, #64] > > stp x12, x13, [x0, #80] > > +#ifdef CONFIG_SHADOW_CALL_STACK > > + stp x18, xzr, [x0, #96] > > Could this be a str/ldr of just x18 rather than stp/ldp of x18 + > garbage? Maybe there's no real cost difference, or some kind of > alignment invariant? Sure, this can be changed to str/ldr. I don't think there's a noticeable difference in cost. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel