From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D89C1C432C3 for ; Fri, 15 Nov 2019 20:19:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A37FA206D9 for ; Fri, 15 Nov 2019 20:19:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aySU2/S+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="sz3oYsEy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A37FA206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FTmknfGCy76tJOWFoPgCpxF4jgO5+mgYUAm1sj6ylhI=; b=aySU2/S++0wjW5 Vondb4EU/MxjYqb74a+D+gH7Ri8+2U0djEg+eglV6QhuS+hDRgOAKWSekLSEtntjv2ht9s7sYJiX2 qPrYY9Y/isGzq+gdd8P6JTDIBgdcF8TIHk3T6ZgdtK7+X9s9yF69DTqnN5y0MmnUe7s7Ua93c0vfW yGj990sjZBexIdKo27j6PMkx1PQyhlIv2YZru3ytaKU1CVoR8qK1b6XdLQDBCTCAuz8DWGX3YSSfU tisfBiQZrf8ovHJbqteOFFkFc063C90fMLcpwEGBv2eWQkqQltKqyCchS5Yqcb5FsJurPZDiF2s5a fuHN2ED+ZFpeJAF2rQQg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVi4E-00068z-08; Fri, 15 Nov 2019 20:19:42 +0000 Received: from mail-vs1-xe42.google.com ([2607:f8b0:4864:20::e42]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVi4A-00068W-Gr for linux-arm-kernel@lists.infradead.org; Fri, 15 Nov 2019 20:19:39 +0000 Received: by mail-vs1-xe42.google.com with SMTP id q21so7165201vsg.3 for ; Fri, 15 Nov 2019 12:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JGaDR9v43Zv6SHpEarxzzn1nbL46+U2IHPBI4tRr2qU=; b=sz3oYsEy6H86AvsBzq8AbZKdjQSN7okat4NCYezwXYe4Nn3roLSKspibusFC5eHUf/ XOZxYpYgje1RauUONtlip6AndrCc1FzEjmqFuEXf/69rqOVa2UBWi0fKU+Kei4F8RfQX +7+vOdylQ6Vj7DNMXqMEOg93IKnt/XFB5vW7yWtdoQvsrjLwYpphuYBP9e1+Qbw3HkGs UbQW5JMFNZJhDACwQBzv7KE+82hTDuxWS8H3YU+Y4iLbH+MU9i1tI1p103NI8UckIlSi o8zaOjuCB9CXHD9+Ooztaj1GSDDxopXYagZX0MrPMJY7b/8XydSkeYdBXQfkOH969mBK m3RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JGaDR9v43Zv6SHpEarxzzn1nbL46+U2IHPBI4tRr2qU=; b=bK54mUQpZePFnMsB+f/Ubg97LYEjF0H/g4nBHh9KmOI6hquLI/8OjcpcqZkc1Si7GQ zNOcsgbAIkoLbAzX3tTpQTdXW0+MJ4BevGhkkqNDM/H7jf6MRa0ErXZMES0BCtDmSEMM cRGLIw3wV1FRrZDqcVJfBVqfG1BaBtkMhpHxr8HC9NtkBnZ8YDtEINPbiH+oMOSU9Np9 a2NBrXD+IvFHU0KcNyxKWxBN5aoU8i4mqAYTbdJCY5tegr3XwnQpY2sO3BGaXhJRSuA3 l0bGp0zL7AKSNrOGeZpmwQ1oYQqu3w2CHzzodYaheazrCuIF9ztu/0kp4EZp1odHztYF 2e3Q== X-Gm-Message-State: APjAAAWVv5PmVZ10Fdt9iZBnmywHqX3PpoBTEnIwUpZMEyEoUwLOfHsU deW8Sl8ZNxLtRxAn1p+oTFo1EmSrsDZZKON9TcoWng== X-Google-Smtp-Source: APXvYqyJJAtOC9yDRTQtthbybCklKzAJjxRAZgrd64ZfvgQMG7E3ZVIDa8qPXRTRklTlBbwY1FtJCZyMYntSX38nxGA= X-Received: by 2002:a67:db10:: with SMTP id z16mr6607389vsj.5.1573849174709; Fri, 15 Nov 2019 12:19:34 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191105235608.107702-1-samitolvanen@google.com> <20191105235608.107702-15-samitolvanen@google.com> <20191115152047.GI41572@lakrids.cambridge.arm.com> In-Reply-To: <20191115152047.GI41572@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Fri, 15 Nov 2019 12:19:20 -0800 Message-ID: Subject: Re: [PATCH v5 14/14] arm64: implement Shadow Call Stack To: Mark Rutland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191115_121938_584087_9F3173E6 X-CRM114-Status: GOOD ( 11.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , clang-built-linux , Masami Hiramatsu , Marc Zyngier , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 15, 2019 at 7:20 AM Mark Rutland wrote: > > On Tue, Nov 05, 2019 at 03:56:08PM -0800, Sami Tolvanen wrote: > > This change implements shadow stack switching, initial SCS set-up, > > and interrupt shadow stacks for arm64. > > Each CPU also has an overflow stack, and two SDEI stacks, which should > presumably be given their own SCS. SDEI is effectively a software-NMI, > so it should almost certainly have the same treatement as IRQ. Makes sense. I'll take a look at adding shadow stacks for the SDEI handler. > Can we please fold this comment into the one above, and have: > > /* > * The callee-saved regs (x19-x29) should be preserved between > * irq_stack_entry and irq_stack_exit. > */ > .macro irq_stack_exit > mov sp, x19 > #ifdef CONFIG_SHADOW_CALL_STACK > mov x18, x20 > #endif > .endm Sure, I'll change this in the next version. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel