From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 180D5C33CAF for ; Thu, 16 Jan 2020 21:45:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD8CC2072B for ; Thu, 16 Jan 2020 21:45:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lEhRRTGl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="tYITaZrs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD8CC2072B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tp3XFFGxACIGwuih0lrzPCG5JCDhPxlSE8hZCv2UoJE=; b=lEhRRTGlDJ3hor 7HDkQQflQpkx70aBW8DAQBgaj4QtYxrH1AXs8rZQGYF5oZgjr+ul7/V5TNDAU+KbcZLXAIljLKpdZ SxZN2FrmrKuRKBF5v3W232NMh4Ai/dyJ/dxipVrvUu29pe2s02aGRIlWbbA+ukTHZ0u2L4glmxz3G XM6ZMrgHDLPa3127ZjcZN4cZ6zUn6XMf6g/lFw0EY3mH9xDJT7u5Skf8aU3Y6MP9TiK76olyUz+eI lX1XzVLjJUmiCQ3tdBK5wzGSjAFdwE+vPIwt2b3nSX2aZsfU+AmwLSJUWZBq75tGnGG3+lZzgBJty jZ/H8bZpclChkBuWz20A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1isCxE-0000G7-5U; Thu, 16 Jan 2020 21:45:28 +0000 Received: from mail-ua1-x941.google.com ([2607:f8b0:4864:20::941]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1isCx8-0000FD-Jh for linux-arm-kernel@lists.infradead.org; Thu, 16 Jan 2020 21:45:25 +0000 Received: by mail-ua1-x941.google.com with SMTP id f7so8209911uaa.8 for ; Thu, 16 Jan 2020 13:45:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tkSAt1Pw50rKdG/hn5morljVtZomrkNl/2z5xne6PRw=; b=tYITaZrsivqfC+GdC03l8Z8h3bZpMk/AxRJZ5m3Cq3lP1GhjDNlzuzFHH0Pn2+w9Bp 7hq+CoXS8VEDdhnMjKVZPNodzvjOUAaKuYJ/ddFf8vOlsJnqSle+AlNiaLEcRnwKSGTP 5gI69wlRAJP+9qKZcEhtfjYhon9km/BJzdEnZr70+1XtamA4m5kF7Ynuucv4V82zyCFO H2TlLCrfyCjDGPgKEI6sEsRnApccctQO8D2j+8EC7xolfZWg7J4pQivRrN9lRA6P8BUk bMbwCjGUJxwYv2NA596Hgs8T4QOpc3vlL/TpIEXN+OH+nuTnqjTX9Bzg6hCJI8tqaUMO EkDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tkSAt1Pw50rKdG/hn5morljVtZomrkNl/2z5xne6PRw=; b=cMma2AasoRrghFn8Gfpn4MmhgL+XwyRq92XrqwJ80PU9pJXy+LeEeiZowoMROFsZ5F 8XcvFQ9/BYmgpYtMpxxLmKQe/D4mjwUghGJ6SM9ku2ho00rH2L0370AUEINuJJYIDvwj hoIye42X2aN/O2RinADzN+ZJ99OMR/IazABKdJ97kn8FlGZC7kvQMHC26dzj92SyOR88 b+u+wXVuC8TgwOsLuNigU793JayRwg0BOsn6+VvenwTecoHms0pTloXg8MFAmLN+1so6 sBKz3yK6TCa0AzsRHblDj1lxyamjmWUWvejfPJWL2XIPWrRdn4A7SnhRgh4ElxC1uA8N Y0Ag== X-Gm-Message-State: APjAAAW/NI8OuK5YeheIKeHR6MMU9HuMuUwGgmyEhTYXHuMxzhfaOpcx 0pO1Md5HC1DfT9Ti75refAg+HVhe9dddK02EosPDaw== X-Google-Smtp-Source: APXvYqx9xgh+f+ErpWs3BksSZ71jt7xPPMU4gWghLYUHcYc41EpoUSU/qL8aa7KJUXqJ40wX1Da/EhNZbQRobWoILhU= X-Received: by 2002:ab0:618a:: with SMTP id h10mr19510791uan.53.1579211120670; Thu, 16 Jan 2020 13:45:20 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191206221351.38241-1-samitolvanen@google.com> <20191206221351.38241-9-samitolvanen@google.com> <20200116173950.GB21396@willie-the-truck> In-Reply-To: <20200116173950.GB21396@willie-the-truck> From: Sami Tolvanen Date: Thu, 16 Jan 2020 13:45:09 -0800 Message-ID: Subject: Re: [PATCH v6 08/15] arm64: disable function graph tracing with SCS To: Will Deacon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200116_134522_674421_645FFCF1 X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , clang-built-linux , Masami Hiramatsu , Marc Zyngier , Kernel Hardening , Laura Abbott , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 16, 2020 at 9:39 AM Will Deacon wrote: > > On Fri, Dec 06, 2019 at 02:13:44PM -0800, Sami Tolvanen wrote: > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index b1b4476ddb83..49e5f94ff4af 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -149,7 +149,7 @@ config ARM64 > > select HAVE_FTRACE_MCOUNT_RECORD > > select HAVE_FUNCTION_TRACER > > select HAVE_FUNCTION_ERROR_INJECTION > > - select HAVE_FUNCTION_GRAPH_TRACER > > + select HAVE_FUNCTION_GRAPH_TRACER if !SHADOW_CALL_STACK > > select HAVE_GCC_PLUGINS > > select HAVE_HW_BREAKPOINT if PERF_EVENTS > > select HAVE_IRQ_TIME_ACCOUNTING > > I think this is the wrong way around, as we support the graph tracer > today and so I think SHADOW_CALL_STACK should depend on !GRAPH_TRACER > and possibly even EXPERT until this is resolved. Sure, sounds reasonable. I'll change this in the next version. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel